2 Commits

Author	SHA1	Message	Date
Alexander Brown	82bacb82a7	test: add Playwright test tags for filtering (@smoke, @slow, @screenshot, domains) (#8441) ... ## Summary Adds structured test tags to all 54 Playwright test files to enable flexible test filtering during development and CI. ## Tags Added | Tag | Count | Purpose | |-----|-------|---------| | `@screenshot` | 32 files | Tests with visual assertions (`toHaveScreenshot`) | | `@smoke` | 5 files | Quick essential tests for fast validation | | `@slow` | 5 files | Long-running tests (templates, subgraph, featureFlags) | | `@canvas` | 15 files | Canvas/graph rendering tests | | `@node` | 10 files | Node behavior tests | | `@ui` | 8 files | UI component tests | | `@widget` | 5 files | Widget-specific tests | | `@workflow` | 3 files | Workflow operations | | `@subgraph` | 1 file | Subgraph functionality | | `@keyboard` | 2 files | Keyboard shortcuts | | `@settings` | 2 files | Settings/preferences | ## Usage Examples ```bash # Quick validation (~16 tests, ~30s) pnpm test:browser -- --grep @smoke # Skip slow tests for faster CI feedback pnpm test:browser -- --grep-invert @slow # Skip visual tests (useful for local development without snapshots) pnpm test:browser -- --grep-invert @screenshot # Run only canvas-related tests pnpm test:browser -- --grep @canvas # Combine filters pnpm test:browser -- --grep @smoke --grep-invert @screenshot ``` ## Implementation Details - Uses Playwright's native tag syntax: `test.describe('Name', { tag: '@tag' }, ...)` - Tags inherit from describe blocks to child tests - Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x` - Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }` ## Test Plan - [x] All existing tests pass unchanged - [x] Tag filtering works with `--grep` and `--grep-invert` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>	2026-01-29 16:34:56 -08:00
Johnpaul Chiwetelu	9ef6f94f92	[fix] Enable AUDIO_RECORD widget in both LiteGraph and Vue nodes modes (#6094) ... Fixed the AUDIO_RECORD widget to display correctly in both rendering modes: - Removed conflicting AUDIO_RECORD registration from ComfyWidgets that was blocking the custom widget implementation in uploadAudio.ts extension - Changed canvasOnly flags from true to false on both audioUIWidget and recordWidget to enable Vue nodes rendering - Added type override (recordWidget.type = 'audiorecord') after widget creation to enable Vue component lookup while preserving LiteGraph button rendering - Removed unused IAudioRecordWidget type definition The widget now works correctly: - LiteGraph mode: Displays as a functional button - Vue nodes mode: Displays full recording UI with waveform visualization ## Summary <!-- One sentence describing what changed and why. --> ## Changes - **What**: <!-- Core functionality added/modified --> - **Breaking**: <!-- Any breaking changes (if none, remove this line) --> - **Dependencies**: <!-- New dependencies (if none, remove this line) --> ## Review Focus <!-- Critical design decisions or edge cases that need attention --> <!-- If this PR fixes an issue, uncomment and update the line below --> <!-- Fixes #ISSUE_NUMBER --> ## Screenshots (if applicable) <!-- Add screenshots or video recording to help explain your changes --> https://github.com/user-attachments/assets/cf6513d4-0a4b-4210-88e2-a948855b5206 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6094-fix-Enable-AUDIO_RECORD-widget-in-both-LiteGraph-and-Vue-nodes-modes-28e6d73d365081faa879f53e3e2dddad) by [Unito](https://www.unito.io) --------- Co-authored-by: bymyself <cbyrne@comfy.org>	2025-10-18 03:15:26 -07:00