Johnpaul Chiwetelu
04286c033a
hotfix: stabilize flaky workflow sidebar browser tests ( #7280 )
...
## Summary
- Fix flaky workflow sidebar browser tests that were failing in headless
mode
- Add retry logic for menu hover operations in Topbar
- Add proper timing/wait helpers for dialog masks and workflow service
completion
- Fix test isolation issues in setupWorkflowsDirectory and drop workflow
test
## Test plan
- [x] Run `pnpm test:browser --
browser_tests/tests/sidebar/workflows.spec.ts` multiple times
- [x] Verify the 3 previously failing tests now pass consistently:
- "Can overwrite other workflows with save as"
- "Can rename nested workflow from opened workflow item"
- "Can drop workflow from workflows sidebar"
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7280-hotfix-stabilize-flaky-workflow-sidebar-browser-tests-2c46d73d365081c5b3badfafe35a63dc )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Terry Jia <terryjia88@gmail.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Luke Mino-Altherr <luke@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
2025-12-09 23:30:40 -07:00
Alexander Brown
5c01861f4e
Tests: Playwright test timeouts ( #7231 )
...
## Summary
See where we can use proper DOM waiting instead of waitForTimeout.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7231-WIP-Playwright-test-timeouts-2c36d73d3650812b966ac3d9c338dfd4 )
by [Unito](https://www.unito.io )
2025-12-08 15:50:35 -08:00
Benjamin Lu
26578981d4
Remove queue sidebar tab ( #6724 )
...
## Summary
- drop the queue sidebar entry, its component, and the supporting
composable so only the overlay-based queue UI remains
- clean up the related tests and keybindings so nothing references the
removed tab
- prune the unused queue task card components to keep the repo tidy
- remove unused queue sidebar translations and command strings across
all locales
## Testing
- pnpm typecheck
- pnpm lint:fix
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6724-Remove-queue-sidebar-tab-2ae6d73d3650811db0d4c5ad4c5ffc8d )
by [Unito](https://www.unito.io )
---------
Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: Jin Yi <jin12cc@gmail.com >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com >
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-11-19 19:50:24 -07:00
Alexander Brown
b264685052
lint: add tsconfig for browser_tests, fix existing violations ( #5633 )
...
## Summary
See https://typescript-eslint.io/blog/project-service/ for context.
Creates a browser_tests specific tsconfig so that they can be linted.
Does not add a package.json script to do the linting yet, but `pnpm exec
eslint browser_tests` should work for now.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5633-lint-add-tsconfig-for-browser_tests-fix-existing-violations-2726d73d3650819d8ef2c4b0abc31e14 )
by [Unito](https://www.unito.io )
2025-09-18 11:35:44 -07:00
Chenlei Hu
8db088b27a
Remove duplicated toolbuttons for workflow sidebar ( #3087 )
2025-03-16 20:18:24 -04:00
bymyself
842a9f74fc
[BrowserTest] Fix flaky gallery test ( #2150 )
2025-01-17 17:11:49 -05:00
Chenlei Hu
ea489851ed
[BugFix] Fix open workflow after insert ( #2138 )
2025-01-03 11:09:28 -05:00
bymyself
5c7cbe968e
Fix gallery changing image every time a task finishes ( #2125 )
2025-01-02 17:51:28 -05:00
bymyself
74b02237db
Add virtual scroll to Queue Tab for improved performance ( #2108 )
2024-12-31 12:35:29 -05:00
Chenlei Hu
618b451f1e
[test] Stricter locator matching on workflows sidebar elements ( #1905 )
...
* [test] Stricter locator matching on workflows sidebar elements
* nit
2024-12-13 14:13:56 -08:00
Chenlei Hu
6352cd86ee
Show confirm dialog on workflow path conflict (Save As) ( #1590 )
...
* Show confirm dialog on workflow path conflict (Save As)
* Fix closeworkflow
* nit
* Add playwright tests
* nit
* nit
* Move workflows dir cleanup
2024-11-18 23:07:24 -05:00
Chenlei Hu
73bdbddf90
Fix rename open/bookmark workflow ( #1507 )
...
* Fix rename open/bookmark workflow
* nit
* Fix save as
* Add browser test
2024-11-11 11:06:41 -05:00
Chenlei Hu
59c999324e
Split ComfyPage fixture ( #1305 )
...
* Split down page components
* Move litegraph utils
* nit
2024-10-25 08:29:02 -04:00
