Alexander Brown
18b133d22f
Style: Larger Node Text, More Sidebar Alignment ( #7223 )
...
## Summary
See what it looks like. How it feels. What do you think?
- Also was able to unify down to a single SearchBox component.
## Changes
- Bigger widget / slot labels
- Smaller header text
- Unified Searchboxes across sidebar tabs
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7223-Style-prototype-with-larger-node-text-2c36d73d365081f8a371c86f178fa1ff )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-11 19:47:28 -08:00
Luke Mino-Altherr
6850c45d63
[feat] Add ownership filter to model browser ( #7201 )
...
## Summary
Adds a dropdown filter to the model browser that allows users to filter
assets by ownership (All, My models, Public models), based on the
`is_immutable` property.
## Changes
- **Filter UI**: Added ownership dropdown in
[AssetFilterBar.vue](src/platform/assets/components/AssetFilterBar.vue#L30-L38)
that only appears when user has uploaded models
- **Filter Logic**: Implemented `filterByOwnership` function in
[useAssetBrowser.ts](src/platform/assets/composables/useAssetBrowser.ts#L38-L45)
to filter by `is_immutable` property
- **i18n**: Added translation strings for ownership filter options
- **Tests**: Added comprehensive tests for ownership filtering in both
composable and component test files
## Review Focus
- The ownership filter visibility logic correctly checks for mutable
assets (`!is_immutable`)
- Default filter value is 'all' to show all models initially
- Filter integrates cleanly with existing file format and base model
filters
🤖 Generated with [Claude Code](https://claude.com/claude-code )
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7201-feat-Add-ownership-filter-to-model-browser-2c16d73d365081f280f6d1e42e5400af )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
2025-12-09 13:52:33 -08:00
Alexander Brown
57523a0c57
Design: Model management ( #7190 )
...
## Summary
Assorted updates to the components involved in uploading personal
models.
## Changes
- Standardize Import buttons
- Let the images fill the space on the card
- Order by recent by default
- Nicer display on the model select popover
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7190-Design-Model-management-2c06d73d365081e7b9fed7a83b730c0f )
by [Unito](https://www.unito.io )
2025-12-05 15:53:28 -07:00
Christian Byrne
8120ed9dfa
load assets browser before fetch completes and show loading state ( #6189 )
...
## Summary
Moves the fetch and post-fetch logic associated with the asset browser
into the component and shows a loading state while fetching.
To test, use this branch:
https://github.com/comfyanonymous/ComfyUI/pull/10045
https://github.com/user-attachments/assets/718974d5-efc7-46a0-bcd6-e82596d4c389
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6189-load-assets-browser-before-fetch-completes-and-show-loading-state-2946d73d365081879d1bd05d86e8c036 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-23 13:43:34 -07:00
Arjan Singh
abf2b3b980
Full Asset Selection Experience (Assets API) ( #5900 )
...
## Summary
Full Integration of Asset Browsing and Selection when Assets API is
enabled.
## Changes
1. Replace Model Left Side Tab with experience
2. Configurable titles for the Asset Browser Modal
3. Refactors to simplify callback code
4. Refactor to make modal filters reactive (they change their values
based on assets displayed)
5. Add `browse()` mode with ability to create node directly from the
Asset Browser Modal (in `browse()` mode)
## Screenshots
Demo of many different types of Nodes getting configured by the Modal
https://github.com/user-attachments/assets/34f9c964-cdf2-4c5d-86a9-a8e7126a7de9
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5900-Feat-asset-selection-cloud-integration-2816d73d365081ccb4aeecdc14b0e5d3 )
by [Unito](https://www.unito.io )
2025-10-03 20:34:59 -07:00
Arjan Singh
13ce23399c
Asset Browser Design Review + Filters ( #5737 )
...
## Summary
Fixed design feedback and wired up the filter controls.
## Review Focus
Design Feedback:
-
[4872888](48728881af )
-
[9a0b63e](9a0b63edce )
Filters Hookup:
-
[07f22f8](07f22f8074 )
Misc (can focus less on):
- claude guidance:
[23e6fa9](23e6fa9723 )
- test helpers:
[7801ed9](7801ed9e28 )
## Screenshots (if applicable)
<img width="1534" height="1175" alt="Screenshot 2025-09-23 at 1 03
12 PM"
src="https://github.com/user-attachments/assets/d82088e4-7d72-4c6f-904e-5180774d64a5 "
/>
<img width="1794" height="793" alt="Screenshot 2025-09-23 at 1 03 22 PM"
src="https://github.com/user-attachments/assets/56eac2ba-5ecc-4a20-843f-ce683dea668c "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5737-Asset-Browser-Design-Review-Filters-2776d73d3650813e890bd16fa6a0433f )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: GitHub Action <action@github.com >
2025-09-25 11:17:26 -07:00
Arjan Singh
dfa1cbba4f
Asset Browser Modal Component ( #5607 )
...
* [ci] ignore playwright mcp directory
* [feat] add AssetBrowserModal
And all related sub components
* [feat] reactive filter functions
* [ci] clean up storybook config
* [feat] add sematic AssetCard
* [fix] i love lucide
* [fix] AssetCard layout issues
* [fix] add AssetBadge type
* [fix] simplify useAssetBrowser
* [fix] modal layout
* [fix] simplify useAssetBrowserDialog
* [fix] add tailwind back to storybook
* [fix] better reponsive layout
* [fix] missed i18n string
* [fix] missing i18n translations
* [fix] remove erroneous prevent on keyboard.space
* [feat] add asset metadata validation utilities
* [fix] remove erroneous test code
* [fix] remove forced min and max width on AssetCard
* [fix] import statement nits
2025-09-17 16:17:09 -07:00