2 Commits

Author	SHA1	Message	Date
Alexander Brown	82bacb82a7	test: add Playwright test tags for filtering (@smoke, @slow, @screenshot, domains) (#8441) ... ## Summary Adds structured test tags to all 54 Playwright test files to enable flexible test filtering during development and CI. ## Tags Added | Tag | Count | Purpose | |-----|-------|---------| | `@screenshot` | 32 files | Tests with visual assertions (`toHaveScreenshot`) | | `@smoke` | 5 files | Quick essential tests for fast validation | | `@slow` | 5 files | Long-running tests (templates, subgraph, featureFlags) | | `@canvas` | 15 files | Canvas/graph rendering tests | | `@node` | 10 files | Node behavior tests | | `@ui` | 8 files | UI component tests | | `@widget` | 5 files | Widget-specific tests | | `@workflow` | 3 files | Workflow operations | | `@subgraph` | 1 file | Subgraph functionality | | `@keyboard` | 2 files | Keyboard shortcuts | | `@settings` | 2 files | Settings/preferences | ## Usage Examples ```bash # Quick validation (~16 tests, ~30s) pnpm test:browser -- --grep @smoke # Skip slow tests for faster CI feedback pnpm test:browser -- --grep-invert @slow # Skip visual tests (useful for local development without snapshots) pnpm test:browser -- --grep-invert @screenshot # Run only canvas-related tests pnpm test:browser -- --grep @canvas # Combine filters pnpm test:browser -- --grep @smoke --grep-invert @screenshot ``` ## Implementation Details - Uses Playwright's native tag syntax: `test.describe('Name', { tag: '@tag' }, ...)` - Tags inherit from describe blocks to child tests - Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x` - Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }` ## Test Plan - [x] All existing tests pass unchanged - [x] Tag filtering works with `--grep` and `--grep-invert` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>	2026-01-29 16:34:56 -08:00
Christian Byrne	bbd8d67f5f	designate canvasOnly on runtime-generated virtual widgets so they are hidden in Vue renderer (#5831) ... ## Summary Added `canvasOnly` flag to runtime-generated widgets to prevent Vue renderer from displaying them while keeping canvas functionality intact. ## Changes - **What**: Added `canvasOnly` widget option to hide upload, webcam, and refresh widgets from Vue renderer In the Canvas (LiteGraph) system, there was a small set of widgets with strictly defined components. There, if we wanted some unique or relatively complex behavior (like an upload butotn), we needed to create a separate widget that would be coupled to the original widget at runtime (and would not be serialized). In the Vue renderer system, we can simply add flags to the inputSpec or widget options and conditionally render complex UI additions -- i.e., there is no need for the hard-to-maintain runtime widget associations. Expressing such things entirely in the view layer simplifies business logic related to graph state, as we no longer need to account for preserving the connections between runtime widgets and their special siblings -- we also do not need to worry about the implications for state serialization. ## Related - https://github.com/Comfy-Org/ComfyUI_frontend/pull/5798 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5831-designate-canvasOnly-on-runtime-generated-virtual-widgets-so-they-are-hidden-in-Vue-ren-27c6d73d365081fb8641feec010190df) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>	2025-09-28 18:48:29 -07:00