Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-04 23:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,977 Commits 580 Branches 534 Tags
ry-temp2
Commit Graph

58 Commits

Author SHA1 Message Date
Johnpaul Chiwetelu
7d2d006c07 Convert Group Nodes to Subgraph (#4972) 
* fix: Convert groupNodes to Subgraph Properly

* fix: Use correct positioning with requestAnimationFrame when groupnodes are converted to Subgraph
 2025-08-18 20:58:56 -07:00
Christian Byrne
4a3bd39650 [feat] Restore group node conversion menu with deprecated label (#4967) 
## Summary
- Partially reverts commit c84218d6 to restore group node functionality
in context menus
- Adds "(Deprecated)" label to indicate the feature is deprecated
- Fixes TypeError when right-clicking on group nodes
- Re-enables tests that were disabled when the feature was removed

## Changes
1. **Restored context menu options** - Added back "Convert to Group Node
(Deprecated)" and "Manage Group Nodes" menu items
2. **Fixed null reference error** - Added null-safe operator to prevent
errors when right-clicking group nodes
3. **Re-enabled tests** - Restored 7 tests that were disabled in commit
586f8824

## Test plan
- [x] Right-click on canvas → verify "Convert to Group Node
(Deprecated)" appears
- [x] Right-click on nodes → verify the same menu option appears
- [x] Select multiple nodes and use the menu option → verify conversion
works
- [x] Right-click on group nodes → verify no errors occur
- [x] Run browser tests → verify all re-enabled tests pass

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4967-feat-Restore-group-node-conversion-menu-with-deprecated-label-24e6d73d36508149a6f2dbef47223e94)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>
 2025-08-13 15:13:18 -07:00
Benjamin Lu
fef02e5f56 [refactor] Migrate litegraph imports from npm package to local subtree 
- Updated all imports from '@comfyorg/litegraph' to '@/lib/litegraph/src/'
- Replaced deep dist imports with direct source paths
- Updated CSS import in main.ts
- All imports now use the @ alias consistently
 2025-08-03 22:06:29 -04:00
guill
7eb3eb2473 Update the frontend to support async nodes. (#4382) 
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
 2025-07-23 13:46:00 +10:00
filtered
5c119fcbda Improve execution logic / Fix group node execution (#4422) 2025-07-11 00:40:48 -07:00
filtered
a7fb685290 Add Subgraphs (#3905) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-06-28 15:37:23 -07:00
filtered
7144ec54aa Fix UI crash when selecting broken node + TS fixes (#3859) 2025-05-12 17:57:59 +10:00
filtered
3aea2c120a Update widget types to match Litegraph changes (#3808) 2025-05-08 06:56:53 +10:00
filtered
b618ebe36d Change groupNode menu anchor to retain position (#3733) 2025-05-03 02:11:06 +10:00
Chenlei Hu
cfaf769a65 [TS] Properly type slot widget (#3305) 2025-04-01 15:13:46 -04:00
Chenlei Hu
7e76665a22 Revert "Migrate legacy reroute to litegraph native reroute (#3151)" (#3285) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-30 21:19:33 -04:00
Chenlei Hu
564c4d557f Migrate legacy reroute to litegraph native reroute (#3151) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-22 18:56:35 -04:00
Comfy Org PR Bot
e6e7449ece [chore] Update litegraph to 0.11.0-1 (#3190) 
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com>
 2025-03-23 03:49:44 +11:00
Chenlei Hu
a049e9ae2d [TS] Enable strict mode (#3136) 2025-03-18 22:57:17 -04:00
Chenlei Hu
7af003fcab [TS] Enable noUnusedParameters (#3110) 2025-03-17 16:47:45 -04:00
Chenlei Hu
7e66e99c3a [TS] Enable noUnusedLocals (#3108) 2025-03-17 16:20:56 -04:00
Chenlei Hu
15e396b4cc [Refactor] Remove app.getWidgetType (#2880) 2025-03-05 14:02:13 -05:00
Chenlei Hu
2d179ad632 [Refactor] Use node def v2 in registerNodeDef (#2856) 2025-03-04 12:07:13 -05:00
Chenlei Hu
09ab14ac81 [Type] Disallow type upcasting for node input spec (#2790) 2025-03-01 16:58:45 -05:00
Chenlei Hu
1d95d639e9 [Refactor] Extract nodeDefSchema from apiSchema (#2756) 2025-02-27 13:39:23 -05:00
Chenlei Hu
cdf42d5ad7 [Refactor] Move zod schemas to schemas/ folder (#2753) 2025-02-27 13:05:01 -05:00
Chenlei Hu
ab9c65f28b Type widgetInputs (#2741) 2025-02-26 18:01:56 -05:00
Chenlei Hu
064e982f01 Revert "[Refactor] Extract RerouteNode as a separate file" (#2678) 2025-02-21 22:57:19 -05:00
Chenlei Hu
85d04f6814 [Refactor] Extract RerouteNode as a separate file (#2668) 2025-02-21 15:04:47 -05:00
Chenlei Hu
acfb95f8d4 Use LGraphNode.setSize (#2555) 2025-02-14 11:02:56 -05:00
Chenlei Hu
8052b2a02a Type LGraphNode.getInnerNodes (#2498) 2025-02-10 16:35:26 -05:00
filtered
b8088ad782 Revert "Correct node/output titles when grouping nodes (#2359) (#2370)" (#2399) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-02 17:23:55 -05:00
Chenlei Hu
cbcbeab9d9 Correct node/output titles when grouping nodes (#2359) (#2370) 
Co-authored-by: Anastasiy Safari <anastasiuspernat@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
 2025-01-29 11:05:48 -08:00
Chenlei Hu
174a9a114a Expose dialogService to extensionManager (#2113) 2024-12-31 17:01:37 -05:00
Chenlei Hu
d8f074fea0 [Lint] Sort imports (#2104) 2024-12-30 17:26:37 -05:00
Chenlei Hu
66ada54587 [Refactor] Move vintageClipboard to utils/ (#2062) 2024-12-26 12:55:58 -05:00
Chenlei Hu
f69e88bf41 [Refactor] Convert dialogService to composable (#2058) 2024-12-26 00:26:01 -05:00
filtered
7f60811ebf Fix cannot open groupNodes menu from canvas (#1925) 
* Fix cannot open groupNode menu from canvas

* Fix cannot open groupNode menu from canvas

Fixes root cause of issue

* Update locales [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-12-17 09:47:09 -08:00
Chenlei Hu
aa04ab78c1 Replace window.prompt with custom prompt impl (#1847) 
* Replace window.prompt with custom prompt impl

* Update locales [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-12-08 16:55:32 -05:00
pythongosssss
5c6eecd660 Fix group node manage opening to wrong node type (#1754) 
Remove dialog from DOM when closed
Add test
 2024-12-01 19:52:08 -05:00
filtered
2017b9016b Add TS types - API (#1736) 
* nit

* Add TS types - API events

* Replace all API event emits with type-safe variants

* Add missing API type

* nit

* Remove test code, nit
 2024-11-29 13:15:25 -05:00
filtered
dde0291add Fix change tracker count desync on error (#1555) 
* Add TS types

* Ensure changeTracker works after exceptions

Wraps all code between before/after change calls in try/finally blocks
 2024-11-15 16:03:21 -05:00
filtered
82d00a1bcf Update Template copy & paste (#1533) 
* Split original clipboard functions out

* Add version check for templates

* Fix regression in use template undo steps
 2024-11-13 17:04:31 -05:00
filtered
d6e0c197bd Decouple group node from Litegraph copy & paste (#1522) 
* nit - Refactor

* Add old clipboard code to groupNode

* [Refactor] groupNode copy / paste functions

* Clarify function name
 2024-11-12 23:11:04 -05:00
Chenlei Hu
5611e90fda Add ts-strict-ignore plugin (#1235) 
* Add ts-strict-ignore plugin

* nit

* Add to typecheck script
 2024-10-12 11:56:49 -04:00
Chenlei Hu
ec8e6f79b3 Fix create group node command error states (#1209) 
* Fix edge cases

* Add playwright test

* nit
 2024-10-10 15:56:00 -04:00
Chenlei Hu
b89f467983 Add group node commands/keybindings (#1208) 
* Add group node commands/keybindings

* Fix jest tests
 2024-10-10 12:50:05 -04:00
Chenlei Hu
dee1ec1a2a Update Litegraph (TypeScript conversion) (#1145) 
* Fix various type errors

* Fix rest of ts errors

* update litegraph

* nit
 2024-10-07 11:31:54 -04:00
Chenlei Hu
4cc69544b5 Replace window.alert with toast alert (#1112) 
* Replace window.alert with toast alert

* Mock jest
 2024-10-04 22:00:44 -04:00
bymyself
a737be7e16 Fix group node copy paste (#1069) 
* Fix group node copy paste

* nit

---------

Co-authored-by: huchenlei <huchenlei@proton.me>
 2024-10-02 15:51:33 -04:00
bymyself
84fc0e9205 Fix group node naming compatibility (#969) 
* Convery legacy group node names in workflow

* Add Playwright test

* Remove hardcoded strings
 2024-09-25 15:25:08 +09:00
bymyself
6b9c1b70ba Fix group node bookmarking (#950) 
* Resolves #926 group node bookmark

* Remove expect outside scope of test

* Update unit tests

* Update group node manager path separators

* Update group node path sepator in fixture
 2024-09-24 16:26:02 +09:00
pythongosssss
223a1f677b Fix links being lost after manage group node (#916) 
* Fix links being lost after manage group node

* Change to use groupnodebuilder

* Make test more reliable
 2024-09-22 16:17:39 +09:00
bymyself
e8daebdc0c Add group nodes to search and node library (#861) 
* Register group nodes in nodeDefStore

* Add playwright tests

* Update test expectations [skip ci]

* Mock nodeDefStore in group node unit test

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-09-17 16:06:58 +09:00
Chenlei Hu
12c699cc87 Update litegraph (Getters) (#829) 
* Update litegraph (Getters)

* Update
 2024-09-14 17:10:57 +09:00