Alexander Brown
1b83d6b5a6
Migration: pnpm ( #5215 )
...
* migration: npm to pnpm
Step 1, package and lockfile
* migration: npm to pnpm
Step 2: docs / LLM instructions
* migration: npm to pnpm
Step 3: More documentation updates
* migration: npm to pnpm
Step 4: Even more documentation
* migration: npm to pnpm
Step 5: GitHub Actions
* migration: npm to pnpm
Step 6: PNPM installation in actions. This merge is going to be painful.
* migration: npm to pnpm
Unignore and add pnpm lockfile.
* migration: npm to pnpm
package-lock.json -> pnpm-lock.yaml
* migration: explicit @primeuix/styled, move glob to prod deps
* migration: more explicit deps required by the importmap plugin and vite
* fix: missed merge artifact
* fix: Make sure pnpm is available to install wrangler
* migration: pnpm for dev-release.yaml
* migration: new setup action version
Won't work until that is updated and a new release is cut.
* migration: Playwright needs uuid
* migration: Add explicit deps for lobehub
* chore(version-bump.yaml): change cache from npm to pnpm to optimize package management and improve build performance
* migration: install pnpm in version-bump action
---------
Co-authored-by: snomiao <snomiao@gmail.com >
2025-08-27 06:10:15 -07:00
snomiao
62e06f4358
[ci] Enhance CI/CD caching across all workflows ( #5117 )
...
* [ci] Enhance CI/CD caching across all workflows
- Add tool cache steps for node_modules/.cache, .cache, and .eslintcache
- Enable npm caching for Node.js setup actions where missing
- Add cache configurations for ESLint, Prettier, Knip, and other build tools
- Improve build performance by caching tool outputs between runs
- Use unique cache keys per workflow to avoid conflicts
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* [ci] Enhance CI/CD caching with comprehensive improvements
Extends caching strategy beyond PR #5107 with additional optimizations:
- **i18n.yaml**: Add tool cache for locale generation workflow
- **update-electron-types.yaml**: Add tool cache for type updates
- **test-ui.yaml**: Add Playwright browser cache and Python pip cache
- **vitest.yaml**: Add coverage directory caching
- **chromatic.yaml**: Add Storybook static build cache
- **All build workflows**: Add TypeScript incremental build cache
- **Type generation workflows**: Add repository caching for external repos
- **lint-and-format.yaml**: Improve cache key granularity with source hash
Performance improvements:
- Playwright browser downloads cached across runs
- Python pip dependencies cached
- TSC incremental compilation cache preserved
- Storybook static builds cached
- External repository clones cached
- More granular cache invalidation based on source changes
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* [ci] Optimize CI/CD caching for better performance
- Enhance cache keys with more specific file patterns for better cache hit rates
- Add missing cache directories (.prettierCache, .knip-cache, .vitest-cache, tsconfig.tsbuildinfo)
- Improve cache key naming for clarity (lint-format, vitest, storybook, playwright)
- Add better fallback cache restore keys
- Include browser-specific caching for Playwright tests
- Add TypeScript build info caching across workflows
Expected improvements:
- 20-40% faster builds on cache hits
- More granular cache invalidation
- Better cache utilization across tools
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Apply suggestion from @DrJKL
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* [ci] Remove redundant node_modules/.cache from workflow caches
setup-node already handles node_modules caching when cache: 'npm' is enabled.
Removed conflicting node_modules/.cache entries from:
- .github/workflows/lint-and-format.yaml
- .github/workflows/vitest.yaml
- .github/workflows/test-ui.yaml
This prevents cache conflicts and follows best practices for npm caching.
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* Update .github/workflows/chromatic.yaml
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* Update .github/workflows/update-electron-types.yaml
Co-authored-by: Alexander Brown <drjkl@comfy.org >
* fix: address reviewer feedback on cache optimization PR (#5200 )
* fix: remove duplicate cache entries and fix YAML formatting
- Remove duplicate path entries in dev-release.yaml
- Remove redundant node_modules/.cache entries since setup-node handles npm caching
- Fix YAML indentation issues across workflow files
Addresses reviewer feedback on PR #5117 about duplication and maintenance
* fix: add cache-dependency-path for setup-node in test-ui workflow
The test-ui workflow runs at repo root but package-lock.json is in ComfyUI_frontend/
subdirectory, causing setup-node cache to fail. Added cache-dependency-path to fix this.
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2025-08-26 12:26:17 -07:00
