DrJKL
0dfe36f1f8
style: Align card styles with Designs
2025-12-01 11:48:08 -08:00
Alexander Brown
8b5cfe7e55
Lint: Adding more checks for non internationalized strings ( #5625 )
...
## Summary
Catch more user visible (or audible) text that isn't
internationalizable.
## Changes
- **What**: Linter now checks other attributes for raw text.
## Review Focus
What other properties have leaked English text to non-English locales
that aren't in here?
2025-11-24 21:55:47 -08:00
Alexander Brown
471ccca1dd
Style: Design System use across more components ( #6705 )
...
## Summary
Only remaining use is in `buttonTypes.ts` which @viva-jinyi is going to
be working on to consolidate our different buttons soon.
## Changes
- **What**: Replace light/dark colors with theme aware design system
tokens.
## Review Focus
Double check the chosen colors for the components
## Screenshots
| Before | After |
| ------ | ----- |
| <img width="607" height="432" alt="image"
src="https://github.com/user-attachments/assets/6c0ee6d6-819f-40b1-b775-f8b25dd18104 "
/> | <img width="646" height="488" alt="image"
src="https://github.com/user-attachments/assets/9c8532de-8ac6-4b48-9021-3fd0b3e0bc63 "
/> |
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6705-Style-WIP-Design-System-use-across-more-components-2ab6d73d365081619115fc5f87a46341 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-11-17 12:27:10 -08:00
Alexander Brown
b03cf7e11d
Style: Token renaming and style organization ( #6337 )
...
## Summary
Align color names and organize style.css some more
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6337-Style-Token-renaming-and-style-organization-29a6d73d365081b69f25ce1298c67fdc )
by [Unito](https://www.unito.io )
2025-10-28 12:13:28 -07:00
Christian Byrne
8120ed9dfa
load assets browser before fetch completes and show loading state ( #6189 )
...
## Summary
Moves the fetch and post-fetch logic associated with the asset browser
into the component and shows a loading state while fetching.
To test, use this branch:
https://github.com/comfyanonymous/ComfyUI/pull/10045
https://github.com/user-attachments/assets/718974d5-efc7-46a0-bcd6-e82596d4c389
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6189-load-assets-browser-before-fetch-completes-and-show-loading-state-2946d73d365081879d1bd05d86e8c036 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-23 13:43:34 -07:00
Alexander Brown
b943c0fa75
Lint: Add tailwind linter ( #5984 )
...
## Summary
Adds the [tailwind lint
plugin](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#eslint-plugin-tailwindcss )
and fixes the currently fixable rules ([v4 is still in
beta](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#about-tailwind-css-4-support )).
## Changes
- **What**: Enforces things like consistent class order, and eventually
can prohibit extra classes that could be utilities instead
- **Dependencies**: The plugin and its types
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5984-Lint-Add-tailwind-linter-2866d73d365081d89db0d998232533bb )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-08 19:39:14 -07:00
Alexander Brown
99b3a59679
Style: Standardize icon use Part 1 ( #5947 )
...
## Summary
Remove the mix of class based and component style icons in favor of just
[classes](https://iconify.design/docs/usage/css/tailwind/tailwind4/#basic-usage ).
## Changes
- **What**: Migrate existing lucide icons
## Review Focus
What differs between the icons before and now?
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5947-Style-Standardize-icon-use-Part-1-2846d73d365081bfa66ceb6bdaa9ff02 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-10-07 17:53:38 -07:00
Arjan Singh
dfa1cbba4f
Asset Browser Modal Component ( #5607 )
...
* [ci] ignore playwright mcp directory
* [feat] add AssetBrowserModal
And all related sub components
* [feat] reactive filter functions
* [ci] clean up storybook config
* [feat] add sematic AssetCard
* [fix] i love lucide
* [fix] AssetCard layout issues
* [fix] add AssetBadge type
* [fix] simplify useAssetBrowser
* [fix] modal layout
* [fix] simplify useAssetBrowserDialog
* [fix] add tailwind back to storybook
* [fix] better reponsive layout
* [fix] missed i18n string
* [fix] missing i18n translations
* [fix] remove erroneous prevent on keyboard.space
* [feat] add asset metadata validation utilities
* [fix] remove erroneous test code
* [fix] remove forced min and max width on AssetCard
* [fix] import statement nits
2025-09-17 16:17:09 -07:00
