snomiao
0f44b5ea58
[fix] Change keyboard event handling from event.key to event.code
...
This fixes keyboard shortcuts not working on non-English (non-Latin) keyboard layouts.
Changes:
- KeyComboImpl.fromEvent() now uses event.code instead of event.key
- Updated isModifier check to use key codes for modifier keys
- Added getDisplayKey() method to convert key codes to readable names
- Updated Escape key handling in keybindingService to use event.code
- Updated KeybindingPanel captureKeybinding to use event.code
- Migrated all core keybindings from event.key to event.code format
- Fixed tests to mock event.code instead of event.key
Fixes #5252
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-10-01 03:23:05 +00:00
Alexander Brown
08220d50d9
Lint: Turn on rules that should allow for verbatimModuleSyntax ( #5616 )
...
* lint: turn on type import rules setting up for verbatimModuleSyntax
* lint: --fix for type imports
2025-09-16 22:03:41 -07:00
Christian Byrne
c42c9315f4
[refactor] Replace lodash with es-toolkit ( #4935 )
2025-08-12 12:22:09 -07:00
Benjamin Lu
c8b8953e0a
Add reset individual keybind button ( #3423 )
...
Co-authored-by: Benjamin Lu <templu1107@proton.me >
2025-04-12 16:59:00 -04:00
Benjamin Lu
009c389607
Rename reset keybindings to reset all keybindings ( #3411 )
...
Co-authored-by: Benjamin Lu <templu1107@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2025-04-11 20:01:28 -04:00
Benjamin Lu
1990f25638
Allow keybind overwriting ( #3393 )
...
Co-authored-by: Benjamin Lu <templu1107@proton.me >
2025-04-11 14:28:36 -04:00
Chenlei Hu
cdf42d5ad7
[Refactor] Move zod schemas to schemas/ folder ( #2753 )
2025-02-27 13:05:01 -05:00
bymyself
46f0733ae7
Ignore reserved keybindings when typing in text input ( #2514 )
...
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
2025-02-12 11:15:19 -05:00
Chenlei Hu
ea6c9e7ca5
Replace unset unknown keybinding error with warn ( #2186 )
2025-01-07 10:33:23 -05:00
Chenlei Hu
077ded2cce
[Refactor] Simplify keybindingStore with _.groupBy ( #2180 )
2025-01-06 19:46:20 -05:00
bymyself
e123295423
Fix saved keybinding persistence ( #2176 )
2025-01-06 15:54:35 -05:00
Chenlei Hu
975c2248c5
Rename Keybinding.targetSelector to targetElementId ( #2169 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-01-05 16:03:38 -05:00
Chenlei Hu
d8f074fea0
[Lint] Sort imports ( #2104 )
2024-12-30 17:26:37 -05:00
Chenlei Hu
95a4623c37
Re-enable keybinding jest test ( #2090 )
2024-12-29 14:55:18 -05:00
filtered
0fe0aea242
Fix keybinds invalidated by capslock state ( #1776 )
...
* [Refactor] Simplify keybinds code
* [Refactor] Type safety
* Fix capslock inverts undo/redo shortcuts
* [Refactor] Type safety
* Fix capslock state changes keybinds
* Deprecate keybind deserialize
* Remove keybind deserialize
2024-12-03 19:12:09 -05:00
Chenlei Hu
27b0493306
Move files to constants/ ( #1650 )
2024-11-22 21:55:44 -05:00
Chenlei Hu
886c40a69a
Fix keybinding conflict ( #1630 )
2024-11-21 11:49:57 -05:00
Chenlei Hu
4f3693e322
Reland 'Bind Ctrl+s to Comfy.SaveWorkflow' ( #1618 )
2024-11-20 15:01:04 -05:00
Chenlei Hu
cc17bee945
Manage app.ts litegraph keybindings ( #1151 )
...
* Manage app.ts litegraph keybindings
* nit
2024-10-07 16:50:58 -04:00
Chenlei Hu
1775d43d90
Support keybinding customization ( #1081 )
...
* Basic keybinding panel
nit
Make row selectable
Reduce padding
Better key seq render
Show actions on demand
Turn off autocomplete
nit
Persist keybindings
Autofocus
Fix set unsetted keybinding bug
Refactor
Add reset button
Add back default keybinding logic
Report key conflict error
Adjust style
fix bug
Highlight modified keybindings
* Set current editing command's id as dialog header
2024-10-03 16:58:56 -04:00
Chenlei Hu
142882a8ff
Move keybinds to coreKeybindings ( #1078 )
...
* Refactor core keybinds
* Prevent default
* Add playwright test
2024-10-03 11:25:53 -04:00
Chenlei Hu
77aaa38a92
[Extension API] Custom commands and keybindings ( #1075 )
...
* Add keybinding schema
* nit
* Keybinding store
* nit
* wip
* Bind condition on ComfyCommand
* Add settings
* nit
* Revamp keybinding store
* Add tests
* Add load keybinding
* load extension keybindings
* Load extension commands
* Handle keybindings
* test
* Keybinding playwright test
* Update README
* nit
* Remove log
* Remove system stats fromt logging.ts
2024-10-02 21:38:04 -04:00
