Christian Byrne
3a73ce72bb
refactor: replace inline getByRole('dialog') with page objects in E2E tests ( #10724 )
...
## Summary
Replace remaining inline `getByRole('dialog')` calls in E2E tests with
page object accessors, following the pattern from PR #10586 .
**Note:** The original scope covered 9 calls across 5 files. Three of
those refactors (ConfirmDialog, MediaLightbox, TemplatesDialog) were
already merged into main via other PRs, so this PR now covers only the
remaining 3 files.
## Changes
- **ComfyNodeSearchBox.ts**: Extract a `root` locator on
`ComfyNodeSearchFilterSelectionPanel` so `header` getter uses
`this.root` instead of an inline `page.getByRole('dialog')`
- **AppModeHelper.ts**: Add `imagePickerPopover` getter that locates the
PrimeVue Popover (`role="dialog"`) filtered by a button named "All"
- **appModeDropdownClipping.spec.ts**: Replace 4-line inline
`getByRole('dialog')` chain with `comfyPage.appMode.imagePickerPopover`
## Review Focus
Pure test infrastructure refactor — no production code changes. Each
page object follows existing conventions.
Fixes #10723
2026-04-06 16:42:09 -07:00
pythongosssss
54a00aac75
test/refactor: App mode - Refactor & Save As tests ( #10680 )
...
## Summary
Adds e2e Save As tests for #10679 .
Refactors tests to remove getByX and other locators in tests to instead
be in fixtures.
## Changes
- **What**:
- extract app mode fixtures
- add test ids where required
- add new tests
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10680-test-refactor-App-mode-Refactor-Save-As-tests-3316d73d3650815b9d49ccfbb6d54416 )
by [Unito](https://www.unito.io )
2026-03-28 15:02:23 -07:00
pythongosssss
7864e780e7
feat: App mode - Rework save flow ( #10439 )
...
## Summary
Users were finding the final step of the builder flow
confusing/misleading, with the "choose default mode" not actually saving
the workflow and people losing changes. This updates it to remove
"save"/"set default" as a step in the builder, and changes it to a
distinct action.
## Changes
- **What**:
- add mode selection tab on footer toolbar
- extract reusable radio group component
- remove setting default mode dialog
- add save/save as/saved dialogs
## Screenshots (if applicable)
https://github.com/user-attachments/assets/c7439c2e-a917-4f2b-b176-f8bb8c10026d
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10439-feat-App-mode-Rework-save-flow-32d6d73d3650814781b6c7bbea685a97 )
by [Unito](https://www.unito.io )
2026-03-27 12:53:09 -07:00
pythongosssss
c90a5402b4
feat: App mode - double click to rename widget ( #10341 )
...
## Summary
Allows users to rename widgets by double clicking the label
## Changes
- **What**: Uses EditableText component to allow inline renaming
## Screenshots (if applicable)
https://github.com/user-attachments/assets/f5cbb908-14cf-4dfa-8eb2-1024284effef
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10341-feat-App-mode-double-click-to-rename-widget-3296d73d36508146bbccf8c29f56dc96 )
by [Unito](https://www.unito.io )
2026-03-20 14:35:09 -07:00
pythongosssss
7501a3eefc
fix: App mode - Widget dropdowns clipped in sidebar ( #10338 )
...
## Summary
Popover components for graph mode are appendTo self so scale/translate
works, however in the sidebar this causes them to be clipped by the
parent overflow. This adds a provide/inject flag to change these to be
appended to the body.
## Changes
- **What**:
- add append to injection for overriding where popovers are mounted
- ensure dropdowns respect this flag
- extract enterAppModeWithInputs helper
- tests
Before:
<img width="225" height="140" alt="image"
src="https://github.com/user-attachments/assets/bd83b0cd-49a9-45dd-8344-4c10221444fc "
/>
After:
<img width="238" height="225" alt="image"
src="https://github.com/user-attachments/assets/286e28e9-b37d-4ffc-91a9-7c340757d3fc "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10338-fix-App-mode-Widget-dropdowns-clipped-in-sidebar-3296d73d365081e2ba38e3e82006d65e )
by [Unito](https://www.unito.io )
2026-03-20 14:18:54 -07:00
pythongosssss
77ddda9d3c
fix: App mode - renaming widgets on subgraphs ( #10245 )
...
## Summary
Fixes renaming of widgets from subgraph nodes in app builder/app mode.
## Changes
- **What**: If the widget is from a subgraph node and no parents passed,
use the node as the subgraph parent.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10245-fix-App-mode-renaming-widgets-on-subgraphs-3276d73d3650815bb131c840df43cdf2 )
by [Unito](https://www.unito.io )
2026-03-19 04:00:31 -07:00
