Terry Jia
25b9c51237
fix: correct Vue node selection box detection accuracy ( #7741 )
...
## Summary
Remove double-counting of NODE_TITLE_HEIGHT in layout sync. The title
height was being added both in useLayoutSync and in LiteGraph's
measure() function, causing boundingRect to be 30px taller than actual
DOM.
This caused selection box to detect nodes ~30px below their actual
bottom.
fix https://github.com/Comfy-Org/ComfyUI_frontend/issues/7580
## Screenshots (if applicable)
before
https://github.com/user-attachments/assets/babf0b9d-174e-4ec3-a3bb-18e4f9d88d09
after
https://github.com/user-attachments/assets/4f9989a5-4d3c-4303-bd1b-70ca70cb8f15
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7741-fix-correct-Vue-node-selection-box-detection-accuracy-2d26d73d3650817cbe80f98a3bf1abf1 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-23 17:36:06 -05:00
Alexander Brown
6244cf1008
Tests: Golden Updates ( #7624 )
...
## Summary
...
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7624-Tests-Golden-Updates-2cd6d73d3650812eb92ece7c78d29c1b )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-18 15:01:01 -08:00
AustinMroz
b22ba97a13
Support "control after generate" in vue ( #6985 )
...
Continuation of #6034 with
- Updated synchronization for seed
- Properly truncates the displayed widget value for the button
- Synchronizes control after generate state with litegraph and allows
for serialization
Several issues from original PR have not (yet) been addressed, but are
likely better moved to future PR
- fix step value being 10 (legacy system)
- ensure it works with COMBO (Fixed in #7095 )
- ensure it works with FLOAT (Fixed in #7095 )
- either implement or remove the config button functionality - think it
should open settings?
<img width="280" height="694" alt="image"
src="https://github.com/user-attachments/assets/f36f1cb0-237d-4bfc-bff1-e4976775cf98 "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6985-Support-control-after-generate-in-vue-2b86d73d365081d8b01ce489d887ff00 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: bymyself <cbyrne@comfy.org >
Co-authored-by: github-actions <github-actions@github.com >
2025-12-13 05:23:56 -07:00
Alexander Brown
18b133d22f
Style: Larger Node Text, More Sidebar Alignment ( #7223 )
...
## Summary
See what it looks like. How it feels. What do you think?
- Also was able to unify down to a single SearchBox component.
## Changes
- Bigger widget / slot labels
- Smaller header text
- Unified Searchboxes across sidebar tabs
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7223-Style-prototype-with-larger-node-text-2c36d73d365081f8a371c86f178fa1ff )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-11 19:47:28 -08:00
Alexander Brown
03e9dd4789
Feat: Remove the Nodes 2.0 Trial Banner ( #7390 )
...
## Summary
The option to try it out is still in the Menu if you're looking for it.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7390-Feat-Remove-the-Nodes-2-0-Trial-Banner-2c66d73d365081c3817ad5c89dd4029b )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-11 17:13:26 -08:00
Johnpaul Chiwetelu
ac8c3847d2
chore: fix playwright expectations ( #7395 )
...
## Summary
<!-- One sentence describing what changed and why. -->
## Changes
- **What**: <!-- Core functionality added/modified -->
- **Breaking**: <!-- Any breaking changes (if none, remove this line)
-->
- **Dependencies**: <!-- New dependencies (if none, remove this line)
-->
## Review Focus
<!-- Critical design decisions or edge cases that need attention -->
<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->
## Screenshots (if applicable)
<!-- Add screenshots or video recording to help explain your changes -->
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7395-chore-fix-playwright-expectations-2c66d73d3650819d8913d80be55d7908 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-12 01:14:24 +01:00
Johnpaul Chiwetelu
7c830a2f0b
feat: bring node to front when clicking on any widget ( #7202 )
...
## Summary
- Adds a capture-phase pointerdown handler to NodeWidgets that calls
`bringNodeToFront` whenever any widget is clicked
- Improves UX by ensuring the interacted node is always visible on top,
without requiring the node itself to be selected
fix https://github.com/Comfy-Org/ComfyUI_frontend/issues/7131
## Before
https://github.com/user-attachments/assets/c2c2ff0e-6e5a-49f2-bf2e-333950559ada
## After
https://github.com/user-attachments/assets/fc3db735-20eb-40b5-9101-278badc4698e
## Test plan
- [ ] Click on any widget (button, dropdown, input, etc.) within a Vue
node
- [ ] Verify the node moves to the front (highest z-index) when the
widget is clicked
- [ ] Verify existing widget functionality is unaffected
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-12-12 00:15:09 +01:00
