Chenlei Hu
c54b675a48
Revert Filter cached/canceled results ( #1586 ) ( #1703 )
...
* Revert "Filter cached/canceled results (#1586 )"
This reverts commit 6fbf1248f4 .
* nit
2024-11-26 13:17:26 -05:00
Chenlei Hu
4a182014e1
Revert "Fix queue sidebar tab task filter ( #1682 )" ( #1700 )
...
This reverts commit c1c5573e7f .
2024-11-26 13:08:19 -05:00
Hayden
c977667a15
Change dialog to multi-window mode ( #1695 )
...
Fixed Dropdown's z-index being below the dialog
2024-11-26 10:11:15 -05:00
Chenlei Hu
51f57aba17
Revert "Change dialog to multi-window mode ( #1672 )" ( #1686 )
...
This reverts commit 43c23e526c .
2024-11-25 13:29:47 -05:00
Chenlei Hu
c1c5573e7f
Fix queue sidebar tab task filter ( #1682 )
...
* Fix queue sidebar tab task filter
* nit
2024-11-25 12:59:10 -05:00
Hayden
43c23e526c
Change dialog to multi-window mode ( #1672 )
2024-11-24 21:36:30 -05:00
Chenlei Hu
e01c8f06c7
[Electron] Show server launch args in server config panel ( #1669 )
...
* Move revertChanges
* Show launch args
* Explicit ServerConfigValue type
* nit
* nit
* Add tests
2024-11-24 18:14:05 -05:00
Chenlei Hu
c61ed4da37
Add server config modified message to prompt restart ( #1668 )
...
* Server config changed message
* Write to settings on unmount
* nit
* Highlight modified config
* Move modified logic to store
* Add jest test
* nit
2024-11-24 16:13:37 -05:00
filtered
abed0656af
Add Fit Group to Contents keybind ( #1658 )
...
* Add Fit Group to Nodes keyboard command
Fits all selected groups.
* nit - Rename
* Move to commandStore & Playwright test
* nit
* nit
* Update test expectations [skip ci]
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2024-11-23 17:15:52 -05:00
Chenlei Hu
27b0493306
Move files to constants/ ( #1650 )
2024-11-22 21:55:44 -05:00
Chenlei Hu
4007cc13c2
[Electron] ComfyUI server config (Launch args config) ( #1644 )
...
* Remove electron adapter server args
* Add server args typing
* Add server config constant file
* Tooltip to name; name to id
* Capitalize category
* Server config store
* Prevent default value
* Add serverconfig test
* Guard server config panel with electron flag
* Filter nullish values from server args
* Use slider for preview size
2024-11-22 16:50:24 -05:00
Chenlei Hu
3920210c5c
Remove Ctrl+D keybinding ( #1643 )
2024-11-22 11:17:36 -05:00
Chenlei Hu
886c40a69a
Fix keybinding conflict ( #1630 )
2024-11-21 11:49:57 -05:00
Chenlei Hu
5d178a407d
[chore] Update comfyui-electron-types ( #1625 )
...
* Remove electron external dep
* [chore] Update comfyui-electron-types
2024-11-21 00:07:50 -05:00
oto-ciulis-tt
94f5031f0d
feat: Update Electron Download types ( #1621 )
...
* feat: Update Electron Download types
* Fix vite rollup
---------
Co-authored-by: Oto Ciulis <oto.ciulis@gmail.com >
Co-authored-by: huchenlei <huchenlei@proton.me >
2024-11-20 20:34:27 -05:00
Chenlei Hu
4f3693e322
Reland 'Bind Ctrl+s to Comfy.SaveWorkflow' ( #1618 )
2024-11-20 15:01:04 -05:00
Chenlei Hu
77b85acdd5
Revert "Bind Ctrl+s to Comfy.SaveWorkflow ( #1599 )" ( #1614 )
...
This reverts commit 0058691579 .
2024-11-20 09:27:01 -05:00
Chenlei Hu
0058691579
Bind Ctrl+s to Comfy.SaveWorkflow ( #1599 )
2024-11-18 23:07:11 -05:00
pythongosssss
6fbf1248f4
Filter cached/canceled results ( #1586 )
...
* Filter cached/canceled results
* Highlight if on
* Update setting
2024-11-18 16:59:59 -05:00
pythongosssss
56848724cd
Fix id ( #1589 )
2024-11-18 16:59:36 -05:00
filtered
7e245ba1cf
Update Litegraph: Canvas Pointer ( #1556 )
...
* Litegraph: canvas.pointer
Clear @ts-expect-error
Fix exception thrown on slot double-click
Long-standing bug but has no real impact in prod - just logs an error.
Required for new connecting_link features.
Add settings: CanvasPointer options
Update litegraph 0.8.28
Fix regression in snap to grid render
Fix snap to grid marker always on
Update snap to grid to use Positionable API
Fix test clicks registering as double-click
Improve test precision
Current test proves it has changed to something smaller.
New test proves it is exactly what was specified.
Will need refinement when a limit is put on latent width.
Fix test expects collapse node to select node
Remove redundant code
Resolved by CanvasPointer
Fix flaky test - ContextMenu
Fix settings group
* Update litegraph
* Remove snapToGrid extension
* Update test expectations [skip ci]
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2024-11-18 10:50:51 -05:00
pythongosssss
b5f0c4bf73
[Electron] Terminal commands ( #1531 )
...
* Add live terminal output
* Fix scrolling
* Refactor loading
* Fallback to polling if endpoint fails
* Comment
* Move clientId to executionStore
Refactor types
* Remove polling
* wip terminal command input
* Refactor to use node-pty
* Hide tabs if not electron
* Lint fix
* ts fix
* Refactor tab components
2024-11-17 14:43:08 -05:00
Chenlei Hu
71e4a42cfe
Only persist workflow on workflow change/switch ( #1576 )
...
* Only persist workflow on workflow change/switch
* nit
* Add playwright test
* Add modify test
* nit
* Fix playwright tests
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-11-17 14:13:52 -05:00
Chenlei Hu
16b0ebf75a
Remove deprecated setting Comfy.NodeSearchBoxImpl.LinkReleaseTrigger ( #1574 )
2024-11-17 12:10:44 -05:00
Chenlei Hu
eaeb17bdc7
Add new top level setting category 'LiteGraph' and 'Appearance' ( #1573 )
2024-11-17 12:06:07 -05:00
filtered
b922aa5c7c
Add option to disable ctrl + shift + zoom ( #1545 )
...
* Add option to disable ctrl + shift + zoom
Minor change to default behaviour: zoom no longer triggers if alt key is also down.
* Update coreSettings.ts
Next release will be 1.4.0 to leave room for patches in 1.3 stable after today's main repo sync.
---------
Co-authored-by: Chenlei Hu <huchenlei@proton.me >
2024-11-15 09:10:09 -05:00
Chenlei Hu
acba6097e0
Replace electron API mocks with actual electron API impl ( #1535 )
...
* link electron types locally
* Update electronAPI calls
* Fix source validation
* Payload to raw
* nit
* Update electron types
2024-11-13 17:20:18 -05:00
filtered
7e0d1d441d
Flaky tests and observable state ( #1526 )
...
* Fix missing await
* Fix flaky tests - keyboard combos
Old code is causing playwright &/ changeTracker to add an undo step. Using combo mode resolves flakiness until that can be investigated thoroughly.
* Restore skipped tests
* Fix flaky tests
* Async clean up
* Fix test always fails on retry
* Add TS types (tests)
* Fix flaky test
* Add observable busy state to workflow store
* Add workflow store busy wait to tests
* Rename test for clarity
* Fix flaky tests - use press() from locator API
Ref: https://playwright.dev/docs/api/class-keyboard#keyboard-press
* Fix flaky test - wait next frame
* Add delay between mouse events
Litegraph pointer handling is all custom coded, so a adding a delay between events for a bit of reality is actually beneficial.
2024-11-13 09:35:22 -05:00
oto-ciulis-tt
e3d2c3a814
feat: Add download progress to sidebar ( #1490 )
...
* feat: Add download progress to sidebar
* Removing console log
* Lint fixes
* Updating UI
* Fixing lint error
* Fixing lint error
* Fixing lint error
* PR comments
* Reverting change
---------
Co-authored-by: Oto Ciulis <oto.ciulis@gmail.com >
2024-11-12 16:28:55 -05:00
Chenlei Hu
4bc79181ae
Move DOMClippingEnabled to coreSettings.ts ( #1516 )
...
* Move DOMClippingEnabled to coreSettings.ts
* nit
2024-11-12 12:01:44 -05:00
filtered
feafbf9cbf
Litegraph Reroute Beta ( #1421 )
...
* Add Reroute support - ConnectingLinkImpl
Bonus: TS strict
* Add Reroute support
* Remove unused TS expect error
* Add reroute beta opt-in option
* Add settings option: Middle-click reroute node
* Add settings: Link Markers
* Move settings
* Update litegraph
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
2024-11-12 11:46:14 -05:00
Chenlei Hu
8236163fea
Enable New UI by default ( #1515 )
...
nit
Add playwright test
nit
nit
nit
2024-11-12 10:48:26 -05:00
Chenlei Hu
1ff6e27d9c
Manage widget definitions with Pinia store ( #1510 )
...
* Fix compile
* nit
* Remove extensions.test
* nit
2024-11-11 17:23:52 -05:00
Chenlei Hu
73bdbddf90
Fix rename open/bookmark workflow ( #1507 )
...
* Fix rename open/bookmark workflow
* nit
* Fix save as
* Add browser test
2024-11-11 11:06:41 -05:00
filtered
43012eb1d1
Add settings option: Keep links on delete ( #1504 )
2024-11-10 21:33:48 -05:00
Chenlei Hu
acbc38ced4
Revert "Enable New UI by default ( #1460 )" ( #1476 )
...
This reverts commit f0b735f3dd .
2024-11-08 16:35:52 -05:00
pythongosssss
7e0b87dd32
Live terminal output ( #1347 )
...
* Add live terminal output
* Fix scrolling
* Refactor loading
* Fallback to polling if endpoint fails
* Comment
* Move clientId to executionStore
Refactor types
* Remove polling
2024-11-08 15:38:21 -05:00
Zoltán Dócs
0161a670cf
Fit view to bounds ( #1474 )
...
* fit view:
- fit view to canvas selection
- fit view to whole graph when nothing is selected
- add button to graph canvas menu
- assign default keybinding '.'
* Adjust on changed APIs
* Update litegraph
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
2024-11-08 15:03:21 -05:00
Chenlei Hu
dd192777b7
Consistently use -1 for temporary file size ( #1464 )
2024-11-07 23:34:46 -05:00
Chenlei Hu
f0b735f3dd
Enable New UI by default ( #1460 )
...
* Enable New UI by default
* nit
* Add playwright test
* nit
* nit
* nit
2024-11-07 17:55:53 -05:00
Chenlei Hu
8ae9210298
Always sort workflows tree ( #1456 )
...
* Always sort workflows tree
* nit
* nit
* Add tests
* nit
* nit
2024-11-07 11:29:29 -05:00
Chenlei Hu
40880dbb59
Move refresh button from actionbar to 'Edit' menu ( #1451 )
2024-11-07 08:47:46 -05:00
Chenlei Hu
c560628f1f
[Extension API] Register about panel badge ( #1436 )
...
* Custom about panel badge
* Add playwright test
* Update README
* nit
* nit
* nit
* nit
2024-11-05 19:06:38 -05:00
Chenlei Hu
c56533bb23
Workflow Management Reworked ( #1406 )
...
* Merge temp userfile
Basic migration
Remove deprecated isFavourite
Rename
nit
nit
Rework open/load
Refactor save
Refactor delete
Remove workflow dep on manager
WIP
Change map to record
Fix directory
nit
isActive
Move
nit
Add unload
Add close workflow
Remove workflowManager.closeWorkflow
nit
Remove workflowManager.storePrompt
move from commandStore
move more from commandStore
nit
Use workflowservice
nit
nit
implement setWorkflow
nit
Remove workflows.ts
Fix strict errors
nit
nit
Resolves circular dep
nit
nit
Fix workflow switching
Add openworkflowPaths
Fix store
Fix key
Serialize by default
Fix proxy
nit
Update path
Proper sync
Fix tabs
WIP
nit
Resolve merge conflict
Fix userfile store tests
Update jest test
Update tabs
patch tests
Fix changeTracker init
Move insert to service
nit
Fix insert
nit
Handle bookmark rename
Refactor tests
Add delete workflow
Add test on deleting workflow
Add closeWorkflow tests
nit
* Fix path
* Move load next/previous
* Move logic from store to service
* nit
* nit
* nit
* nit
* nit
* Add ChangeTracker.initialState
* ChangeTracker load/unload
* Remove app.changeWorkflow
* Hook to app.ts
* Changetracker restore
* nit
* nit
* nit
* Add debug logs
* Remove unnecessary checkState on graphLoad
* nit
* Fix strict
* Fix temp workflow name
* Track ismodified
* Fix reactivity
* nit
* Fix graph equal
* nit
* update test
* nit
* nit
* Fix modified state
* nit
* Fix modified state
* Sidebar force close
* tabs force close
* Fix save
* Add load remote workflow test
* Force save
* Add save test
* nit
* Correctly handle delete last opened workflow
* nit
* Fix workflow rename
* Fix save
* Fix tests
* Fix strict
* Update playwright tests
* Fix filename conflict handling
* nit
* Merge temporary and persisted ref
* Update playwright expectations
* nit
* nit
* Fix saveAs
* Add playwright test
* nit
2024-11-05 11:03:27 -05:00
Chenlei Hu
16f2e56d8e
Handle errors from top action menu commands ( #1432 )
2024-11-04 22:50:19 -05:00
Chenlei Hu
2161ae4e5b
Pin selected items (Nodes + Groups) ( #1427 )
...
* Pin selected items (Nodes + Groups)
* Update litegraph
* Add playwright test
* nit
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-11-04 17:36:33 -05:00
filtered
3ba776e6ca
Add Litegraph multi-select & group nesting ( #1416 )
...
* Allow nested groups
Pass all selected items (new litegraph feature) instead of just selected nodes.
* Allow nested groups - context menus
* Update litegraph
* Update litegraph (Select all / Delete selected)
* Add playwright test
* nit
* Update test expectations [skip ci]
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2024-11-03 18:08:42 -05:00
Chenlei Hu
d719a4e0fb
Move exportWorkflow from menu to workflowService ( #1399 )
2024-11-01 19:44:21 -04:00
Chenlei Hu
dfb695be72
[Refactor] Rework userFileStore to match existing API on ComfyWorkflow ( #1394 )
...
* nit
* Move load
* nit
* nit
* Update store API
* nit
* nit
* Move api
* nit
* Update tests
* Add docs
* Add temp user file
* Implement save as
* Test saveAs
2024-10-31 21:58:00 -04:00
Chenlei Hu
0c8fe41b84
Fix queue ResultItem schema ( #1386 )
2024-10-30 20:36:33 -04:00