2 Commits

Author	SHA1	Message	Date
Alexander Brown	0132c77c7d	test: harden 82 Playwright specs for deterministic CI runs (#10967) ... ## Summary Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI runs by replacing race-prone patterns with retry-safe alternatives. No source code changes -- only `browser_tests/` is touched. ## Changes - **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers): | Fix class | Sites | Examples | |-----------|-------|---------:| | `expect(await ...)` -> `expect.poll()` | ~153 | interaction, defaultKeybindings, workflows, featureFlags | | `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 | menu, linkInteraction, assets, bottomPanelShortcuts | | `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 | contextMenu, rightClickMenu, subgraphHelper | | Redundant `nextFrame()` removed | many | defaultKeybindings, minimap, builderSaveFlow | | `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction (graphdialog dismiss guard) | | `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog fixture | | ContextMenu `waitForHidden` simplified (check-then-act race removed) | 1 | ContextMenu fixture | | Non-deterministic node order -> proximity-based selection | 1 | interaction (toggle dom widget) | | Tight poll timeout (250ms) -> >=2000ms | 2 | templates | - **Helper improvements**: Exposed locator getters on `ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and `WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying assertions (`toHaveCount()`, `toHaveText()`) directly. - **Flake pattern catalog**: Added section 7 table to `browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes for reviewers and future authors. - **Docs**: Fixed bad examples in `browser_tests/README.md` to use `expect.poll()`. - **Breaking**: None - **Dependencies**: None ## Review Focus - All fixes follow the rules in `browser_tests/FLAKE_PREVENTION_RULES.md` - No behavioral changes to tests -- only timing/retry strategy is updated - The `ContextMenu.waitForHidden` simplification removes a swallowed-error anti-pattern; both locators now use direct `waitFor({ state: 'hidden' })` --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>	2026-04-09 20:50:56 -07:00
Christian Byrne	9b769656ac	test: add ShareWorkflow dialog E2E tests (DLG-05) (#10588) ... ## Summary Adds Playwright E2E tests for the ShareWorkflow dialog component and its various states. ## Tests added - Dialog opens and shows unsaved state for new workflows (save prompt) - Ready state shows create link button for saved but unpublished workflows - Shared state shows copy URL field with share link after publishing - Stale state shows update link button when workflow modified after publishing - Close button dismisses dialog - Create link transitions dialog from ready to shared state - Tab switching between share link and publish to hub (when comfyHubUploadEnabled) - Tab aria-selected states update correctly on switch ## Approach - Share dialog is gated behind `isCloud` (compile-time constant), so tests invoke it directly via `page.evaluate()` importing `useShareDialog` - Share service API calls (`/api/userdata/*/publish`, `/api/assets/from-workflow`) mocked via `page.route()` for deterministic state testing - Dialog state (loading → unsaved → ready → shared → stale) controlled by mock responses - Feature flags set via `serverFeatureFlags.value` for tab visibility testing ## Notes - All pre-existing TS2307 errors are `.vue` module resolution — no new type errors - Tests cover the 5 dialog states: loading, unsaved, ready, shared, stale ## Task Part of Test Coverage Q2 Overhaul (DLG-05). ## Conventions - Uses Vue nodes with new menu enabled - Tests read as user stories - No full-page screenshots - Proper waits, no sleeps - All API calls mocked ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10588-test-add-ShareWorkflow-dialog-E2E-tests-DLG-05-3306d73d365081a0ab15f333707e493b) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>	2026-04-08 14:14:47 -07:00