Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-24 00:09:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,056 Commits 1,220 Branches 626 Tags
2ddf1a1bf2b98fd9ea7735705a14a1ce2ed3e52e
Commit Graph

66 Commits

Author SHA1 Message Date
bymyself
7c28a9660a Revert "[don't port to main] fix: Set UseNewMenu default to Disabled to match main" 
This reverts commit 39ed1d762f.
 2025-10-25 20:52:39 -07:00
bymyself
39ed1d762f [don't port to main] fix: Set UseNewMenu default to Disabled to match main 
rh-test had UseNewMenu='Top' by default, showing workflow tabs in all tests.
main has UseNewMenu='Disabled' by default, hiding workflow tabs.

Since we pulled snapshots from main, tests were failing due to UI mismatch.
Changing rh-test default to match main fixes snapshot comparisons.
 2025-10-25 19:10:16 -07:00
bymyself
b2a82a5729 [don't port to main] fix: Skip cloud auth guard and mock /api/features for Playwright tests 
Cloud builds (rh-test) have two initialization blockers for Playwright tests:

1. Firebase auth guard in router waits 16s for auth initialization
   - Tests timeout at 15s, causing all tests to fail
   - Fix: Skip entire auth guard when DISTRIBUTION !== 'cloud'
   - Safe because guard is 100% cloud-specific (Firebase, cloud login, etc.)

2. main.ts calls loadRemoteConfig() which fetches /api/features
   - Only triggered when isCloud=true, but still blocks if endpoint missing
   - Fix: Mock /api/features in ComfyPage setup, try real backend first

Both issues only affect cloud builds. Playwright builds with DISTRIBUTION='localhost'
so these fixes make tests pass while keeping cloud functionality intact.
 2025-10-25 13:11:11 -07:00
Arjan Singh
0239a83da2 Update rh-test (as of 2025-10-11) (#6044) 
## Summary

Tested these changes and confirmed that:
1. Feedback button shows.
2. You can run workflows and switch out models.
3. You can use the mask editor. (thank you @ric-yu for helping me
verify).

## Changes

A lot, please see commits.

Gets us up to date with `main` as of 10-11-2025.

---------

Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: snomiao <snomiao@gmail.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: DrJKL <DrJKL@users.noreply.github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Marwan Ahmed <155799754+marawan206@users.noreply.github.com>
Co-authored-by: DrJKL <DrJKL0424@gmail.com>
Co-authored-by: Rizumu Ayaka <rizumu@ayaka.moe>
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com>
Co-authored-by: AustinMroz <4284322+AustinMroz@users.noreply.github.com>
Co-authored-by: Austin Mroz <austin@comfy.org>
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: Benjamin Lu <benceruleanlu@proton.me>
Co-authored-by: Jin Yi <jin12cc@gmail.com>
Co-authored-by: Robin Huang <robin.j.huang@gmail.com>
 2025-10-14 15:59:26 -07:00
bymyself
ff0c15b119 merge main into rh-test 2025-09-28 15:33:29 -07:00
Christian Byrne
95a1c86c23 [tests] update selection overlay tests after canvas migration (#5173) 
* [fix] update selection overlay tests after canvas migration

Update browser tests to work with canvas-based selection overlay introduced in PR #5158.
Replaces DOM-based .selection-overlay-container checks with .selection-toolbox visibility
and converts border visibility tests to canvas screenshot comparisons.

Fixes #5158

* [chore] remove unused file flagged by knip

* [fix] adjust test expectations for canvas-based positioning

- Skip animated webp test unrelated to selection overlay changes
- Update toolbox position expectations to match canvas-based coordinates
- Canvas positioning uses different coordinate system than DOM overlay

* [fix] improve positioning test flexibility and revert webp skip

- Make toolbox position test more flexible for canvas-based coordinates
- Revert animated webp test skip as requested in review
- Canvas positioning varies more than DOM, use reasonable bounds instead

* Update test expectations [skip ci]

* [refactor] address review comments - use fixture locators

- Add selectionToolbox locator to ComfyPage fixture as requested
- Replace .isVisible() === false with .not.toBeVisible() pattern
- Update all selection toolbox locators to use fixture instead of inline selectors
- Improves maintainability and follows established patterns

* [refactor] use fixture canvas locator for screenshots

Replace inline canvas locators with comfyPage.canvas fixture property
for consistency and maintainability as suggested in review.

---------

Co-authored-by: github-actions <github-actions@github.com>
 2025-08-23 12:12:28 -07:00
pythongosssss
03ad06ea14 Add preview to workflow tabs (#4290) 2025-08-09 14:39:40 -07:00
Chenlei Hu
7bbbf59722 feat: Enable double-click on subgraph slot labels for renaming (#4833) 2025-08-08 18:11:21 -07:00
Benjamin Lu
489b205bf5 [chore] Fix litegraph import after migration to git subtree 
Updated import from @comfyorg/litegraph npm package to relative path
since browser tests don't have @ alias configured in tsconfig

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-08-04 05:17:09 -04:00
filtered
4d7e9b70d1 [Test] Update test expectations for #4420 (#4511) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-07-24 17:59:39 +10:00
pythongosssss
62f3ba0689 V3 UI - Tabs & Menu rework (#4374) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-07-24 00:09:12 -07:00
Christian Byrne
7b32a2fb6e [tests] Add browser tests for subgraph functionalities (#4495) 2025-07-22 10:35:49 -07:00
Christian Byrne
a39f6e6763 [feat] DOM widget promotion for subgraph inputs (#4491) 2025-07-21 11:52:54 -07:00
Christian Byrne
5cc1a8dea2 [test] Add release notification browser tests (#4311) 
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-02 01:29:09 -07:00
Christian Byrne
64a2a5b3ae [fix] Mock release API in browser tests to prevent UI interference (#4310) 2025-06-30 17:36:07 -07:00
duckcomfy
995979a4e1 feat: add keyboard shortcut to move selected nodes (unbound by default) (#4066) 
Co-authored-by: duckcomfy <a@a.a>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
 2025-06-11 06:35:49 -07:00
Chenlei Hu
c1442ec755 [Cleanup] Remove api nodes news dialog (#3890) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-05-14 21:06:08 -04:00
filtered
a17fb04f83 [Test] Add per-workflow viewport comparison test (#3867) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-05-13 11:48:38 +10:00
Chenlei Hu
2d9a0d02ab [API Nodes] Add API Nodes new feature dialog (#3755) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-05-04 17:20:05 -04:00
Chenlei Hu
197f33ffcd [Bug] Register dom widget when only node is added to graph (#3732) 2025-05-02 12:49:19 -04:00
thot experiment
878aedb4f7 add svg metadata loading (#3719) 
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
 2025-05-02 09:26:24 +10:00
Chenlei Hu
262991db6b [Bug] Prevent node pasting in signin dialog (#3568) 2025-04-22 16:18:25 -04:00
Christian Byrne
add805460c Fix drag and drop image with embedded workflow on Firefox (#3519) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-04-19 22:19:48 -04:00
Chenlei Hu
a489c19b07 Upstream rgthree's link fixer (#3350) 2025-04-08 18:32:43 -04:00
Chenlei Hu
00d281c7fa [Test] Add playwright tests (#3245) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-26 16:32:42 -04:00
Christian Byrne
4dad89369a Load workflows from GLTF files (#3169) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-20 20:55:51 -04:00
Chenlei Hu
5b730517a3 [Test] Sync workflow instead of full page reload (#3168) 2025-03-20 20:42:12 -04:00
Christian Byrne
26a7ebdd77 Fix uploaded image not forcing re-render (#3115) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-17 20:13:05 -04:00
filtered
9f36b9daf3 [Test] Add ComfyMouse fixture for Playwright tests (#2826) 2025-03-04 01:34:42 +11:00
bymyself
792c5f2246 Load workflows from webm files (#2772) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-28 16:00:02 -05:00
Chenlei Hu
cdf42d5ad7 [Refactor] Move zod schemas to schemas/ folder (#2753) 2025-02-27 13:05:01 -05:00
Chenlei Hu
79db202925 [New Feature] Selection Toolbox (#2608) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-17 19:07:49 -05:00
Margen67
7bc48c5074 Formatting/cleanup (#2594) 2025-02-17 10:10:00 -05:00
filtered
c757fbaeb4 [Test] Fix unnecessary circular reference (#2596) 2025-02-17 20:18:26 +11:00
bymyself
e992bd6571 Add tutorial workflow function for new desktop users (#2315) 
Co-authored-by: huchenlei <huchenlei@proton.me>
 2025-01-25 12:23:27 -05:00
Chenlei Hu
e8cd9c7642 [BrowserTest] Replace ComfyPage.reload with ComfyPage.setup (#2208) 2025-01-09 12:54:05 -05:00
bymyself
179b8c22a9 [BrowserTest] Refactor test fixtures (#2165) 2025-01-05 13:03:07 -05:00
Chenlei Hu
ea489851ed [BugFix] Fix open workflow after insert (#2138) 2025-01-03 11:09:28 -05:00
bymyself
5c7cbe968e Fix gallery changing image every time a task finishes (#2125) 2025-01-02 17:51:28 -05:00
Chenlei Hu
3189e310a8 Add default confirm dialog (#2114) 2024-12-31 18:18:48 -05:00
Chenlei Hu
174a9a114a Expose dialogService to extensionManager (#2113) 2024-12-31 17:01:37 -05:00
bymyself
74b02237db Add virtual scroll to Queue Tab for improved performance (#2108) 2024-12-31 12:35:29 -05:00
Chenlei Hu
d8f074fea0 [Lint] Sort imports (#2104) 2024-12-30 17:26:37 -05:00
Chenlei Hu
f851e356f2 Fix flaky reroute insert playwright test (#2051) 
Co-authored-by: github-actions <github-actions@github.com>
 2024-12-25 21:57:52 -05:00
bymyself
9f6c828cfe Fix search input failing to focus after adding filter (#2023) 2024-12-23 09:27:17 -05:00
Chenlei Hu
a99f63784d Fix io slot label overwrite by i18n (#1904) 
* Add test on export with different locales

* Fix node slot rename
 2024-12-13 12:27:16 -08:00
Chenlei Hu
2d1b2cb1cc Fix group node playwright tests (#1849) 
* Fix group node playwright tests

* nit

* nit
 2024-12-08 20:21:59 -05:00
Chenlei Hu
517ae56763 Translate node title and description (#1822) 
* Collect node def i18n

* Add collected en locale

* Sort by node id

* Add translations

* Show translated node def

* Update locales [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-12-06 16:56:54 -05:00
filtered
735153886f Confirm delete workflow (#1772) 
* Add confirm delete workflow prompt

* Add confirm delete workflow setting

* Add delete workflow tests

* Change dialog to modal, set default cancel

* Fix setting version key

* Rename for clarity

* Fix tests

- Move into correct section
- Add confirm control

* Export type: ShowDialogOptions

* Replace workflow overwrite with new dialog

* Add delete workflow confirmation dialog

* Update i18n

* Add item list support to confirmation dialog

* Prevent multiple dialogs for same action

* Add confirm close file when dirty

* Add i18n for overwrite dialog

* Fix regression: confirm dialog setting ignored

* Fix delete last workflow does not open replacement

* Update tests
 2024-12-04 14:11:49 -05:00
Chenlei Hu
d531bc34c4 Make ChangeTracker detect changes in workflow.extra (Except ds) (#1692) 
* Compare workflow.extra content

* Add tests
 2024-11-25 21:59:27 -05:00