Alexander Brown
302e9d5be7
fix: browser_tests Phase 2 - null assertions
...
Amp-Thread-ID: https://ampcode.com/threads/T-019c1797-ff0a-7418-840b-8c76fb81eeec
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:58:00 -08:00
Alexander Brown
b56045c462
fix: browser_tests Phase 1 - mechanical fixes
...
- Rename dragAndDrop to dragDrop (7 occurrences)
- Add override modifiers in SidebarTab.ts (4 fixes)
- Remove .ts import extensions in actionbar.spec.ts
- Prefix unused variables with underscore (9 files)
- Fix ESLint import() type annotation in globals.d.ts
Reduces typecheck:browser errors from 229 to 215
Amp-Thread-ID: https://ampcode.com/threads/T-019c1787-c781-761d-b95a-4844e909e64c
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:57:58 -08:00
Alexander Brown
6cd105fdf0
test: add Window type augmentation and standardize window access
...
- Add browser_tests/types/globals.d.ts with Window interface augmentation
- Add types for app, graph, LiteGraph, LGraphBadge and test globals
- Standardize window['prop'] to window.prop across 37 test files
- Update browser_tests/tsconfig.json to include new type definitions
Amp-Thread-ID: https://ampcode.com/threads/T-019c16b3-cc31-70ea-9727-a933cb0ee942
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:57:55 -08:00
Alexander Brown
b7986ae5f6
fix: remove setTimeout anti-patterns in test fixtures
...
Remove redundant setTimeout calls inside page.evaluate() in SubgraphHelper.ts.
The waits were unnecessary since proper Playwright waitForSelector calls already exist after the evaluate returns.
Amp-Thread-ID: https://ampcode.com/threads/T-019c134d-cf30-7028-aca7-cfc6227c90ef
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 01:17:40 -08:00
Alexander Brown
e4b520c602
refactor: extract SubgraphHelper from ComfyPage.ts
...
- Create browser_tests/fixtures/helpers/SubgraphHelper.ts with 10 methods
- Add subgraph: SubgraphHelper property to ComfyPage
- Replace original methods with deprecation proxy stubs
- Reduces ComfyPage.ts from 1633 to 1409 lines (~224 lines removed)
Amp-Thread-ID: https://ampcode.com/threads/T-019c12cc-5256-7359-b830-28d1c3639daa
Co-authored-by: Amp <amp@ampcode.com >
2026-01-30 22:49:43 -08:00
