Alexander Brown
b56045c462
fix: browser_tests Phase 1 - mechanical fixes
...
- Rename dragAndDrop to dragDrop (7 occurrences)
- Add override modifiers in SidebarTab.ts (4 fixes)
- Remove .ts import extensions in actionbar.spec.ts
- Prefix unused variables with underscore (9 files)
- Fix ESLint import() type annotation in globals.d.ts
Reduces typecheck:browser errors from 229 to 215
Amp-Thread-ID: https://ampcode.com/threads/T-019c1787-c781-761d-b95a-4844e909e64c
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:57:58 -08:00
Alexander Brown
6cd105fdf0
test: add Window type augmentation and standardize window access
...
- Add browser_tests/types/globals.d.ts with Window interface augmentation
- Add types for app, graph, LiteGraph, LGraphBadge and test globals
- Standardize window['prop'] to window.prop across 37 test files
- Update browser_tests/tsconfig.json to include new type definitions
Amp-Thread-ID: https://ampcode.com/threads/T-019c16b3-cc31-70ea-9727-a933cb0ee942
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:57:55 -08:00
Alexander Brown
4e00e8428f
refactor: wire helpers into ComfyPage and update test usages
...
Phase 2 of ComfyPage refactor:
- Add ToastHelper, DragDropHelper, CommandHelper instances to ComfyPage
- Remove migrated methods from ComfyPage (command, toast, dragDrop, workflow, canvasOps, nodeOps methods)
- Update all test files to use new helper paths
- Keep visibleToasts as passthrough getter for backward compatibility
Amp-Thread-ID: https://ampcode.com/threads/T-019c1666-ed27-773c-976a-07cc805d7a6c
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 15:44:57 -08:00
Alexander Brown
be7f5b30b7
refactor: create and extend browser test helpers for ComfyPage extraction
...
Phase 1 of ComfyPage refactor - extract method groups into helpers:
- New ToastHelper: toast error/visibility/close methods
- New DragDropHelper: file and URL drag-and-drop methods
- New CommandHelper: command execution and registration
- Extended WorkflowHelper: undo/redo queue, modified state, export
- Extended CanvasHelper: group position/drag, edge connect/disconnect
- Extended NodeOperationsHelper: prompt dialog, node drag, widget adjust
Amp-Thread-ID: https://ampcode.com/threads/T-019c165a-5aba-7582-9f2b-e5b2bba2783b
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 15:44:56 -08:00
Alexander Brown
ccf459684e
refactor: remove ComfyPage wrapper methods, use helpers directly
...
- Remove 27 deprecated/wrapper methods from ComfyPage
- Migrate callers to use helper classes directly:
- keyboard.selectAll/bypass/undo/redo/moveUp/moveDown
- clipboard.copy/paste
- settings.setSetting/getSetting
- workflow.loadWorkflow/deleteWorkflow/setupWorkflowsDirectory
- contextMenu.clickMenuItem/clickLitegraphMenuItem
- nodeOps.resizeNode with DefaultGraphPositions
- canvasOps.clickEmptySpace with DefaultGraphPositions
- Replace deprecated node click methods with direct canvas clicks
- Replace position getter properties with DefaultGraphPositions imports
Amp-Thread-ID: https://ampcode.com/threads/T-019c15e7-2319-76ec-855e-098ec75ef18a
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 13:48:43 -08:00
Alexander Brown
c87b863a3b
Use named imports.
2026-01-31 13:22:15 -08:00
Alexander Brown
aea5afa8f3
test: extract SettingsHelper from ComfyPage (Phase 4.1)
...
Amp-Thread-ID: https://ampcode.com/threads/T-019c1373-f6d0-7426-a3ee-5673891f9dcc
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 01:50:20 -08:00
