Alexander Brown
818d0ef5f6
fix: update nodeLibrary customize dialog selectors
...
Replace getByRole('radio') with button group selectors.
The Customize Folder dialog now uses PrimeVue SelectButton components instead of radio buttons.
Amp-Thread-ID: https://ampcode.com/threads/T-019c1698-7c35-747e-8b78-b9d47f49c950
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 16:33:12 -08:00
Alexander Brown
ccf459684e
refactor: remove ComfyPage wrapper methods, use helpers directly
...
- Remove 27 deprecated/wrapper methods from ComfyPage
- Migrate callers to use helper classes directly:
- keyboard.selectAll/bypass/undo/redo/moveUp/moveDown
- clipboard.copy/paste
- settings.setSetting/getSetting
- workflow.loadWorkflow/deleteWorkflow/setupWorkflowsDirectory
- contextMenu.clickMenuItem/clickLitegraphMenuItem
- nodeOps.resizeNode with DefaultGraphPositions
- canvasOps.clickEmptySpace with DefaultGraphPositions
- Replace deprecated node click methods with direct canvas clicks
- Replace position getter properties with DefaultGraphPositions imports
Amp-Thread-ID: https://ampcode.com/threads/T-019c15e7-2319-76ec-855e-098ec75ef18a
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 13:48:43 -08:00
Alexander Brown
7f2454efec
fix(browser_tests): replace .nth() with semantic selectors
...
- Remove unused saveButton selector from ComfyMenu
- Replace widgetTextBox .nth(1) with node-scoped selector
- Replace .nth(3) toast selector with .p-toast-message filter
- Replace .nth(1) category selector with getByTestId
- Replace .nth(1) node selector with getNodeInFolder() helper
- Add nodeSelector(), folderSelector(), getNodeInFolder() methods
- Add saveButton and nodeLibrary TestIds to selectors.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019c155c-92e1-76f3-b6ce-7fc3ffa11582
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 10:52:41 -08:00
Alexander Brown
681709f8e7
refactor(browser_tests): remove deprecated proxy methods from ComfyPage
...
Migrate all test callers to use helper classes directly:
- nodeOps: getGraphNodesCount, getNodeRefById, selectNodes, etc.
- canvasOps: dragAndDrop, zoom, pan, resetView, etc.
- subgraph: rightClickInputSlot, connectToOutput, etc.
Reduces ComfyPage.ts from 1335 to 1085 lines (-250 lines).
Amp-Thread-ID: https://ampcode.com/threads/T-019c1318-58b7-757f-801c-5b676f0d3421
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 00:52:33 -08:00
Alexander Brown
2717f8d489
test: migrate brittle :nth-child() selectors to getByRole('radio')
...
- Replace 4 CSS selectors with semantic locators in nodeLibrary.spec.ts
- Uses PrimeVue SelectButton's accessible radio button names
- Part of Playwright best practices remediation
Amp-Thread-ID: https://ampcode.com/threads/T-019c11ff-0d10-771a-abaf-7d8d908800b3
Co-authored-by: Amp <amp@ampcode.com >
2026-01-30 19:02:53 -08:00
Alexander Brown
1ec55fdf31
test: replace waitForTimeout with retrying assertions
...
- widget.spec.ts: use expect().toPass() for combo refresh
- subgraph.spec.ts: use comfyPage.setup() after reload
- nodeLibrary.spec.ts: use toHaveCount() for debounced search
- remoteWidgets.spec.ts: use expect().toPass() for backoff test
- litegraphUtils.ts: refactor navigateIntoSubgraph to use toPass()
Amp-Thread-ID: https://ampcode.com/threads/T-019c11f1-e839-772c-8890-b77cfdf70124
Co-authored-by: Amp <amp@ampcode.com >
2026-01-30 18:51:55 -08:00
Alexander Brown
7b68b19f11
Component: The Rest of the PrimeVue buttons ( #7649 )
...
## Summary
Automated initial change, cleaned up manually.
Please check the screenshot changes.
Includes a11y updates to icon buttons.
Doesn't hit the buttons in Desktop.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7649-WIP-Component-The-Rest-of-the-PrimeVue-buttons-2ce6d73d365081d68e06f200f1321267 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-12-29 15:03:34 -08:00
Alexander Brown
bf8d9de1c1
Fix: Flaky Playwright Tests: retry some assertions ( #7389 )
...
## Summary
Retries the widget value change check for up to 2 whole seconds.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7389-Fix-remoteWidgets-Playwright-test-add-retry-for-assertion-2c66d73d3650814e98b6fdfc83f6d3d6 )
by [Unito](https://www.unito.io )
2025-12-11 14:02:23 -08:00
Chenlei Hu
9e9459815d
[Refactor] Split menu.spec.ts ( #3107 )
2025-03-17 15:55:48 -04:00
