Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-23 08:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,115 Commits 666 Branches 559 Tags
35e56a441cdbdcba1bed3d47dfd577d68d02048d
Commit Graph

3476 Commits

Author SHA1 Message Date
Terry Jia
b1713b4c80 [3d] add lineart mode (#2800) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-02 10:48:23 -05:00
filtered
af7db40fce [chore] Clean up ignores after strict mode enabled (#680) 
- Replaces all `ts-ignore` with `ts-expect-error`
- Resolves https://github.com/Comfy-Org/litegraph.js/issues/578
 2025-03-02 14:56:15 +00:00
filtered
a815ce92a8 Add final refactoring to enable TS strict (#678) 
- Removes long-deprecated onMenuNodePin
  - Code search empty
- Fixes TS types
- Minor refactors to ensure type-safety
- Adds explicit throws and null checks
 2025-03-02 14:42:24 +00:00
filtered
972527de70 [Refactor] Use strict mode in Add Node menus (#677) 
- Improves TS types
- Adds type guards / null checks
 2025-03-02 14:17:25 +00:00
filtered
77b274f27f Add link context menu info to replace console error (#676) 
Shows a single menu item with an error message when a link is corrupt.
 2025-03-02 14:10:43 +00:00
filtered
b1885ebec8 Remove redundant code - onGetInputs / onGetOutputs (#674) 
- Removes unused context menu for optional in/outputs
- At the top of the node context menu, greyed out `Inputs` and `Outputs`
- API does not fit with current design
- If required, rewrite would be simpler
 2025-03-02 13:47:48 +00:00
filtered
6cb9131035 [TS] Use strict mode in LGraphCanvas (#673) 
- Adds remaining TS nullable types
- Adds type guards to allow strict mode
  - Uses explicit throw in places that would throw regardless
- Adds ts-ignore that must be removed later
  * [ ] #578
 2025-03-02 13:34:02 +00:00
filtered
02d991d669 [Refactor] Minor refactors to support strict mode (#671) 
- Removes unnecessary `null`-init
- Deprecates unused drag / drop code
- Adds null checks
 2025-03-02 09:02:29 +00:00
filtered
1aba15bbca Fix incorrect links highlighted (#670) 
Fixes rare issue where incorrect links could be highlighted (and
seemingly remain highlighted).

Requires corrupt links & null coercion.
 2025-03-02 08:49:13 +00:00
filtered
78175e2c1b [TS] Add strict nullability to LGraphCanvas (#669) 
- Updates typing in copy & paste
- Clean up
 2025-03-02 08:34:26 +00:00
filtered
d597271954 Add runtime type guards to search box (#668) 
- Prevents unnecessary property access exceptions
- Adds TS strict types
- Removes inline polyfill for `Array.filter`
 2025-03-02 08:12:15 +00:00
filtered
9b6a78e7df [Refactor] Prefer createElement over innerHTML (#667) 
- Part of TS strict conversion
- Improves type safety of canvas panel / dialog functions
- Removes more instances of pointer event wrapper
 2025-03-02 02:47:22 +00:00
filtered
193b09999f [TS] Use strict mode in dialog & panel (#666) 
Includes minor refactors to retain inferred types in branches.
 2025-03-02 02:27:10 +00:00
Chenlei Hu
f5c21814f9 Remove broken/unused widget[TARGET] (#2795) 2025-03-01 21:26:50 -05:00
Chenlei Hu
0175db58bb [Type] Add type annotations for widgetInputs litegraph hooks (#2793) 2025-03-01 19:27:21 -05:00
Chenlei Hu
503341b966 Inline numeric widget configurations (#2792) 2025-03-01 18:09:23 -05:00
filtered
6a42484669 [TS] Use strict nullability in LGraphCanvas (#665) 
- Adds runtime null checking
- Converts canvas context to non-nullable
- Adds explicit throws for some edge cases
- Improves TS types
 2025-03-01 22:44:34 +00:00
bymyself
e58fab92d1 Use responsive grid for templates dialog (#2791) 2025-03-01 17:08:41 -05:00
filtered
539fa91b0d [TS] Use strict mode in LGraphCanvas (#664) 
- Prefer `undefined` over `null`
- Primarily nullable type updates
 2025-03-01 21:58:50 +00:00
Chenlei Hu
09ab14ac81 [Type] Disallow type upcasting for node input spec (#2790) 2025-03-01 16:58:45 -05:00
filtered
bca0af82a3 [TS] Update type to reflect actual usage (#2788) 2025-03-01 16:44:33 -05:00
bymyself
9b8f9bd597 Allow passthrough to root component when creating dialog (#2787) 2025-03-01 16:43:32 -05:00
filtered
ab25d1fc6e [Cleanup] Remove redundant code (#663) 
Removes:

- Unused option from public API `getWidgetAtCursor` - use without params
- Unused workaround impl. for WebGL
- Invalid code (incorrect `tabIndex` casing)
 2025-03-01 17:54:35 +00:00
filtered
7b4bea8e62 Remove deprecated code - webGL (#660) 
Removes long-deprecated WebGL code.
 2025-03-01 16:33:17 +00:00
Chenlei Hu
2b212f9701 S&R improved filename sanitizing (#2784) 
Co-authored-by: typpos <28550406+typpos@users.noreply.github.com>
 2025-03-01 10:47:42 -05:00
filtered
177a5a0d54 [CodeHealth] Remove wheel listener & event wrapper (#656) 
- Replaces the long-deprecated `mousewheel` and `DOMMouseScroll` event
listeners with `wheel` listener
  - Verified no change in Chromium behaviour (desktop, mouse)
- Removes redundant pointer listener wrapper
- Fixes types
 2025-03-01 13:18:15 +00:00
Miguel C
5721b1c27c [Refactor] Fix step calculation in Knob Widget (#651) 
Removes a stray console.log and fixes the step calculation.
 2025-03-01 23:36:55 +11:00
filtered
c473130499 [TS] Use strict mode in LGraphCanvas (#654) 
- Prefer creating HTML elements in JS and `append()` over innerHTML &
`querySelector()`
- Removes redundant code
- Adds/fixes TS types
 2025-03-01 11:52:42 +00:00
filtered
bad923a7f0 [Refactor] Remove deprecated mousewheel events (#652) 
Prefer "wheel" event (added around Chrome v31).
 2025-03-01 11:34:23 +00:00
filtered
b71a851a35 [TS] Use Litegraph strict narrowed type (#2781) 2025-03-01 21:52:34 +11:00
Chenlei Hu
a814f9f902 [Test] Run unittest with vitest (#2779) 2025-02-28 22:09:17 -05:00
filtered
b36bf3d4a2 [CodeHealth] Apply modern standards to LGraphCanvas (#650) 
- Prefer template string
- Prefer explicit throw to undefined TypeError
- Remove unnecessary `this` assignment
 2025-02-28 22:08:23 +00:00
bymyself
792c5f2246 Load workflows from webm files (#2772) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-28 16:00:02 -05:00
filtered
c4faaf4210 [TS] Fix ContextMenu types (#649) 
- No runtime changes
- Drastically improves ContextMenu type accuracy / safety
- Allows TS strict conversion
 2025-02-28 14:52:07 +00:00
filtered
b877312336 [Refactor] Fix TS types, remove redundant code (#648) 
Minor clean up and graph null deref checks.

Minor runtime change: due to optional chaining, it is possible a
downstream consumer is catching this extremely rare behaviour on purpose
and handling it.
 2025-02-28 11:13:23 +00:00
filtered
4365873039 [Refactor] Prefer NullGraphError & standardisation (#647) 
- Best effort code search for convert explicit `null` to `undefined`
- Prefer explicit throw over `TypeError`
- Prefer template strings
 2025-02-28 20:16:34 +11:00
filtered
b4688e18f9 [Refactor] Prefer includes over indexOf -1 (#646) 
Enables ESLint auto-fix rule.
 2025-02-28 08:53:29 +00:00
filtered
7b19abf83a [TS] Use strict mode in Canvas: initializers (#645) 
- Code search verified no consumers expecting explicit null on callbacks
(best effort)
- Removes redundant code
 2025-02-28 08:48:53 +00:00
Chenlei Hu
fc39ce9624 Rewrite/Test rounding logic of numeric widgets (#2758) 2025-02-27 17:52:16 -05:00
Chenlei Hu
cb4a5b88fc Remove magic 10% scale on numeric widget step (#2759) 2025-02-27 16:56:22 -05:00
Chenlei Hu
c66ca2ae66 Remove magic 10% scale on numeric widget step (#643) 
There are external code still dependent on the fact that
Widget.options.step is scaled 10x, so the 10x-ed value is still kept
there, while we use the new unscaled step2 within our code now.

Ref:
https://cs.comfy.org/search?q=context:global+%22step+/+10%22&patternType=keyword&sm=0
 2025-02-27 16:23:53 -05:00
bymyself
8775c1d930 Add video_upload to combo input schema (#2760) 2025-02-27 16:22:14 -05:00
Chenlei Hu
1dab413473 [Schema] Expose input options types (#2757) 2025-02-27 14:22:42 -05:00
filtered
0a09ecc7ac [TS] Use strict mode in LGraphNode (#642) 
- Adds minor type coercions to resolve type errors
- Deprecates unused public APIs
- 7a0336e3ad7239b7bb588bbbe7912322257e9ae2 works around a bug in the tsc
strict plugin
- Adds ts-ignore that must be removed later
  * [ ] #578
 2025-02-27 19:03:42 +00:00
Chenlei Hu
1d95d639e9 [Refactor] Extract nodeDefSchema from apiSchema (#2756) 2025-02-27 13:39:23 -05:00
bymyself
e380d792c7 Support models metadata in node properties (#2754) 2025-02-27 13:25:16 -05:00
Chenlei Hu
cdf42d5ad7 [Refactor] Move zod schemas to schemas/ folder (#2753) 2025-02-27 13:05:01 -05:00
filtered
fab386275c [Refactor] Clean up LGraphNode ahead of TS strict (#641) 
Preparation for TS strict conversion. Simplifies code & improves
readability.
 2025-02-27 17:55:11 +00:00
Chenlei Hu
96f02dbf80 [Refactor] Use util.clone in mergeIfValid (#2752) 2025-02-27 11:47:56 -05:00
filtered
38dd7b7089 [Refactor] Prefer for..of to incremental for loops (#640) 
- Converts incremental for loops to for..of loops
- Improves readability
 2025-02-27 16:28:10 +00:00