Commit Graph

3292 Commits

Author SHA1 Message Date
Comfy Org PR Bot
3818b7ce57 Fix widget disconnection issue in subgraphs #4922 (#5015) (#5019)
* [bugfix] Fix widget disconnection issue in subgraphs

When disconnecting a node from a SubgraphInput, the target input's link
reference was not being cleared in LLink.disconnect(). This caused
widgets to remain greyed out because they still thought they were
connected (slot.link was not null).

The fix ensures that when a link is disconnected, the target node's
input slot is properly cleaned up by setting input.link = null.

Fixes #4922

🤖 Generated with [Claude Code](https://claude.ai/code)



* [test] Add tests for LLink disconnect fix for widget issue

Add comprehensive tests for the LLink.disconnect() method to verify
that target input link references are properly cleared when disconnecting.
This prevents widgets from remaining greyed out after disconnection.

Tests cover:
- Basic disconnect functionality with link reference cleanup
- Edge cases with invalid target nodes
- Preventing interference between different connections

Related to #4922

🤖 Generated with [Claude Code](https://claude.ai/code)



---------

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-15 13:36:48 -07:00
Comfy Org PR Bot
aaaa8c820f api_nodes: added prices for gpt-5 series models (#4958) (#5016)
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
2025-08-15 13:04:32 -07:00
Comfy Org PR Bot
f98443dbb6 Translated Keyboard Shortcuts (#5007) (#5012)
* fix: Update command label rendering to use i18n normalization

* fix: Replace deprecated  with t for command label rendering

* fix: Simplify command rendering check in ShortcutsList tests

* fix: Add missing translation for command label in ShortcutsList tests

Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
2025-08-15 12:12:54 -07:00
Comfy Org PR Bot
1094b57eb5 [test] Add tests for --disable-api-nodes release fetch skip functionality (#4799) (#5008)
- Add comprehensive test coverage for the new --disable-api-nodes argument handling
- Tests verify release fetching is properly skipped when argument is present
- Cover edge cases including multiple args, null argv, and missing system stats
- Ensures backward compatibility when argument is not present

Co-authored-by: Yoland Yan <4950057+yoland68@users.noreply.github.com>
2025-08-15 11:45:36 -07:00
Christian Byrne
f5409ea20c fix: Correct traditional Chinese to simplified Chinese in translations (#5005) (#5011)
* Correct some translations that use traditional Chinese to simplified Chinese.

* Update locales [skip ci]

* Correct the rest of the translations

---------

Co-authored-by: ComfyUI Wiki <contact@comfyui-wiki.com>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-15 11:43:45 -07:00
Christian Byrne
bfed966ae7 Feature/arabic translation (#4916) (#5006)
Co-authored-by: arab-future-academy <arabfutueacademy@gmail.com>
2025-08-15 10:32:01 -07:00
Christian Byrne
1068d1bc9a Remove unused Litegraph context menu options (#4867) (#4998)
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-15 08:58:02 -07:00
Christian Byrne
6904029fad [backport] Restore group node conversion menu with deprecated label (cherry-pick #4967) (#4987)
* [feat] Restore group node conversion menu with deprecated label (#4967)

* Fix screenshot conflicts - use core/1.25 baseline versions

* Revert screenshots to PR version with deprecated menu item
2025-08-14 23:05:43 -07:00
Comfy Org PR Bot
263f52f539 Fix inconsistency on bypass from context menu (#4988) (#4997)
When a node is bypassed from the selection toolbox or by pressing a
keybind for bypass, it will also recursively bypass the contents of a
subgraph. This effect was not applied when clicking the bypass button
from the context menu. The context menu option has been updated to
perform the same action as the others so that behaviour is consistent.

Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-14 23:02:38 -07:00
Christian Byrne
be7d239087 [fix] Prevent incompatible connections to SubgraphInputNode occupied slots (#4984) (#4993) 2025-08-14 21:34:03 -07:00
Comfy Org PR Bot
6265dfac38 fix: Handle missing subgraph inputs gracefully during workflow import (#4985) (#4986)
When loading workflows, SubgraphNode would throw an error if an input
exists in the serialized data that doesn't exist in the current subgraph
definition. This can happen when:
- Subgraph definitions change after workflows are saved
- Workflows are shared between users with different subgraph versions
- Dynamic inputs were added that don't exist in the base definition

This change converts the hard error to a warning and continues processing,
allowing workflows to load even with mismatched subgraph configurations.

Fixes #4905

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
2025-08-14 21:22:12 -07:00
Comfy Org PR Bot
97d95e5574 [backport 1.25] fix pricing for KlingImage2VideoNode (#4976)
Backport of #4957 to `core/1.25`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4976-backport-1-25-fix-pricing-for-KlingImage2VideoNode-24f6d73d365081ac9481dfbd87aa96e3)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
2025-08-14 12:11:12 -07:00
Comfy Org PR Bot
be4e5b0ade [backport 1.25] show group self color in minimap (#4969)
Backport of #4954 to `core/1.25`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4969-backport-1-25-show-group-self-color-in-minimap-24e6d73d36508111b8f5ee86949b7144)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
2025-08-14 12:10:55 -07:00
Comfy Org PR Bot
f6967d889e [backport 1.25] fix: Add guards for _listenerController.abort() calls in SubgraphNode (#4970)
Backport of #4968 to `core/1.25`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4970-backport-1-25-fix-Add-guards-for-_listenerController-abort-calls-in-SubgraphNode-24e6d73d365081838ca0c1d0a1734ba0)
by [Unito](https://www.unito.io)

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
2025-08-13 15:59:44 -07:00
Comfy Org PR Bot
a9c80e91d3 [backport 1.25] Bundled subgraph fixes (#4965)
Backport of #4964 to `core/1.25`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4965-backport-1-25-Bundled-subgraph-fixes-24e6d73d3650816194baeeaff87d02f1)
by [Unito](https://www.unito.io)

Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-13 13:30:18 -07:00
Comfy Org PR Bot
ccee1fa7c0 [backport 1.25] Trigger updateSelectedItems on subgraph conversion (#4956)
Backport of #4949 to `core/1.25`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4956-backport-1-25-Trigger-updateSelectedItems-on-subgraph-conversion-24e6d73d36508164ba29c52f31c092ed)
by [Unito](https://www.unito.io)

Co-authored-by: AustinMroz <austin@comfy.org>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-13 13:05:10 -07:00
Comfy Org PR Bot
3897a75621 [backport 1.25] gemini-2.5-pro and flash models; corrected prices (#4952)
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
2025-08-12 15:17:30 -07:00
Comfy Org PR Bot
e8c70545e3 [backport 1.25] pricing update for MinimaxHailuoVideo node and Kling kling-v2-1 model (#4951)
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
2025-08-12 14:46:05 -07:00
Comfy Org PR Bot
b0223187fe [backport 1.25] Implement subgraph unpacking (#4950)
Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-12 14:45:35 -07:00
Comfy Org PR Bot
ab766694e9 [backport 1.25] Add automatic trackpad / mouse sensing (#4944)
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
2025-08-12 12:14:13 -07:00
Comfy Org PR Bot
08f834b93c [backport 1.25] minimap improve (#4923)
Co-authored-by: Terry Jia <terryjia88@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-11 14:53:39 -07:00
Comfy Org PR Bot
ad3eede075 [backport 1.25] [feat] Add red styling to Remove Slot context menu option (#4921)
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-11 14:53:24 -07:00
Comfy Org PR Bot
fc294112e7 [backport 1.25] Fix subgraph reroute serialization (#4920)
Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-11 14:53:09 -07:00
Comfy Org PR Bot
bbf7b4801c [backport 1.25] [feat] Make hotkey for exiting subgraphs configurable in user keybindings (#4914)
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-11 11:45:53 -07:00
Christian Byrne
d1434d1c80 [backport 1.25] Add bounds checking for clipspace indices to prevent paste errors (core/1.25 backport) (#4904) 2025-08-10 20:57:12 -07:00
Comfy Org PR Bot
980e3ebfab [backport 1.25] Add preview to workflow tabs (#4882)
Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
2025-08-09 17:28:40 -07:00
Comfy Org PR Bot
694ff47269 [backport 1.25] Fix Alt-Click-Drag-Copy of Subgraph Nodes (#4884)
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
2025-08-09 17:28:03 -07:00
Comfy Org PR Bot
b35525578c [backport 1.25] Reorder subgraph context menu items (#4881)
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-09 17:26:24 -07:00
Comfy Org PR Bot
3def157b96 [backport 1.25] Fix execution breaks on multi/any-type slots (#4871)
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
2025-08-09 14:12:13 -07:00
Comfy Org PR Bot
1abf9a5e86 [backport 1.25] Fix Alt+click create reroute (2/2) (#4869)
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-09 13:33:36 -07:00
Comfy Org PR Bot
2d4dba3f19 [backport 1.25] Fix: Alt+click reroute creation on high-DPI displays (#4862)
Co-authored-by: Vivek Chavan <111511821+vivekchavan14@users.noreply.github.com>
2025-08-09 10:24:31 -07:00
Comfy Org PR Bot
aa9b70656e [backport 1.25] Fix disconnection from subgraph inputs (#4859)
Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-09 08:03:49 -07:00
Comfy Org PR Bot
80d54eca2f [backport 1.25] Rename subgraph widgets when slot is renamed (#4825)
Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-07 15:46:48 -07:00
Comfy Org PR Bot
a9f05bd604 [backport 1.25] Remove subgraphs from add node context menu (#4822)
Co-authored-by: AustinMroz <austin@comfy.org>
2025-08-07 15:15:37 -07:00
Comfy Org PR Bot
53f5927d4b [backport 1.25] Keyboard Shortcut Bottom Panel (#4813)
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
2025-08-07 12:15:56 -07:00
Copilot
e77411d9da Add touch screen dragging support to minimap (#4781)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: snomiao <7323030+snomiao@users.noreply.github.com>
2025-08-07 17:36:27 +08:00
AustinMroz
385c56d93d Fix widget display on subgraph nodes (#4798) 2025-08-06 23:38:07 -07:00
Christian Byrne
f3b82e377a [fix] Display dynamic keybinding in minimap tooltip (#4805) 2025-08-06 22:18:20 -07:00
Johnpaul Chiwetelu
5e9b8785a5 Scroll templates better (#4584) 2025-08-06 16:13:29 -07:00
Christian Byrne
3f290e2cbd [feat] Limit release notifications to desktop app only (#4788) 2025-08-06 12:00:52 -07:00
snomiao
6b31596399 [feat] Support Markdown rendering for node descriptions in NodePreview (#4684)
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-06 00:44:23 -07:00
Benjamin Lu
5ad9f86a58 [bugfix] Fix RefreshButton component name conflict (#4773)
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-05 23:28:15 -07:00
Benjamin Lu
b33f820b3b explicit this binding 2025-08-05 18:37:19 -04:00
Benjamin Lu
a7a4448878 prettier on executionUtil.ts 2025-08-05 18:29:42 -04:00
Benjamin Lu
85a5d1ed56 Fix inconsistent subgraphNode usage
Prior to this commit, subgraphNode inconsistently refers to either the
parent graph, or to indicate the current node is a subgraph.

This corrects the usage of subgraphNode to consistently refer to the
subgraph instance as defined in the constructor.

This solves a bug where graph serialization fails due to an incorrectly
reported infinite loop.

Port of https://github.com/Comfy-Org/litegraph.js/pull/1193
2025-08-05 18:29:05 -04:00
Benjamin Lu
01e4260d4c Fix duplicated inputs on loading nested subgraphs
Subgraphs are loaded in order of creation. Under most circumstances,
this means newer subgraphs are loaded first. With nested subgraphs, this
means a subgraph node has it's inputs connected before it's inside is
loaded. When the inner subgraph is loaded, input-added events are
triggered even though inputs already exist on the subgraph node.

This is resolved by adding a check for if an input of the corresponding
name already exists when adding an input.

Port of https://github.com/Comfy-Org/litegraph.js/pull/1192
2025-08-05 18:28:07 -04:00
Benjamin Lu
fad8dae796 Merge branch 'main' into bl-merge-lg-fe 2025-08-05 18:24:29 -04:00
Christian Byrne
88aa6e894e [docs] Enhance CLAUDE.md files with quality control guidelines (#4690)
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-05 15:22:00 -07:00
Benjamin Lu
0ce5aeb2bd eslint disable next litegraph tests 2025-08-05 18:14:47 -04:00
Benjamin Lu
a289f44263 Expect ts errors and remove litegraph test from ts exclude 2025-08-05 18:04:07 -04:00