2 Commits

Author	SHA1	Message	Date
Dante	3ac08fd1da	test(assets-sidebar): add comprehensive E2E tests for Assets browser panel (#10616) ... ## Summary - Extend `AssetsSidebarTab` page object with selectors for search, view mode, asset cards, selection footer, context menu, and folder view navigation - Add mock data factories (`createMockJob`, `createMockJobs`, `createMockImportedFiles`) to `AssetsHelper` for generating realistic test fixtures - Write 30 E2E test cases across 10 categories covering the Assets browser sidebar panel ## Test coverage added | Category | Tests | Details | |----------|-------|---------| | Empty states | 3 | Generated/Imported empty copy, zero cards | | Tab navigation | 3 | Default tab, switching, search reset on tab change | | Grid view display | 2 | Generated card rendering, Imported tab assets | | View mode toggle | 2 | Grid↔List switching via settings menu | | Search | 4 | Input visibility, filtering, clearing, no-match state | | Selection | 5 | Click select, Ctrl+click multi, footer, deselect all, tab-switch clear | | Context menu | 7 | Right-click menu, Download/Inspect/Delete/CopyJobID/Workflow actions, bulk menu | | Bulk actions | 3 | Download/Delete buttons, selection count display | | Pagination | 1 | Large job set initial load | | Settings menu | 1 | View mode options visibility | ## Context Part of [FixIt Burndown](https://www.notion.so/comfy-org/FixIt-Burndown-32e6d73d365080609a81cdc9bc884460) — "Untested Side Panels: Assets browser" assigned to @dante01yoon. ## Test plan - [ ] Run `npx playwright test browser_tests/tests/sidebar/assets.spec.ts` against local ComfyUI backend - [ ] Verify all 30 tests pass - [ ] CI green ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10616-test-assets-sidebar-add-comprehensive-E2E-tests-for-Assets-browser-panel-3306d73d365081eeb237e559f56689bf) by [Unito](https://www.unito.io)	2026-03-30 21:15:14 +09:00
Benjamin Lu	db6e5062f2	test: add assets sidebar empty-state coverage (#10595) ... ## Summary Add the first user-centric Playwright coverage for the assets sidebar empty state and introduce a small assets-specific test helper/page object surface. ## Changes - **What**: add `AssetsSidebarTab`, add `AssetsHelper`, and cover generated/imported empty states in a dedicated browser spec ## Review Focus This is intentionally a small first slice for assets-sidebar coverage. The new helper still mocks the HTTP boundary in Playwright for now because current OSS job history and input files are global backend state, which makes true backend-seeded parallel coverage a separate backend change. Long-term recommendation: add backend-owned, user-scoped test seeding for jobs/history and input assets so browser tests can hit the real routes on a shared backend. Follow-up: COM-307. Fixes COM-306 ## Screenshots (if applicable) Not applicable. ## Validation - `pnpm typecheck:browser` - `pnpm exec playwright test browser_tests/tests/sidebar/assets.spec.ts --project=chromium` against an isolated preview env ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10595-test-add-assets-sidebar-empty-state-coverage-3306d73d365081d1b34fdd146ae6c5c6) by [Unito](https://www.unito.io)	2026-03-26 21:19:38 -07:00