Alexander Brown
7b68b19f11
Component: The Rest of the PrimeVue buttons ( #7649 )
...
## Summary
Automated initial change, cleaned up manually.
Please check the screenshot changes.
Includes a11y updates to icon buttons.
Doesn't hit the buttons in Desktop.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7649-WIP-Component-The-Rest-of-the-PrimeVue-buttons-2ce6d73d365081d68e06f200f1321267 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-12-29 15:03:34 -08:00
Yourz
c99865ce7f
fix: disable the sign up and sign in button when form is invalid ( #7376 )
...
## Summary
<!-- One sentence describing what changed and why. -->
Add a disabled state to the sign-up button in the cloud onboarding
views. The button should be disabled when the form is invalid to prevent
users from submitting incomplete or incorrectly formatted information.
## Changes
- **What**: <!-- Core functionality added/modified -->
- Add disabled state to SignUp button and SignIn button when SignUp or
SignIn form is invalid.
- **Breaking**: <!-- Any breaking changes (if none, remove this line)
-->
- **Dependencies**: <!-- New dependencies (if none, remove this line)
-->
## Review Focus
<!-- Critical design decisions or edge cases that need attention -->
Changes for this notion:
https://www.notion.so/comfy-org/Implement-Disable-sign-up-button-when-form-is-invalid-in-cloud-onboarding-2c56d73d365081edbf8bf06b1f5e52e5
<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->
## Screenshots (if applicable)
Sign In button
Before(button not disabled when email is invalid)
After
<!-- Add screenshots or video recording to help explain your changes -->
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7376-fix-disable-the-sign-up-and-sign-in-button-when-form-is-invalid-2c66d73d36508139af44cd7cb1e1aeb9 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-12-11 07:47:41 -07:00
Yourz
a65e63a322
fix: throttle sign-up and sign-in button ( #7358 )
...
## Summary
<!-- One sentence describing what changed and why. -->
Throttle signup button to prevent duplicate Firebase accounts
## Changes
- **What**: <!-- Core functionality added/modified -->
- Add throttle to SignUp Button in SignUpForm component
- Add throttle to SignIn Button in SignInForm component
- Add loading state to SignUp Button in SignUpForm component
## Review Focus
related to this Notion page:
https://www.notion.so/comfy-org/Implement-Throttle-signup-button-to-prevent-duplicate-Firebase-accounts-2c46d73d36508193a8d1fb5146674956
<!-- Critical design decisions or edge cases that need attention -->
<!-- If this PR fixes an issue, uncomment and update the line below -->
<!-- Fixes #ISSUE_NUMBER -->
## Screenshots (if applicable)
<!-- Add screenshots or video recording to help explain your changes -->
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7358-fix-throttle-sign-up-and-sign-in-button-2c66d73d365081278f4dde0f34d60153 )
by [Unito](https://www.unito.io )
2025-12-11 05:48:22 -07:00
Christian Byrne
b1439be7f0
remove checkbox from sign up form ( #6269 )
...
## Summary
Removes the checkbox from the sign up form to simplify the user
experience. The "By clicking 'Next' or 'Sign Up'..." notice at the
bottom already covers terms and privacy.
## Changes
- Removed checkbox field from sign up schema
- Updated `SignUpForm.vue` component
- Removed unused `Checkbox` import
## Before/After
**Before:**
Sign up form included a checkbox that users had to check before
submitting
**After:**
Sign up form is cleaner without the checkbox. The existing notice text
covers the same information:
> "By clicking 'Next' or 'Sign Up', you agree to our Terms of Use and
Privacy Policy."
This notice appears on both sign in and sign up modals.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6269-remove-checkbox-from-sign-up-form-2976d73d3650819ab480e4db6685baee )
by [Unito](https://www.unito.io )
2025-10-24 19:21:16 -07:00
Alexander Brown
b943c0fa75
Lint: Add tailwind linter ( #5984 )
...
## Summary
Adds the [tailwind lint
plugin](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#eslint-plugin-tailwindcss )
and fixes the currently fixable rules ([v4 is still in
beta](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#about-tailwind-css-4-support )).
## Changes
- **What**: Enforces things like consistent class order, and eventually
can prohibit extra classes that could be utilities instead
- **Dependencies**: The plugin and its types
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5984-Lint-Add-tailwind-linter-2866d73d365081d89db0d998232533bb )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-08 19:39:14 -07:00
Alexander Brown
874ef3ba0c
Lint: Add eslint import plugin ( #5955 )
...
## Summary
Adds the linter, turns on the recommended and a few extra rules, fixes
existing violations.
Doesn't prohibit `../../...` imports yet, that'll be it's own PR.
## Changes
- **What**: Consistent and fixable imports
- **Dependencies**: The plugin and parser
## Review Focus
How do you feel about the recommended rules?
What about the extra ones?
[Any
more](https://github.com/un-ts/eslint-plugin-import-x?tab=readme-ov-file#rules )
you'd want to turn on?
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5955-Lint-Add-eslint-import-plugin-2856d73d3650819985c0fb9ca3fa94b0 )
by [Unito](https://www.unito.io )
2025-10-07 20:31:00 -07:00
Alexander Brown
08220d50d9
Lint: Turn on rules that should allow for verbatimModuleSyntax ( #5616 )
...
* lint: turn on type import rules setting up for verbatimModuleSyntax
* lint: --fix for type imports
2025-09-16 22:03:41 -07:00
Chenlei Hu
834d5820d2
[Auth] Allow change password in user panel ( #3699 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-04-30 16:12:57 -04:00
Benjamin Lu
35f0551244
Personal Data Consent Checkbox ( #3697 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-04-30 10:29:46 -04:00
Chenlei Hu
9935b322f0
[API Nodes] Signin/Signup dialog ( #3466 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-04-15 17:37:53 -04:00
