Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-01-26 19:09:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,102 Commits 554 Branches 524 Tags
4e22bffae2dda2ea20bcd071e4fbcc3b15cc76f8
Commit Graph

200 Commits

Author SHA1 Message Date
Chenlei Hu
4c48241e19 Update litegraph 0.8.33 (#1632) 
* chore: update litegraph to 0.8.33

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-21 14:57:21 -05:00
Chenlei Hu
6352cd86ee Show confirm dialog on workflow path conflict (Save As) (#1590) 
* Show confirm dialog on workflow path conflict (Save As)

* Fix closeworkflow

* nit

* Add playwright tests

* nit

* nit

* Move workflows dir cleanup
 2024-11-18 23:07:24 -05:00
filtered
7e245ba1cf Update Litegraph: Canvas Pointer (#1556) 
* Litegraph: canvas.pointer

Clear @ts-expect-error

Fix exception thrown on slot double-click

Long-standing bug but has no real impact in prod - just logs an error.
Required for new connecting_link features.

Add settings: CanvasPointer options

Update litegraph 0.8.28

Fix regression in snap to grid render

Fix snap to grid marker always on

Update snap to grid to use Positionable API

Fix test clicks registering as double-click

Improve test precision

Current test proves it has changed to something smaller.
New test proves it is exactly what was specified.
Will need refinement when a limit is put on latent width.

Fix test expects collapse node to select node

Remove redundant code

Resolved by CanvasPointer

Fix flaky test - ContextMenu

Fix settings group

* Update litegraph

* Remove snapToGrid extension

* Update test expectations [skip ci]

---------

Co-authored-by: huchenlei <huchenlei@proton.me>
Co-authored-by: github-actions <github-actions@github.com>
 2024-11-18 10:50:51 -05:00
Chenlei Hu
71e4a42cfe Only persist workflow on workflow change/switch (#1576) 
* Only persist workflow on workflow change/switch

* nit

* Add playwright test

* Add modify test

* nit

* Fix playwright tests

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-17 14:13:52 -05:00
Chenlei Hu
b4352bcd8d Fix node search box filter test (#1561) 2024-11-15 21:18:19 -05:00
Chenlei Hu
39bab9d9e2 Disable flaky group node test (#1560) 2024-11-15 20:55:18 -05:00
Chenlei Hu
82b4547d7d Remove canvas border rendering (#1549) 
* Remove canvas border rendering

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-15 09:24:51 -05:00
filtered
7e0d1d441d Flaky tests and observable state (#1526) 
* Fix missing await

* Fix flaky tests - keyboard combos

Old code is causing playwright &/ changeTracker to add an undo step.  Using combo mode resolves flakiness until that can be investigated thoroughly.

* Restore skipped tests

* Fix flaky tests

* Async clean up

* Fix test always fails on retry

* Add TS types (tests)

* Fix flaky test

* Add observable busy state to workflow store

* Add workflow store busy wait to tests

* Rename test for clarity

* Fix flaky tests - use press() from locator API

Ref: https://playwright.dev/docs/api/class-keyboard#keyboard-press

* Fix flaky test - wait next frame

* Add delay between mouse events

Litegraph pointer handling is all custom coded, so a adding a delay between events for a bit of reality is actually beneficial.
 2024-11-13 09:35:22 -05:00
Chenlei Hu
8236163fea Enable New UI by default (#1515) 
nit

Add playwright test

nit

nit

nit
 2024-11-12 10:48:26 -05:00
filtered
59b555b448 Fix multiline text input alignment & clipping (#1513) 
* Simplify multiline widget scaling

* Fix multiline widget clipping

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-12 10:38:03 -05:00
Chenlei Hu
73bdbddf90 Fix rename open/bookmark workflow (#1507) 
* Fix rename open/bookmark workflow

* nit

* Fix save as

* Add browser test
 2024-11-11 11:06:41 -05:00
Chenlei Hu
58ad01adfe Reland "Re-enable multiple-undo test" (#1499) 
* Revert "Revert "Re-enable multiple-undo test (#1483)" (#1498)"

This reverts commit 5f1a9659e9.

* nit
 2024-11-10 12:59:19 -05:00
Chenlei Hu
5f1a9659e9 Revert "Re-enable multiple-undo test (#1483)" (#1498) 
This reverts commit 6c6c356c78.
 2024-11-10 11:53:55 -05:00
Chenlei Hu
6c6c356c78 Re-enable multiple-undo test (#1483) 
* Re-enable multiple-undo test

* nit
 2024-11-10 10:57:15 -05:00
Chenlei Hu
4617e0fb1a Fix node badge on unknown color palette (#1487) 
* Fix node badge on unknown color palette

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-09 10:55:25 -05:00
Chenlei Hu
f8ec87ddea Fix changeTracker modified state (#1481) 
* Add jsondiffpatch

* Add logs

* Add graphDiff helper

* Fix changeTracker

* Add loglevel

* Add playwright test

* Fix jest test

* nit

* nit

* Fix test url

* nit
 2024-11-08 22:24:35 -05:00
Chenlei Hu
acbc38ced4 Revert "Enable New UI by default (#1460)" (#1476) 
This reverts commit f0b735f3dd.
 2024-11-08 16:35:52 -05:00
Chenlei Hu
f0b735f3dd Enable New UI by default (#1460) 
* Enable New UI by default

* nit

* Add playwright test

* nit

* nit

* nit
 2024-11-07 17:55:53 -05:00
Chenlei Hu
073638672d Fix ('STRING',) input node (#1457) 
* Fix ('STRING',) input node

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-07 13:03:54 -05:00
Chenlei Hu
d1738b50d2 Update litegraph (Remove hardcode +1 size) (#1438) 
* Update litegraph (Remove hardcode +1 size)

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-05 19:07:38 -05:00
Chenlei Hu
c560628f1f [Extension API] Register about panel badge (#1436) 
* Custom about panel badge

* Add playwright test

* Update README

* nit

* nit

* nit

* nit
 2024-11-05 19:06:38 -05:00
Chenlei Hu
c56533bb23 Workflow Management Reworked (#1406) 
* Merge temp userfile

Basic migration

Remove deprecated isFavourite

Rename

nit

nit

Rework open/load

Refactor save

Refactor delete

Remove workflow dep on manager

WIP

Change map to record

Fix directory

nit

isActive

Move

nit

Add unload

Add close workflow

Remove workflowManager.closeWorkflow

nit

Remove workflowManager.storePrompt

move from commandStore

move more from commandStore

nit

Use workflowservice

nit

nit

implement setWorkflow

nit

Remove workflows.ts

Fix strict errors

nit

nit

Resolves circular dep

nit

nit

Fix workflow switching

Add openworkflowPaths

Fix store

Fix key

Serialize by default

Fix proxy

nit

Update path

Proper sync

Fix tabs

WIP

nit

Resolve merge conflict

Fix userfile store tests

Update jest test

Update tabs

patch tests

Fix changeTracker init

Move insert to service

nit

Fix insert

nit

Handle bookmark rename

Refactor tests

Add delete workflow

Add test on deleting workflow

Add closeWorkflow tests

nit

* Fix path

* Move load next/previous

* Move logic from store to service

* nit

* nit

* nit

* nit

* nit

* Add ChangeTracker.initialState

* ChangeTracker load/unload

* Remove app.changeWorkflow

* Hook to app.ts

* Changetracker restore

* nit

* nit

* nit

* Add debug logs

* Remove unnecessary checkState on graphLoad

* nit

* Fix strict

* Fix temp workflow name

* Track ismodified

* Fix reactivity

* nit

* Fix graph equal

* nit

* update test

* nit

* nit

* Fix modified state

* nit

* Fix modified state

* Sidebar force close

* tabs force close

* Fix save

* Add load remote workflow test

* Force save

* Add save test

* nit

* Correctly handle delete last opened workflow

* nit

* Fix workflow rename

* Fix save

* Fix tests

* Fix strict

* Update playwright tests

* Fix filename conflict handling

* nit

* Merge temporary and persisted ref

* Update playwright expectations

* nit

* nit

* Fix saveAs

* Add playwright test

* nit
 2024-11-05 11:03:27 -05:00
Chenlei Hu
16f2e56d8e Handle errors from top action menu commands (#1432) 2024-11-04 22:50:19 -05:00
Chenlei Hu
2161ae4e5b Pin selected items (Nodes + Groups) (#1427) 
* Pin selected items (Nodes + Groups)

* Update litegraph

* Add playwright test

* nit

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-11-04 17:36:33 -05:00
filtered
3ba776e6ca Add Litegraph multi-select & group nesting (#1416) 
* Allow nested groups

Pass all selected items (new litegraph feature) instead of just selected nodes.

* Allow nested groups - context menus

* Update litegraph

* Update litegraph (Select all / Delete selected)

* Add playwright test

* nit

* Update test expectations [skip ci]

---------

Co-authored-by: huchenlei <huchenlei@proton.me>
Co-authored-by: github-actions <github-actions@github.com>
 2024-11-03 18:08:42 -05:00
filtered
27bacc36d4 Update tests with precise node positions / sizes (#1408) 
* Update tests with precise node positions / sizes

* Fix test flakiness - missing await

* Fix test failures - async not awaited

* Update action

* Update test expectations [skip ci]

---------

Co-authored-by: huchenlei <huchenlei@proton.me>
Co-authored-by: github-actions <github-actions@github.com>
 2024-11-03 10:42:54 -05:00
Chenlei Hu
dd86417177 Disable flaky test on missing model download dialog (#1409) 2024-11-03 09:04:18 -05:00
filtered
caa3ac2068 Add playwright concurrency - multi-user mode (#1400) 
* Add playwright concurrency - multi-user mode

* Add extra server params

* nit

* Update to v2.1 action

---------

Co-authored-by: huchenlei <huchenlei@proton.me>
 2024-11-02 09:51:24 -04:00
Chenlei Hu
94f4147f92 Fix double trigger of setting onChange callback (#1385) 
* Fix onChange double trigger

* nit

* Add playwright test
 2024-10-30 19:55:46 -04:00
Chenlei Hu
bf7a9bf5eb Update litegraph (link snap to slot & highlight) (#1378) 
* Update litegraph (link snap)

* Add settings

* nit

* Add playwright test

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-10-30 15:23:58 -04:00
Chenlei Hu
35fab0bef3 Focus mode (#1365) 
* Menu hamburger

* Focus

* nit

* nit

* nit

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-10-29 17:25:18 -04:00
Chenlei Hu
8dddffe840 Use browser download in missing model dialog (#1362) 
* Remove custom backend download logic

* Add download hooks

* Download button

* Use browser download

* Update test
 2024-10-29 14:07:16 -04:00
Chenlei Hu
10f43be911 Remove show model folder checkbox in missing model dialog (#1358) 
* Remove show model folder checkbox in missing model dialog

* nit

* nit
 2024-10-29 10:15:31 -04:00
Chenlei Hu
997b5ee819 Update litegraph (Fix group select) (#1342) 
* Update litegraph (Fix group select)

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-10-27 22:05:18 -04:00
Chenlei Hu
82c369322d Handle invalid node def errors (#1340) 
* nit

* Add error handling

* nit

* nit
 2024-10-27 20:07:05 -04:00
Chenlei Hu
546c5dabc8 Update litegraph (Slot highlight) (#1339) 
* Update litegraph (Slot highlight)

* Disable tooltip setting in playwright tests

* Update test expectations [skip ci]

---------

Co-authored-by: github-actions <github-actions@github.com>
 2024-10-27 19:31:22 -04:00
Chenlei Hu
25457d31d4 Revert "Fix playwright test on settings API (#1303)" (#1310) 
This reverts commit 54e833502a.
 2024-10-25 12:09:50 -04:00
Chenlei Hu
4f9dc830b6 Setup clean setting state before every playwright test (#1309) 
* Use reload

* setting setup

* nit

* Remove setting cleanups

* Wait for frame

* nit

* nit
 2024-10-25 11:25:17 -04:00
Chenlei Hu
16ebfd6171 Fix import of NodeReference in ComfyPage (#1306) 2024-10-25 08:32:12 -04:00
Chenlei Hu
59c999324e Split ComfyPage fixture (#1305) 
* Split down page components

* Move litegraph utils

* nit
 2024-10-25 08:29:02 -04:00
Chenlei Hu
624bcc75ab Move ComfyPage to fixtures folder (#1304) 2024-10-25 08:01:50 -04:00
Chenlei Hu
54e833502a Fix playwright test on settings API (#1303) 2024-10-25 07:53:23 -04:00
Chenlei Hu
957a767ed0 New settings API (#1292) 
* Add settings API

* Add playwright test

* Update README
 2024-10-24 10:26:01 -04:00
AustinMroz
014c3f3172 Fix load workflow with converted widget (#1222) 
f74973 introduced a regression where a node which has had an input
added, will clobber a converted input of in a workflow created before
the input was added.

The prior behaviour was also incorrect (the new input would not exist on
the node), but would often be runnable.

Keeping the position of the converted widget and adding the new input to
the end is an unfortunate compromise. Doing it the other way around
breaks primitive nodes
 2024-10-11 12:20:03 -04:00
Chenlei Hu
ec8e6f79b3 Fix create group node command error states (#1209) 
* Fix edge cases

* Add playwright test

* nit
 2024-10-10 15:56:00 -04:00
bymyself
fabcbaec82 Restore backend state when Playwright test finishes (#1168) 
* Restore backend state when Playwright test finishes. Resolve #1094

* Add warning when env var not set

* Rename and replace with scaffolding option for models dir

* Rename

* Define another env var [skip ci]

* Fix paths [skip ci]

* Update README.md

---------

Co-authored-by: Chenlei Hu <huchenlei@proton.me>
 2024-10-09 15:05:19 -04:00
bymyself
bf80340310 Add test on settings visibility on mobile (#1164) 
* Add test on settings dialog visibility on mobile

* Consolidate settings-dialog tests

* Simplify zoom speed setting tests
 2024-10-08 09:43:16 -04:00
bymyself
62be958d47 Add tests on node multi-select (#1163) 2024-10-08 09:11:22 -04:00
Chenlei Hu
f8343d0f93 Fix flaky playwright test (#1152) 2024-10-07 17:11:20 -04:00
bymyself
9cbfc9856b Fix widget/input conversion on text widgets (#1129) 
* Support converting dynamically created text widgets to input

* Fix array contains

* Add test wait

* Try to fix test only failing in CI

* Fix test: Disable conversion option nesting in contextmenu
 2024-10-07 11:22:28 -04:00