Chenlei Hu
c5db2d8736
[Bug] Fix number widget range not enforced ( #850 )
...
Resolves https://github.com/Comfy-Org/ComfyUI_frontend/issues/3204
2025-03-24 15:37:55 -04:00
filtered
a26a5c9a87
[Refactor] Prefer param destructuring over manual ( #756 )
...
- Replaces manual runtime destructuring with built-in param
destructuring
- Standardises naming
- Reorders deprecated code
2025-03-11 18:19:56 +00:00
filtered
a7f2ff16a9
[TS] Remove optional from widget y and type ( #752 )
...
- Fixes widget `type` marked as optional - it is required
- Fixes widget `y` marked as optional - now initialised to 0
2025-03-11 15:46:10 +00:00
filtered
af7db40fce
[chore] Clean up ignores after strict mode enabled ( #680 )
...
- Replaces all `ts-ignore` with `ts-expect-error`
- Resolves https://github.com/Comfy-Org/litegraph.js/issues/578
2025-03-02 14:56:15 +00:00
Miguel C
5721b1c27c
[Refactor] Fix step calculation in Knob Widget ( #651 )
...
Removes a stray console.log and fixes the step calculation.
2025-03-01 23:36:55 +11:00
filtered
b36bf3d4a2
[CodeHealth] Apply modern standards to LGraphCanvas ( #650 )
...
- Prefer template string
- Prefer explicit throw to undefined TypeError
- Remove unnecessary `this` assignment
2025-02-28 22:08:23 +00:00
Chenlei Hu
c66ca2ae66
Remove magic 10% scale on numeric widget step ( #643 )
...
There are external code still dependent on the fact that
Widget.options.step is scaled 10x, so the 10x-ed value is still kept
there, while we use the new unscaled step2 within our code now.
Ref:
https://cs.comfy.org/search?q=context:global+%22step+/+10%22&patternType=keyword&sm=0
2025-02-27 16:23:53 -05:00
filtered
97bf9de83a
[Refactor] Standardise code style - modern JS ( #636 )
...
Uses unicorn rules to auto-refactor code. All verified.
2025-02-27 13:13:32 +00:00
filtered
1e8938ceff
Add unicorn lint rules - DOM built-in functions ( #628 )
...
- Prefer append(), remove(), replaceAll()
- Wrap nested ternaries in parenthesis
2025-02-27 09:18:25 +00:00
filtered
6f51767451
Add ESLint unicorn plugin ( #627 )
...
Rules disabled by default to allow incremental integration.
2025-02-27 08:41:51 +00:00
Miguel C
fbcc396880
Knob ( #600 )
...
Resolved issues with history due to merges, opened a new pull request.
A more visual widget that the usual number/slider. Differentiates itself
from the functionality of a slider by not setting the value on click,
only stepping, emulating an actual knob.
- Left/Right takes 1 step at a time
- Up/Down moves 1% or 1 step, whichever is larger
- Move + Shift moves by 10% or 1 step, whichever is larger
This also includes a fixes to some size logic.
- [x] ~~Still missing being able to drag the knob itself, as the
clicking of the widget is not recognized if it's outside of where a
normal height widget would be.~~
2025-02-26 15:07:32 -05:00
Chenlei Hu
963e4b0904
[Type] Mark name as required prop for IBaseWidget ( #623 )
2025-02-26 15:03:31 -05:00
filtered
3040924d76
[TS] Use strict mode in CanvasPointer, measure, and polyfills ( #617 )
...
- Adds runtime type guard
- Adds ts-ignore that must be removed later
* [ ] #578
2025-02-26 13:05:40 +00:00
filtered
5cdd0581fa
Add import / export sort rules ( #612 )
...
- Adds ESLint package
- Applies import/export rules to all files
- Uses newline delineated grouping, with type-only imports first
2025-02-26 09:21:33 +00:00
filtered
9ded97d189
[Doc] Add JSDoc linter & general comment clean up ( #611 )
...
- Prefer comments above lines over end-of-line comments
- Makes auto-formatting easier
- Subjective, but it is generally easier to read in JS
- Standardises JSdoc format
- Auto-fixes for many issues (applies on save w/ESLint extension)
2025-02-26 08:54:18 +00:00
Chenlei Hu
59dea644f2
Move marker property from BaseWidget to SliderWidget ( #584 )
...
* Move marker property from BaseWidget to SliderWidget
* nit
2025-02-24 16:35:34 -05:00
Chenlei Hu
170341db73
Type ButtonWidget ( #583 )
...
* Type ButtonWidget
* nit
2025-02-24 16:30:04 -05:00
filtered
b67f34e7f3
[Cleanup] Remove lint bypass, remove unused vars ( #554 )
2025-02-20 11:17:35 +11:00
Chenlei Hu
f0eca030c4
[BugFix] Trigger IWidget.callback on widget drag ( #514 )
2025-02-10 14:37:16 -05:00
Chenlei Hu
4d36369cd8
Refactor widget switch statement ( #491 )
2025-02-08 19:28:38 -05:00
Chenlei Hu
cdaceebcaa
Implement SliderWidget ( #485 )
2025-02-08 17:28:25 -05:00
Chenlei Hu
2d688a896d
Implement TextWidget ( #484 )
2025-02-08 17:01:54 -05:00
Chenlei Hu
ab14827f87
Implement ButtonWidget ( #483 )
2025-02-08 16:50:02 -05:00
Chenlei Hu
63f9f30eec
Implement NumberWidget ( #481 )
2025-02-08 15:45:23 -05:00
Chenlei Hu
c781053bd2
Implement ComboWidget ( #480 )
...
* wip
* Implement onClick
2025-02-08 15:16:15 -05:00
Chenlei Hu
fcc09c075d
Implement BooleanWidget.onClick ( #479 )
2025-02-08 12:45:51 -05:00
Chenlei Hu
75f067dbb3
Implement BooleanWidget ( #466 )
...
* Implement BooleanWidget
* Merge function of addWidget
* Class conversion
* nit
2025-02-07 17:10:30 -05:00
