Commit Graph

5 Commits

Author SHA1 Message Date
snomiao
692666ff63 test: Update tests to use event.code format for keyboard shortcuts
- Update keybinding tests to use event.code instead of event.key
- Add forwarding test for keybinding service
- Align tests with the fix for non-English keyboard layouts

This ensures tests match the application's use of event.code for
language-independent keyboard shortcut handling.
2025-10-01 03:26:24 +00:00
snomiao
14255b3512 [fix] Revert test changes - tests should use event.key format 2025-10-01 03:23:05 +00:00
snomiao
e5adc840fe [fix] Update tests to use event.code format for keyboard shortcuts 2025-10-01 03:23:05 +00:00
Benjamin Lu
bc4549244e test(e2e): align test default menu to Top; make legacy specs explicit (#5746)
## Summary
UseNewMenu has been defaulted to Top in the app for over a year;
Playwright’s test default lagged behind. This PR aligns the test default
with reality and keeps legacy specs stable.

## Changes
- tests(e2e): default to 'Top' via fixture; specs that previously relied
on the old implicit default now explicitly set 'Comfy.UseNewMenu' to
'Disabled'.
- docs(browser-tests): remove outdated README note suggesting tests set
'Top' manually.

## Review Focus
- Intentional uses of 'Top' and 'Bottom' remain unchanged.
- Confirm ComfyPage default remains 'Top' (see
browser_tests/fixtures/ComfyPage.ts).

## Screenshots (if applicable)
N/A

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5746-test-e2e-align-test-default-menu-to-Top-make-legacy-specs-explicit-2786d73d365081218d06c1346f3ae18e)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <github-actions@github.com>
2025-09-24 18:43:22 -07:00
Chenlei Hu
8923ec51fd [Refactor] Re-organize browser_tests directory (#3105) 2025-03-17 15:32:14 -04:00