Commit Graph

2 Commits

Author SHA1 Message Date
Glary-Bot
e9ac55af59 test: add failing tests for DynamicCombo text preview inside subgraphs
Adds regression tests demonstrating that V3 DynamicCombo widget
serialization breaks when nodes are packed into subgraphs. The
serializeValue callback is lost during subgraph conversion, causing
sampling_mode to serialize as the raw string 'on' instead of the
expected {sampling_mode: 'on', temperature: 0.7, top_k: 64} object.

This reproduces the bug where TextGenerateLTX2Prompt -> PreviewAny
text preview fails inside subgraphs.

Tests:
- Unit: graphToPrompt DynamicCombo serialization at top level (pass)
  and inside subgraph (intentional fail)
- E2E: DynamicCombo text preview at top level and inside subgraph
- Devtools: Mock V3 DynamicCombo node for CI testing (no model needed)
2026-04-19 09:17:13 +00:00
Christian Byrne
14c07fd734 [refactor] reorganize devtools test nodes into modules (#6020)
## Summary

Refactored monolithic devtools node definitions into organized module
structure for better maintainability and separation of concerns.

## Changes

- **What**: Split 700+ line `dev_nodes.py` into modular structure under
`tools/devtools/nodes/` with categorized files: `errors.py`,
`inputs.py`, `models.py`, `remote.py`
- **Dependencies**: None

## Review Focus

Module import structure and ensure all node registrations are properly
preserved in the consolidated mappings.

**Before:**
```
tools/devtools/
├── __init__.py
└── dev_nodes.py (738 lines)
```

**After:**
```
tools/devtools/
├── __init__.py
├── dev_nodes.py (65 lines - imports only)
└── nodes/
    ├── __init__.py (consolidated mappings)
    ├── errors.py (error/debug nodes)
    ├── inputs.py (input/widget nodes)
    ├── models.py (model/patch nodes)
    └── remote.py (remote/combo nodes)
```

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6020-refactor-reorganize-devtools-test-nodes-into-modules-2896d73d365081e89efef7e88ca8fee3)
by [Unito](https://www.unito.io)
2025-10-11 15:29:29 -07:00