Commit Graph

2 Commits

Author SHA1 Message Date
jaeone94
2edd60c796 fix: address CodeRabbit review — bug fixes, test hardening, code quality
- Fix focusedErrorNodeId watch collapsing non-execution groups (#10085)
- Fix missingNodeCount always returning 0/1 instead of actual count
- Add ShowErrorsTab setting to useNodeErrorFlagSync watch sources
- Guard rootGraph.serialize() with try/catch, use const declarations
- Deduplicate cancelled guard in useErrorReport
- Await initial systemStats loading before refetching
- Fix mock return type null → undefined in missingNodeScan test
- Update stale doc comments referencing executionErrorStore
- Strengthen test assertions: onWidgetChanged restoration, runtime
  error uniqueness, missing-node title verification, fallback logs
2026-03-20 20:58:00 +09:00
jaeone94
9f3cacfd78 fix: address review findings — cleanup hooks, store placement, code quality
- Fix per-node callback restoration on cleanup in useErrorClearingHooks
- Add unmount cancellation guard to useErrorReport async onMounted
- Move missingNodesErrorStore to platform/nodeReplacement (DDD alignment)
- Extract activeMissingNodeGraphIds to component-level computed
- Extract useErrorActions composable (deduplicate telemetry+command pattern)
- Add data-testid to copy button, use in test selector
- Add tests for onNodeRemoved restoration and double-install guard
- Return watch stop handle from useNodeErrorFlagSync
- Add asyncResolvedIds eviction on missingNodesError reset
- Add console.warn to silent catch blocks and empty array guard
- Hoist useCommandStore to setup scope, fix floating promises
- Replace replace() with replaceAll() in testid expression
- Convert function expression to declaration in FindIssueButton
2026-03-20 20:00:31 +09:00