Christian Byrne
76bd9ab43e
[don't port to main] fix: Enable Playwright tests on rh-test by skipping cloud auth guard ( #6283 )
...
## Problem
All Playwright tests on rh-test were failing due to cloud-specific
initialization blocking test execution:
1. Firebase auth guard waits 16 seconds for auth initialization,
exceeding test timeout (15s)
2. Remote config fetch blocks on /api/features endpoint
3. Snapshot images outdated - rh-test has old snapshots while main UI
evolved
## Solution
**Skip cloud auth guard** (src/router.ts)
- Add `if (!isCloud) return next()` at start of router.beforeEach
- Playwright builds with DISTRIBUTION='localhost', bypassing the guard
- Safe since guard is cloud-only (Firebase, login pages, onboarding)
**Mock /api/features endpoint** (browser_tests/fixtures/ComfyPage.ts)
- Try real backend first, fallback to empty config
- Prevents initialization hang when endpoint unavailable
- Preserves explicit featureFlags.spec.ts test functionality
**Update snapshots from main**
- Pulled 33 snapshot files from main branch
- Fixes snapshot mismatches caused by UI evolution on main
- Includes 3 new snapshots (recordAudio, bypass/mute states)
## Impact
- Playwright tests can now initialize and run on rh-test
- Cloud functionality unchanged (fixes only affect
DISTRIBUTION='localhost')
- No production behavior changes
2025-10-25 21:50:27 -07:00
Arjan Singh
0239a83da2
Update rh-test (as of 2025-10-11) ( #6044 )
...
## Summary
Tested these changes and confirmed that:
1. Feedback button shows.
2. You can run workflows and switch out models.
3. You can use the mask editor. (thank you @ric-yu for helping me
verify).
## Changes
A lot, please see commits.
Gets us up to date with `main` as of 10-11-2025.
---------
Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: snomiao <snomiao@gmail.com >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: DrJKL <DrJKL@users.noreply.github.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Marwan Ahmed <155799754+marawan206@users.noreply.github.com >
Co-authored-by: DrJKL <DrJKL0424@gmail.com >
Co-authored-by: Rizumu Ayaka <rizumu@ayaka.moe >
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com >
Co-authored-by: AustinMroz <4284322+AustinMroz@users.noreply.github.com >
Co-authored-by: Austin Mroz <austin@comfy.org >
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com >
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: Benjamin Lu <benceruleanlu@proton.me >
Co-authored-by: Jin Yi <jin12cc@gmail.com >
Co-authored-by: Robin Huang <robin.j.huang@gmail.com >
2025-10-14 15:59:26 -07:00
Arjan Singh
5869b04e57
Merge main (as of 10-06-2025) into rh-test ( #5965 )
...
## Summary
Merges latest changes from `main` as of 10-06-2025.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5965-Merge-main-as-of-10-06-2025-into-rh-test-2856d73d3650812cb95fd8917278a770 )
by [Unito](https://www.unito.io )
---------
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Benjamin Lu <benceruleanlu@proton.me >
Co-authored-by: Terry Jia <terryjia88@gmail.com >
Co-authored-by: snomiao <snomiao@gmail.com >
Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com >
Co-authored-by: Jake Schroeder <jake.schroeder@isophex.com >
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com >
Co-authored-by: AustinMroz <4284322+AustinMroz@users.noreply.github.com >
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com >
Co-authored-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: Alexander Brown <DrJKL0424@gmail.com >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com >
Co-authored-by: Rizumu Ayaka <rizumu@ayaka.moe >
Co-authored-by: JakeSchroeder <jake@axiom.co >
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: DrJKL <DrJKL@users.noreply.github.com >
Co-authored-by: ComfyUI Wiki <contact@comfyui-wiki.com >
2025-10-08 19:06:40 -07:00
bymyself
ff0c15b119
merge main into rh-test
2025-09-28 15:33:29 -07:00
Christian Byrne
78c8dc3886
[ci] Trigger CI action ( #5157 )
...
* [ci] Trigger CI action
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-08-21 13:09:39 -07:00
Christian Byrne
7972550f6b
[fix] Fix link deletion from middle button when connected to reroute nodes deletes wrong link ( #4928 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-11 19:26:37 -07:00
Christian Byrne
5cc269eff1
Fix Alt+click create reroute (2/2) ( #4863 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-09 11:13:37 -07:00
filtered
8457768a41
[Test] Update test expectations to match core changes to scheduler ( #4293 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-06-28 21:58:31 -07:00
Comfy Org PR Bot
6a3cf9e698
[chore] Update litegraph to 0.15.0 ( #3759 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-05-06 18:54:33 +10:00
Comfy Org PR Bot
f7e4ed23d7
[chore] Update litegraph to 0.14.6 ( #3717 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-05-01 16:19:35 -04:00
Comfy Org PR Bot
25136cc63d
[chore] Update litegraph to 0.14.3 ( #3660 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-04-27 21:01:29 -04:00
Benjamin Lu
bf757c11ef
Reland "Add unified sidebar width setting" ( #3611 )
...
Co-authored-by: Benjamin Lu <templu1107@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2025-04-24 17:45:25 -04:00
Chenlei Hu
58dec5ea42
Add reroute migration toast ( #3286 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-03-30 21:48:10 -04:00
Chenlei Hu
564c4d557f
Migrate legacy reroute to litegraph native reroute ( #3151 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-03-22 18:56:35 -04:00
Comfy Org PR Bot
eae538b08e
[chore] Update litegraph to 0.11.0-2 ( #3193 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-03-23 08:01:25 +11:00
Chenlei Hu
8923ec51fd
[Refactor] Re-organize browser_tests directory ( #3105 )
2025-03-17 15:32:14 -04:00