Christian Byrne
aa5a8fcb95
[backport rh-test] remove auth service worker (rh-test) ( #6296 )
...
## Summary
- remove auth service worker bundle and registration code
- drop config ignores referencing removed assets
## Testing
- lint-staged (eslint, prettier)
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6296-backport-rh-test-remove-auth-service-worker-rh-test-2986d73d36508118b8cdf1472577175f )
by [Unito](https://www.unito.io )
2025-10-25 23:56:26 -07:00
bymyself
718655ae65
[bugfix] clean up service worker - use mode: no-cors for GCS fetch
...
Use mode: 'no-cors' when fetching GCS URL to avoid CORS errors.
GCS doesn't have CORS headers, but we don't need to read the response
anyway - opaque response works fine for images/videos/audio.
Removed debug console.log statements.
2025-10-25 00:54:28 -07:00
Comfy Org PR Bot
3954ac8584
[backport rh-test] [bugfix] add mode: no-cors to fix CORS error when following GCS redirects ( #6278 )
...
Backport of #6277 to `rh-test`
Automatically created by backport workflow.
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2025-10-24 23:12:18 -07:00
Comfy Org PR Bot
71e851acfa
[backport rh-test] [bugfix] fix service worker opaqueredirect error and ensure SW controls page before mount ( #6276 )
...
Backport of #6275 to `rh-test`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6276-backport-rh-test-bugfix-fix-service-worker-opaqueredirect-error-and-ensure-SW-control-2976d73d365081df8292f69e00f43e9a )
by [Unito](https://www.unito.io )
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2025-10-24 22:56:41 -07:00
Comfy Org PR Bot
bed58a09c0
[backport rh-test] [bugfix] fix auth service worker to handle cross-origin redirects to GCS ( #6268 )
...
Backport of #6265 to `rh-test`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6268-backport-rh-test-bugfix-fix-auth-service-worker-to-handle-cross-origin-redirects-to-G-2976d73d365081aba256c59948d0bf39 )
by [Unito](https://www.unito.io )
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2025-10-24 18:42:42 -07:00
Christian Byrne
648190bf65
[backport rh-test] add service worker on cloud distribution to attach auth header to browser native /view requests ( #6139 ) ( #6259 )
...
## Summary
Backport of #6139 to `rh-test` branch.
Added Service Worker to inject Firebase auth headers into browser-native
`/api/view` requests (img, video, audio tags) for cloud distribution.
## Changes
- **What**: Implemented [Service
Worker](https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API )
to intercept and authenticate media requests that cannot natively send
custom headers
- **Dependencies**: None (uses native Service Worker API)
## Implementation Details
**Tree-shaking**: Uses compile-time `isCloud` constant - completely
removed from localhost/desktop builds (verified via bundle analysis).
**Caching**: 50-minute auth header cache with automatic invalidation on
login/logout to prevent redundant token fetches.
## Backport Notes
- Resolved merge conflict in `src/main.ts` where remote config loading
logic was added on `rh-test`
- Preserved the CRITICAL comment about loading remote config first
- All files from original commit included
- Typecheck passed successfully
Original commit: 26f587c956
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6259-backport-rh-test-add-service-worker-on-cloud-distribution-to-attach-auth-header-to-brow-2966d73d365081b39cdac969b6c24d0d )
by [Unito](https://www.unito.io )
2025-10-24 14:19:02 -07:00
Christian Byrne
a9db25ecc3
[backport rh-test] subscription panel ( #6140 )
...
## Summary
Backport of #6064 (subscription page) to the `rh-test` branch.
This PR manually cherry-picks commit
7e1e8e3b65 to the rh-test branch and
resolves merge conflicts that prevented automatic backporting.
## Conflicts Resolved
### 1. `src/components/actionbar/ComfyActionbar.vue`
- **Conflict**: HEAD (rh-test) used `<ComfyQueueButton />` while the
subscription PR introduced `<ComfyRunButton />`
- **Resolution**: Updated to use `<ComfyRunButton />` to include the
subscription functionality wrapper while maintaining the existing
rh-test template structure
### 2. `src/composables/auth/useFirebaseAuthActions.ts`
- **Conflict**: Simple ordering difference in the return statement
- **Resolution**: Used the subscription PR's ordering: `deleteAccount,
accessError, reportError`
## Testing
The cherry-pick completed successfully and passed all pre-commit hooks:
- ✅ ESLint
- ✅ Prettier formatting
- ⚠️ Note: 2 unused i18n keys detected (informational only, same as
original PR)
## Related
- Original PR: #6064
- Cherry-picked commit: 7e1e8e3b65
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6140-backport-subscription-page-to-rh-test-2916d73d365081f38f00df422004f61a )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
Co-authored-by: GitHub Action <action@github.com >
2025-10-19 00:14:03 -07:00
Arjan Singh
5869b04e57
Merge main (as of 10-06-2025) into rh-test ( #5965 )
...
## Summary
Merges latest changes from `main` as of 10-06-2025.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5965-Merge-main-as-of-10-06-2025-into-rh-test-2856d73d3650812cb95fd8917278a770 )
by [Unito](https://www.unito.io )
---------
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Benjamin Lu <benceruleanlu@proton.me >
Co-authored-by: Terry Jia <terryjia88@gmail.com >
Co-authored-by: snomiao <snomiao@gmail.com >
Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com >
Co-authored-by: Jake Schroeder <jake.schroeder@isophex.com >
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com >
Co-authored-by: AustinMroz <4284322+AustinMroz@users.noreply.github.com >
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com >
Co-authored-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: Alexander Brown <DrJKL0424@gmail.com >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com >
Co-authored-by: Rizumu Ayaka <rizumu@ayaka.moe >
Co-authored-by: JakeSchroeder <jake@axiom.co >
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: DrJKL <DrJKL@users.noreply.github.com >
Co-authored-by: ComfyUI Wiki <contact@comfyui-wiki.com >
2025-10-08 19:06:40 -07:00
bymyself
ff0c15b119
merge main into rh-test
2025-09-28 15:33:29 -07:00
Jin Yi
59a1380f39
[feat] Cloud onboarding flow implementation ( #5494 )
...
* feature: cloud onboarding scaffolding
* fix: redirect unknown routes
* feature: cloud onboarding flow
* chore: code review
* test: api mock for test failing
* refactor: Centralize onboarding routing with dedicated check views
- Add UserCheckView to handle all user status routing decisions
- Add InviteCheckView to manage invite code validation flow
- Simplify auth.ts by removing async operations and extra complexity
- Update login/signup to always redirect through UserCheckView
- Remove distributed routing logic from all onboarding components
- Simplify router guards to delegate to check views
- Fix infinite redirect loops for non-whitelisted users
- Use window.location.href for final navigation to bypass router conflicts
Breaking changes:
- Removed claimInvite from auth.ts (moved to CloudClaimInviteView)
- Changed route names to use cloud- prefix consistently
- Simplified getMe() to synchronous function
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* fix: delete unused file
* Revert "test: api mock for test failing"
This reverts commit 06ca56c05e .
* feature: API applied
* feature: survey view
* feature: signup / login view completed
* style: min-h-screen deleted
* feature: completed login flow
* feature: router view added
---------
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-14 16:36:57 -07:00
Christian Byrne
f96de24a66
Migrate user.css file to upstream ( #3949 )
2025-05-20 20:11:06 -04:00
Chenlei Hu
be84d81c32
[Branding] Show execution progress in favicon ( #3880 )
2025-05-13 15:57:18 -04:00
Chenlei Hu
131fae72d4
[Branding] Use new logo on menu bar ( #3788 )
2025-05-06 15:18:50 -04:00
Chenlei Hu
2a21dd1004
[Branding] Use new logo favicon ( #3787 )
2025-05-06 11:02:49 -04:00
Chenlei Hu
3bdd814b3c
[Branding] Use new comfyorg logo ( #3786 )
2025-05-06 10:54:37 -04:00
Chenlei Hu
851739a768
[API Node] Sign in required dialog ( #3457 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-04-14 17:49:17 -04:00
Christian Byrne
d8721760f1
Add custom nodes manager UI ( #2923 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-03-08 18:54:08 -05:00
Chenlei Hu
9431c955a6
[CI] Include workflow templates at build time ( #2775 )
2025-03-02 15:22:18 -05:00
Silver
1c408d2f6a
replace colorSelect.png cursor ( #2738 )
2025-02-26 14:13:50 -05:00
bymyself
237b895e8b
Add thumbnails for workflow templates ( #2729 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-02-26 10:39:27 -05:00
bymyself
e2087d2a7b
Add node to default/tutorial workflow with link to getting started page of docs ( #2734 )
2025-02-26 10:35:40 -05:00
bymyself
79452ce267
Fix extraneous values in template workflows ( #2605 )
2025-02-17 13:55:29 -05:00
bymyself
8f5a9a50aa
Remove duplicate outpaint template ( #2602 )
...
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: Chenlei Hu <huchenlei@proton.me >
2025-02-17 10:12:09 -05:00
bymyself
434a2307a2
Remove lora dependency from flux canny template ( #2603 )
2025-02-17 10:08:16 -05:00
bymyself
108884a304
Replace "clip" with "text_encoders" in template workflows ( #2572 )
2025-02-16 09:39:10 -05:00
bymyself
39f245fd97
Remove interchangeable models from template workflows ( #2575 )
2025-02-16 09:36:34 -05:00
bymyself
2d2fa5bfe9
Fix incorrect link in template workflow ( #2579 )
2025-02-16 09:35:54 -05:00
bymyself
77d3e0c45e
Add ComfyUI Examples workflows to in-app templates ( #2541 )
...
Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-02-15 16:15:56 -05:00
bymyself
3fbccd20ff
Use fp16 model in default img2img template workflow ( #2430 )
2025-02-05 13:27:16 -05:00
bymyself
652125de1f
Use v1-5-pruned-emaonly-fp16 model in default template workflow ( #2346 )
2025-01-25 11:40:39 -05:00
filtered
601b739f75
Add GPU selection to desktop installer ( #1888 )
...
* Remove redundant code
* Add GPU picker screen to installer
* Permit jumping installation steps when visited
* Prevent sad girl from covering buttons
* Update gpu options to match availability
* Ensure install screen renders inside bounds
* Pre-select GPU detected by desktop native
* Redesign GPU selection screen
* Prevent text highlight on installer stepper
* Add translations for GPU picker
* Rename for clarity
* Remove unused code
* Update electron types
* Update locales [skip ci]
---------
Co-authored-by: huchenlei <huchenlei@proton.me >
Co-authored-by: github-actions <github-actions@github.com >
2024-12-16 15:26:40 -08:00
filtered
0bf30e7621
Add git download page ( #1742 )
2024-11-29 13:12:09 -05:00
Chenlei Hu
39eaa2e850
[Electron] Add not supported hardware page ( #1717 )
2024-11-27 10:46:24 -05:00
Tristan Sommer
3273ee938b
New Mask Editor ( #1284 )
...
* implmentation of new mask editor
* fixed some problems, added some new ones
* Refactor: Split implementation into classes, fix multiple bugs -> all initial features work, more testing required
* first release - fixed all known issues, tested, added color select tool and settings toggle
2024-11-17 21:23:32 -05:00
Robin Huang
65cad74eba
Add model download URL and change to use safetensors. ( #1076 )
2024-10-03 09:08:26 -04:00
Chenlei Hu
8b2ef3c352
Use jpg for template workflow thumbnail ( #1066 )
2024-10-02 12:11:09 -04:00
Chenlei Hu
e200e2f89c
Add model info for flux workflow template ( #987 )
2024-09-26 16:06:37 +09:00
pythongosssss
bf7652227a
Workflow templates ( #938 )
...
* Add template gallery
* Add simple test
* Add examples
* Enable floating menu in test
2024-09-25 16:01:50 +09:00
Chenlei Hu
6c4143ca94
Show node by frequency on empty query ( #878 )
2024-09-19 09:35:22 +09:00
Tobias Menzi
4b3bad4bc5
Change broken relative font paths ( #584 )
2024-08-21 19:01:02 -04:00
Chenlei Hu
d6b2d5fb4f
Use npm package @ComfyOrg/litegraph ( #89 )
...
* Use npm to manage litegraph
* Fix merge issues caused by BetaUI change
* Switch to @comfyorg/litegraph
* Fix various import
* Fix css apply order bug
* Fix package lock
* Update litegraph
* Update litegraph
* Update browsertest expectations
* Update test expectations [skip ci]
* Fix default view screenshot
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-07-05 20:53:47 -04:00
Chenlei Hu
5f979e844c
Relands BetaUI ( #77 )
...
* PR1
* PR2
* pr3
* Fix
* Revert 3909
* Ignore/fix type errors
* Fix import
2024-07-01 18:07:12 -04:00
Chenlei Hu
b69f15e5d7
Revert "Beta UI by pythongosssss ( #70 )" ( #72 )
...
This reverts commit 0d084e2cb0 .
2024-07-01 12:58:45 -04:00
Chenlei Hu
0d084e2cb0
Beta UI by pythongosssss ( #70 )
...
* PR1
* PR2
* pr3
* Fix
* Revert 3909
* Ignore/fix type errors
2024-07-01 12:55:16 -04:00
Chenlei Hu
d4c8992356
Audio node widgets ( #54 )
...
* Add audio widgets
* Change rendering order
* Proper output node
* Change indent
* Fix param
* Hide audio widget when output is empty
* Load default value
* populate audio widget from history
* Prevent init if no audio selection
2024-06-27 09:11:31 -04:00
Chenlei Hu
d7bf368cec
Bundle all dynamically loaded css ( #28 )
...
* static css
* Fix css import in tests
2024-06-18 13:58:21 -04:00
Chenlei Hu
3fbb75ce76
Configure vite to copy from src to dist ( #2 )
...
* nit
* move
* direct copy lib dir
* nit
* disable treeshake
2024-06-13 23:09:10 -04:00
huchenlei
e50259cefb
Move everything under public
2024-06-13 15:59:56 -04:00
huchenlei
ee0b054cde
Move extensions to public folder
2024-06-13 14:23:31 -04:00
huchenlei
1cfcd76754
Put lib/css under public/
2024-06-13 14:17:06 -04:00