Christian Byrne
c2eb4f03e9
fix: onNodeRemoved not called when loading new graph (and tearing down previous) ( #5407 )
...
* standardize graph cleanup
* test: fix useCoreCommands tests and add regression test
- Fix mocking to properly simulate app.clean() calling graph.clear()
- Add intelligent subgraph detection in mock to match real implementation
- Add regression test for Vue node cleanup bug to prevent future regressions
- Ensures app.clean() properly triggers onNodeRemoved events through graph.clear()
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* fix unit tests
* move beforeLoadNewGraph to before graph is cleaned
---------
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-06 19:35:57 -07:00
Christian Byrne
356886dc29
[Feature] Add MP4 workflow file open support ( #3950 )
2025-05-20 17:57:20 -07:00
Chenlei Hu
a049e9ae2d
[TS] Enable strict mode ( #3136 )
2025-03-18 22:57:17 -04:00
Chenlei Hu
7af003fcab
[TS] Enable noUnusedParameters ( #3110 )
2025-03-17 16:47:45 -04:00
Chenlei Hu
7e66e99c3a
[TS] Enable noUnusedLocals ( #3108 )
2025-03-17 16:20:56 -04:00
Chenlei Hu
cdf42d5ad7
[Refactor] Move zod schemas to schemas/ folder ( #2753 )
2025-02-27 13:05:01 -05:00
Chenlei Hu
d7673af8f5
[Refactor] Move resetView to litegraphService ( #2456 )
2025-02-06 14:22:40 -05:00
Chenlei Hu
8f5aa1ff08
[Desktop] Native window in graph view ( #2216 )
2025-01-09 23:00:28 -05:00
Chenlei Hu
d8f074fea0
[Lint] Sort imports ( #2104 )
2024-12-30 17:26:37 -05:00
Chenlei Hu
ab33eb6262
Remove legacy menu setting Comfy.MenuPosition ( #2080 )
...
Co-authored-by: github-actions <github-actions@github.com >
2024-12-27 23:15:43 -05:00
Chenlei Hu
f69e88bf41
[Refactor] Convert dialogService to composable ( #2058 )
2024-12-26 00:26:01 -05:00
filtered
2017b9016b
Add TS types - API ( #1736 )
...
* nit
* Add TS types - API events
* Replace all API event emits with type-safe variants
* Add missing API type
* nit
* Remove test code, nit
2024-11-29 13:15:25 -05:00
Chenlei Hu
d9a34872c3
[Electron] Add basic welcome screen ( #1491 )
...
* WIP
* Add LogTerminal
* Modify server startup view
* Add installView
* Add basic welcome screen and dev server setup
* nit
* nit
* nit
* nit
* nit
2024-11-10 09:41:32 -05:00
Chenlei Hu
97c38583e9
Rename workspaceStateStore to workspaceStore ( #1374 )
2024-10-30 09:49:23 -04:00
Chenlei Hu
35fab0bef3
Focus mode ( #1365 )
...
* Menu hamburger
* Focus
* nit
* nit
* nit
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-10-29 17:25:18 -04:00
Chenlei Hu
dc3dab4e1c
Enable ts-strict for commandStore ( #1321 )
2024-10-26 17:05:42 -04:00
Chenlei Hu
5611e90fda
Add ts-strict-ignore plugin ( #1235 )
...
* Add ts-strict-ignore plugin
* nit
* Add to typecheck script
2024-10-12 11:56:49 -04:00
Chenlei Hu
ebc71b0e46
Add PromptDialog to replace window.prompt ( #1104 )
...
* Save file prompt dialog
* Don't download if dialog dismissed
* refactor
* style dialog
* nit
* Autofocus
2024-10-04 15:33:27 -04:00
Chenlei Hu
142882a8ff
Move keybinds to coreKeybindings ( #1078 )
...
* Refactor core keybinds
* Prevent default
* Add playwright test
2024-10-03 11:25:53 -04:00
AustinMroz
9199639320
Reset FileInput value after load ( #958 )
...
When a file is browsed for, the fileInput remains associated with the
chosen file even after the associated workflow is loaded. If a user
attempts to load the same file again, the onchange event does not fire
and loading fails silently. This is fixed by clearing the fileInput
after the workflow has been loaded.
Out of an abundance of caution, the onchange is made async to ensure the
fileInput isn't cleared until after the workflow has loaded.
Add a test to check if the same workflow file can be loaded
consecutively.
2024-09-25 16:01:50 +09:00
Chenlei Hu
980dd285ad
Revert move floating menu to Vue ( #853 )
2024-09-17 09:33:25 +09:00
Chenlei Hu
2b60244e4a
Move setting declarations from ui to coreSettings ( #847 )
...
* Move setting declarations from ui to coreSettings
* nit
* nit
* Move effect to vue component
2024-09-16 17:47:47 +09:00
Chenlei Hu
45a866f194
Fix ComfyUI class setup procedure ( #846 )
2024-09-16 17:14:11 +09:00
Chenlei Hu
327b67a022
Move floating menu to a Vue component ( #843 )
...
* Move floating menu to a Vue component
* nit
* Fix jest tests
2024-09-16 14:26:46 +09:00
Chenlei Hu
4a230f720e
Edit group name on group creation (With Ctrl + g) ( #715 )
...
* Editor store
* Merge editors
* nit
* Edit on group creation
* nit
2024-09-02 20:20:40 -04:00
Chenlei Hu
2c174b5956
Group selected nodes by Ctrl + g ( #663 )
...
* Ctrl + g to group selected noes
* Add playwright test
* nit
* Move button loc
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-08-28 11:49:41 -04:00
Chenlei Hu
add2f9baa0
Group comfy core settings ( #508 )
...
* Add category overwrite
* Group settings
2024-08-18 12:49:23 -04:00
Chenlei Hu
ec5f1152da
Organize setting display for new settings dialog ( #507 )
2024-08-18 11:31:50 -04:00
Chenlei Hu
17aa44d9f6
Activate new settings dialog from default UI ( #506 )
2024-08-18 10:23:03 -04:00
Chenlei Hu
edf0396619
Type WS messages ( #375 )
2024-08-11 18:05:14 -04:00
Chenlei Hu
ce2a2dd2b6
Add link release searchbox trigger mode ( #356 )
2024-08-10 10:30:29 -04:00
Chenlei Hu
3269b54aae
Sync 2666 Execution Model Inversion ( #312 )
...
* Sync 2666 Execution Model Inversion
* Fix unittest
* Fallback compatible
2024-08-05 16:42:37 -04:00
pythongosssss
7a980f46c9
Add support for node/input/output tooltips ( #287 )
...
* Add support for node/input/output tooltips
* pr feedback
* Remove
2024-08-04 11:54:46 -04:00
Chenlei Hu
d02b074fa3
Manage searchbox imp setting in Vue app ( #282 )
...
* Manage searchbox setting in vue
* nit
2024-08-03 10:31:10 -04:00
Chenlei Hu
e179f75387
Apply new code format standard ( #217 )
2024-07-25 10:10:18 -04:00
Chenlei Hu
bd68617c82
Fix theme toggle ( #200 )
...
* Use builtin event on color change
* Fix theme toggle
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-07-22 16:46:02 -04:00
Chenlei Hu
54246d37b0
Relands "Fix node searchbox default value setting" ( #152 )
...
* Revert "Revert "Fix node searchbox default value setting (#150 )" (#151 )"
This reverts commit bb02f935ff .
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-07-17 22:34:03 -04:00
Chenlei Hu
bb02f935ff
Revert "Fix node searchbox default value setting ( #150 )" ( #151 )
...
This reverts commit 3dfef8a73e .
2024-07-17 22:30:36 -04:00
Chenlei Hu
3dfef8a73e
Fix node searchbox default value setting ( #150 )
2024-07-17 22:23:49 -04:00
Chenlei Hu
a28ac0c0fa
New searchbox with fuzzy search (WIP) ( #83 )
...
* Disable default searchbox
Add headlessui and vue
Add vite's vue plugin
Vue app helloworld
Format vue
Add vue shim
minimal working searchbox
Add primevue dark mode
Use primevue
nit
Add fuse fuzzy search
Add tailwindcss / center searchbox
Fix style
Add node source chip
desc text wrapping
Add placeholder
inputbox filter support wip
Revert some filter designs
Add filter modal
Drop down show all nodes
Change modal font
Add filtered search
nit
Complete on focus
Auto fill filterOption
Fix dropdown
Fix z-index
Fix search bug
Properly remove chip
Adjust node source detection
Resolve merge conflict
nit
* Refactor
* Use badge to display filter type
* nit
* Trigger on canvas event
* nit
* Auto add data type filter when link released
* nit
* Auto focus when shown
* Focus on add/remvoe filter
* close dialog when escape pressed
* Add node at fixed location
* nit
* Update litegraph
* nit
* Change theme
* Increase search limit
* Add node on event location
* Clear filter when dialog closed
* Enable/Disable new search bx
* Improve app loading
* Fix copy node
* Update test expectations
* Update test expectations [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com >
2024-07-10 19:46:35 -04:00
Chenlei Hu
d1934f27c8
Use '@' path mapping ( #94 )
2024-07-05 22:04:29 -04:00
Chenlei Hu
e05a33cb17
Rename to ts ( #92 )
...
Rename
Remove ts-nocheck, fix errors
Update state when graph cleared via UI (#88 )
Convert to ts, fix imports
Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com >
2024-07-05 21:18:32 -04:00
bymyself
27c5bc1581
Update state when graph cleared via UI ( #88 )
2024-07-05 18:28:39 +01:00
Chenlei Hu
acdaa6a594
Format all code / Add pre-commit format hook ( #81 )
...
* Add format-guard
* Format code
2024-07-02 13:22:37 -04:00
Chenlei Hu
fc020e08c5
Replace \t with spaces ( #80 )
2024-07-02 12:29:17 -04:00
Chenlei Hu
5f979e844c
Relands BetaUI ( #77 )
...
* PR1
* PR2
* pr3
* Fix
* Revert 3909
* Ignore/fix type errors
* Fix import
2024-07-01 18:07:12 -04:00
Chenlei Hu
b69f15e5d7
Revert "Beta UI by pythongosssss ( #70 )" ( #72 )
...
This reverts commit 0d084e2cb0 .
2024-07-01 12:58:45 -04:00
Chenlei Hu
0d084e2cb0
Beta UI by pythongosssss ( #70 )
...
* PR1
* PR2
* pr3
* Fix
* Revert 3909
* Ignore/fix type errors
2024-07-01 12:55:16 -04:00
Chenlei Hu
3238acd9c9
Sync flac metadata ( #66 )
2024-06-29 09:39:01 -04:00
Chenlei Hu
8264eb4fee
Add zod schema for TaskItem ( #59 )
...
* Add zod schema for TaskItem
* nit
2024-06-26 22:33:05 -04:00