Adds a no-restricted-paths zone enforcing that src/world/ cannot import
from src/lib/litegraph/. The world layer owns canonical entity identity
(WidgetEntityId, value store I/O) and must not depend on litegraph
types or values; this rule prevents accidental coupling.
Two existing imports in entityIds.ts (`NodeId`, `UUID`) are temporarily
suppressed with eslint-disable-next-line + TODO comments:
- NodeId will become a branded EntityId owned by src/world/.
- UUID is a primitive string brand and should move to src/utils/.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2561-ca22-76fa-8356-0c6f92548f8d
Co-authored-by: Amp <amp@ampcode.com>
The appModeStore identity refactor required every selected input to map
to a `widget.entityId`, set by `BaseWidget.setNodeId`. Third-party
extensions that push plain POJO widgets directly onto `node.widgets`
(bypassing `addCustomWidget`) have no `entityId`, so their selections
were dropped from App Mode with a "no canonical identity available"
warning and the linear-widgets panel rendered empty.
Add `getWidgetEntityIdForNode(node, widget)` in `litegraphUtil` that
returns `widget.entityId` when present and otherwise derives
`(rootGraphId, node.id, widget.name)` directly. Apply the helper in:
- `safeWidgetMapper` so the Vue projection includes POJOs
- `appModeStore.findWidgetByEntityId` and the legacy-NodeId branch so
POJO selections resolve on first selection and on reload
Fixes the `@vue-nodes In App Mode, widget width updates with panel size`
browser test for nodes that use the legacy `node.widgets.push(...)`
pattern.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2561-ca22-76fa-8356-0c6f92548f8d
Co-authored-by: Amp <amp@ampcode.com>
`_deserializeItems` previously bypassed both the ADR 0009 proxyWidget
migration and preview-exposure hydration for pasted SubgraphNodes, so
older clipboard data lost promoted widgets and preview exposures.
- Run `proxyWidgetMigrationFlush` for every top-level pasted SubgraphNode
carrying legacy `properties.proxyWidgets` (nested hosts already covered
by `LGraph.configure`).
- Topologically sort `parsed.subgraphs` before configuring so nested
SubgraphNodes' source-resolution sees a fully configured interior.
- Add `remapPreviewExposures` in `remapClipboardSubgraphNodeIds` to
patch `properties.previewExposures[].sourceNodeId` alongside
`proxyWidgets` after collision-driven interior id remap.
- Extract `autoExposeKnownPreviewNodes` from `promoteRecommendedWidgets`
and expose via a new late-bound `LGraph.autoExposePreviewNodes` hook,
invoked from both `LGraph.configure` and `_deserializeItems` so older
data without `properties.previewExposures` still derives canvas-image
previews from known interior node types.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2486-6c35-720c-b983-82df2eda9c7a
Co-authored-by: Amp <amp@ampcode.com>
- Skip LivePreview render on SubgraphNode hosts; previews flow through
promotedPreviews / previewExposureStore as the single source of truth
- Treat exposures as authoritative in SubgraphEditor.getActivePreviewWidgets
so $$canvas-image-preview rows always surface, even when the interior
source node lacks a matching promotable widget
- Hydrate canonical/legacy preview exposures at configure time in
SubgraphNode._hydratePreviewExposures; usePromotedPreviews is now a
pure read with path-style nested host fallback
- Add KSampler/KSamplerAdvanced to virtual canvas-image-preview node types
so live samplers expose preview rows pre-execution
- SubgraphEditor.open() returns early when panel is already visible to
avoid flaky context-menu opens
- Remove obsolete proxy-widget test; convert inline @vue-nodes name
prefix to tag annotation across subgraphPromotion.spec.ts
- Drop stale "migrates legacy host exposure keys while reading previews"
unit tests now that migration runs at configure time
Review feedback fixes:
- useResolvedSelectedInputs: clone graphNodes array to avoid shared
reference with app.rootGraph.nodes
- previewExposureSchema: avoid mutating the property parameter
- nodeOutputStore: case-insensitive `.svg` check
Amp-Thread-ID: https://ampcode.com/threads/T-019e23c9-3dc1-7381-ae59-c0372b3325e2
Co-authored-by: Amp <amp@ampcode.com>
The candidate filter compared `toKey()` outputs across the active
section (PromotedWidgetView, key includes `:sourceNodeId` suffix) and
the interior section (raw widget, no suffix). The shapes never matched,
so every link-promoted widget kept showing in the Hidden section as
`icon-eye/eye-off`. Compare on the interior `(node.id, widget.name)`
identity instead.
Update the Properties panel test to demote a link-promoted widget via
the source-node context menu (since linked promotions render
`icon-link` and disable the editor toggle by design).
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
The unknown-status branch of the input-select sidebar was binding
the title to the encoded entityId (e.g. graphId:nodeId:name) instead
of the persisted displayName. Users (and the appModePruning test)
saw an unreadable id where the original widget name should appear.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
AppInput's togglePromotion was pushing a bare nodeId tuple into
selectedInputs. The new useResolvedSelectedInputs projection drops
non-canonical ids, so clicks in App Builder never produced sidebar
entries. Forward widget.entityId through useProcessedWidgets and
NodeWidgets so AppInput can persist the canonical WidgetEntityId.
upgradeAndValidateInput also pruned any entityId whose widget was
missing, even when the host node still existed. Restore the
node-exists fallback so dynamic widgets surface as 'Widget not visible'
rows instead of being silently dropped on load.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
- Adds functions to SubgraphHelper to perform widget promotion by
standard user means
- Right Click -> Promote
- Properties Panel
- Adds new slot fixture code that works with simple `locator.dragTo`
operations.
- Adds multiple subgraph tests with a focus on historically difficult
operations.
- Fixes a bug where the litegraph `node.selected` state would not be
unset when switching graphs. This made it so 'Selecting a node ->
leaving subgraph -> re-enter subgraph -> right click on node' would fail
to select the node because it is marked as already selected.
┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11806-Add-helper-functions-for-widget-promotion-3536d73d365081f58dd9cd730c1a91a9)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Summary
API and other legacy JSON generated by python `json.dumps` can contain
`NaN` and `Infinity` which cannot be parsed with JS `JSON.parse`. This
adds regex to replace these invalid tokens with `null`.
## Changes
- **What**:
- add regex replace on bare NaN/infinity tokens after JSON.parse fails
- update call sites
- tests
## Review Focus
- The regex should only rewrite bare NaN/-Infinity/Infinity and not
touch string values or other invalid tokens.
- A small regex was chosen over JSON5 due to package size (30.3kB
Minified, 9kB Minified + Gzipped) or a manual parser due to the
unnecessarily complexity vs a single regex replace.
- The happy path is run first, the safe parse is only executed if that
failed, meaning no overhead the vast majority of the time and no
possiblity of corrupting valid workflows due to a bug in the fallback
parser
- Multiple call sites had to be updated due to pre-existing architecture
of the various parsers, an issue for unifying these is logged for future
cleanup
- New binary fixtures added for validating e2e import using real files
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12217-fix-add-support-for-parsing-python-generated-json-with-NaN-infinite-35f6d73d365081889fc7f4af823f29c1)
by [Unito](https://www.unito.io)
Introduce `useResolvedSelectedInputs` that maps each persisted
`[entityId, displayName, config?]` entry to a discriminated union of
`{ status: 'resolved', node, widget, ... } | { status: 'unknown', ... }`.
Handlers (rename, remove, resize, bounding) now receive widget instances
directly instead of re-walking `rootGraph.nodes` per interaction.
- Delete `src/world/widgetLookup.ts`; the lone remaining caller
(`upgradeAndValidateInput` in `appModeStore.ts`) inlines the lookup as a
module-private function.
- `inlineRenameInput` deleted; the template calls `renameWidget(widget,
node, $event)` directly with the in-scope widget.
- `getWidgetBounding` accepts a `ResolvedSelection`; returns `undefined`
for unresolved entries.
- `useAppModeWidgetResizing.onPointerDown` and `updateInputConfig` accept
a widget instance, matching the existing `removeSelectedInput` shape.
- Persisted `selectedInputs` shape unchanged.
- Unresolved entries continue to render as a removable "unknown widget"
pill in the sidebar so users can clean up dangling selections.
Slot-rename → entityId-drift bug investigated and confirmed not present:
the `renaming-input` handler in `SubgraphNode.ts` mutates `widget.label`
and `input.label`, never `widget.name`, so `entityId` is stable across
renames. Documented as an invariant in `useResolvedSelectedInputs`.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
## Summary
The position of a link relative to its slot was able to drift on load,
due to widgets inside a node being able to resize without triggering an
node-level resize event (min-height node with space at the bottom could
have widgets expand into free space, causing misalignment).
Recreation:
1. Add KSampler
2. Add Float
3. Connect Float to KSamper.denoise
4. Reload workflow (F5)
5. Observe misalignment
## Changes
- **What**:
- track widget grid element as signal only that triggers resync
- node bound calculations skipped for widget signals
- prevent setDirty on non-graph nodes (e.g. LGraphNodePreview)
- tests
## Review Focus
This is a small focused approach to fix the reported issue - it does not
address the underlying issue of the layout not being a SSOT. This fix is
a small bandaid and investigation into resolving the layout SOT issue is
not impacted by this.
## Screenshots (if applicable)
Before:
<img width="673" height="374" alt="image"
src="https://github.com/user-attachments/assets/2d34b8e3-0731-4fd2-8553-4dd429010ced"
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12214-fix-resolve-widget-input-link-position-drift-on-reload-35f6d73d3650814eb31bebb3042ff58b)
by [Unito](https://www.unito.io)
## Summary
When a user who has not used the app before first loads up, they are
presented with the template selection dialog. This conflicts when the
first-time user visits the app via a share link - both the share &
template dialog are triggered.
## Changes
- **What**:
- Skip the templates browser when share param is in URL
- Tests
- Add `url` to `setup`/`goto` to allow specifying the `share` parameter
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12024-fix-prevent-first-user-template-popup-when-following-shared-link-3586d73d365081cbbcecdba45a1ad1ea)
by [Unito](https://www.unito.io)
Drop the local `getHostStateName` helper that reconstructed the now-deleted
encoded `[name, sourceNodeId, sourceWidgetName].join(':')` format. Use
`widget.name` directly — the canonical store key after the entityId
migration in c1515374b. Fixes 2 failing tests in
SubgraphWidgetPromotion.test.ts.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
Steer new callers to `widgetValueIO`'s entityId-keyed helpers
(`getWidgetState`, `readWidgetValue`, `ensureWidgetState`). The branded
`WidgetEntityId` makes producer/consumer drift over `(graphId, nodeId, name)`
a type error rather than a silent value mix-up — this was the root cause of
the PR #12197 promoted-widget rendering bugs.
JSDoc-only; no behavior change.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
Replace the encoded `[name, sourceNodeId, sourceWidgetName].join(':')`
host-state-name with the canonical `WidgetEntityId` per ADR 0009. Producers
and consumers flip in the same diff:
- Delete `getPromotedWidgetHostStateName` (was internal disambiguator)
- `PromotedWidgetView` reads/writes via `widgetValueIO` keyed by `entityId`
- `SubgraphNode.serialize` reads via `readWidgetValue(widget.entityId)`
- `getExplicitHostWidgetValue` drops its now-unused `subgraphNode` param
- `safeWidgetMapper` no longer overrides `storeNodeId/storeName`; those
fields are removed from `SafeWidgetData`
- `useProcessedWidgets` looks up state via `getWidgetState(entityId)`
- `getWidgetIdentity` collapses to `${entityId}:${type}` (type suffix
preserves the PR #9896 invariant for node-def schema drift)
Net -66 LOC. No fallback / accept-either branches: entityId is the single
source of truth for widget identity across the renderer.
Amp-Thread-ID: https://ampcode.com/threads/T-019e2260-c2ba-70b4-9962-1638be4bf645
Co-authored-by: Amp <amp@ampcode.com>
*PR Created by the Glary-Bot Agent*
---
## Summary
Adds the Anthropic logo to the partner-node icon set so nodes whose
category ends in `Anthropic` (e.g. the Claude node added in
Comfy-Org/ComfyUI#13867 with `category="api node/text/Anthropic"`)
render the correct provider badge in the node library.
## Changes
- `packages/design-system/src/icons/anthropic.svg` — new auto-discovered
partner icon (Anthropic A glyph, sourced from
[lobehub/lobe-icons](https://github.com/lobehub/lobe-icons), uses
`fill="currentColor"` for theme adaptation)
- `src/utils/categoryUtil.ts` — register Anthropic's brand coral
`#D97757` as the badge border color
- `packages/design-system/src/css/style.css` — add `anthropic` to the
dynamic comfy-icon safelist so Tailwind/Iconify emits CSS for
`icon-[comfy--anthropic]` in production builds
- `src/utils/categoryUtil.test.ts` — regression tests for
`getProviderIcon('Anthropic')` and `getProviderBorderStyle('Anthropic')`
## Verification
- `pnpm typecheck` ✓
- `pnpm lint` ✓ (0 errors; 3 pre-existing warnings in unrelated files)
- `pnpm format:check` ✓
- `pnpm test:unit -- src/utils/categoryUtil.test.ts` ✓ (13/13)
- `pnpm build` ✓ — confirmed `comfy--anthropic` class is emitted into
`dist/assets/index-*.css`
- Manual visual check via Playwright against `pnpm dev`: injected `<i
class="icon-[comfy--anthropic]">` elements at badge size (10px) and 48px
alongside the existing OpenAI and BFL icons and confirmed the Anthropic
"A" glyph renders correctly in coral. See screenshot.
End-to-end visual verification of the live badge in the node library
requires Comfy-Org/ComfyUI#13867 to land first (the Claude node is what
produces the `Anthropic` category that triggers the icon lookup).
Related: Comfy-Org/ComfyUI#13867
## Screenshots
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12216-feat-add-Anthropic-partner-icon-35f6d73d36508133a134fcafaf72f4f8)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Introduce a canonical `WidgetEntityId` (`graphId:nodeId:name`) sourced
from the widget instance itself, replacing the ad-hoc tuple plus
NodeLocatorId scheme used by app-mode selection.
- Add `src/world/` with branded `WidgetEntityId`, lookup by id, and
value I/O helpers.
- Expose `entityId` on `IBaseWidget` / `BaseWidget` and
`PromotedWidgetView`; surface it through the Vue widget mapper.
- Migrate `appModeStore` selection tuples and pruning to entity-id
identity; legacy NodeId / NodeLocatorId tuples are upgraded forward.
- Update `AppBuilder`, `AppModeWidgetList`, and resize composable to
consume entity ids instead of (nodeId, widgetName) pairs.
Also fix a multi-host primitive bypass bug in `proxyWidgetMigration`:
host values now land on each host's input mirror, never the shared
interior consumer widget, and a marker on the primitive lets later
hosts of the same subgraph reuse the bypassed `SubgraphInput` after
the first host severs the primitive's outputs.
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e2235-1469-7501-bad7-388dcb5b4a29
## Summary
Rework the painter always hands the backend a valid asset reference:
- Drop the `hasStrokes` flag and the `isCanvasEmpty` check.
- `serializeValue` falls back to the existing `modelValue` when the
canvas element is transiently unmounted, reuses the cached upload when
not dirty and a value is present, and otherwise uploads the current
canvas (a fully transparent PNG is a valid no-op mask, Painter's Python
`execute()` treats painter_alpha=0 the same as "no mask painted").
- `handleClear` now also clears `modelValue` so a user-initiated clear
doesn't resurrect a stale upload on the next serialize.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12196-FE-566-fix-Painter-mask-submission-edge-cases-on-cloud-35e6d73d365081dd8856ddb785952526)
by [Unito](https://www.unito.io)
*PR Created by the Glary-Bot Agent*
---
## Summary
Disables the Free tier on the public marketing website
(`comfy.org/cloud/pricing` and `comfy.org/cloud`) behind a single
boolean flag so re-enabling is a one-line change.
The Free tier was already removed from the Comfy Cloud sign-up flow;
this PR removes the matching promotional surfaces on the marketing site
so users hit the paywall directly.
## Changes
- **New** `apps/website/src/config/features.ts` — exports
`SHOW_FREE_TIER` (currently `false`). Flip to `true` to restore the
previous UX.
- **`apps/website/src/components/pricing/PriceSection.vue`** — when
`SHOW_FREE_TIER` is `false`:
- drops the Free plan card from the pricing array
- desktop grid collapses from `lg:grid-cols-4` to `lg:grid-cols-3`
- Standard plan's "Everything in Free, plus:" intro is replaced with an
aria-hidden spacer so the three remaining cards stay vertically aligned
- **`apps/website/src/components/product/cloud/PricingSection.vue`** —
hides the "Start free. Upgrade when you're ready." tagline on the
`/cloud` pricing teaser.
- **New** `apps/website/e2e/pricing.spec.ts` — three @smoke tests
asserting the paid tiers + Enterprise are visible and that all Free-tier
surfaces are absent.
All translation strings (`pricing.plan.free.*`, `cloud.pricing.tagline`)
are retained so re-enabling requires no copy work.
## Verification
- `pnpm typecheck` — clean (0 errors, 0 warnings; pre-existing hint
unrelated)
- `pnpm lint` / `oxfmt` — clean
- `pnpm test:unit` — 30/30 passing
- Playwright e2e (desktop project) — `pricing.spec.ts` 3/3 passing,
`cloud.spec.ts` 13/13 still passing
- Visual: desktop and mobile pricing pages render with balanced 3-column
layout; `/cloud` teaser card still proportional.
Screenshot below.
## Screenshots
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12165-feat-website-hide-Free-tier-behind-SHOW_FREE_TIER-flag-35e6d73d36508164b4dfcfe9fee6b5e7)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
- proxyWidgetMigration.ts: collapse three *Result discriminated unions
into a single Outcome<TOk, TReason>; merge quarantineFor into
makeQuarantineEntry; SnapshotLink extends PrimitiveBypassTargetRef;
rename cohortReferencesPrimitive -> cohortDuplicatesPrimitive and
drop mutable counter
- SubgraphNode.serialize: replace for+push+hasSerializableValue flag
with flatMap and .some()
- appModeStore: replace nested for+continue+push with nested flatMap
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
- Add loadOrMigrateExposures(rootGraphId, primary, ...legacy) used by
both top-level host resolution and resolveNestedHost; deduplicates
the 'try primary -> fall back -> migrate to primary' pattern.
- Add readReactivePreviewUrls() that bundles the 4-way reactive
dependency reads with the URL fetch fallback, keeping the comment
about Vue dependency tracking next to the code that depends on it.
- Replace the 3-way previewMediaType ternary with a lookup map +
default via getPreviewMediaType().
- Replace the imperative for-loop + previews.push() + continue chain
with exposures.flatMap(); eliminates the last 'let' in the function.
- Drop the exposurePairs rename map; read exposure.name /
exposure.sourceNodeId / exposure.sourcePreviewName directly.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
Replace five separate vi.hoisted(() => vi.fn()) declarations plus the
useNodeOutputStoreMock factory with a single inline vi.mock factory
that owns the singleton store. Tests configure individual methods via
vi.mocked(useNodeOutputStore().method), matching the project's
vitest-patterns guidance and the pattern used in useGLSLPreview.test.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
## Automated Ingest API Type Update
This PR updates the Ingest API TypeScript types and Zod schemas from the
latest cloud OpenAPI specification.
- Cloud commit: 9619326
- Generated using @hey-api/openapi-ts with Zod plugin
These types cover cloud-only endpoints (workspaces, billing, secrets,
assets, tasks, etc.).
Overlapping endpoints shared with the local ComfyUI Python backend are
excluded.
---------
Co-authored-by: MillerMedia <7741082+MillerMedia@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
- Replace vi.clearAllMocks() + four explicit mockReset() calls with
single vi.resetAllMocks().
- Drop dead nodeOutputStore variable; inline the per-test mock store
assignment.
- Parameterize video/audio media-type cases via it.for.
- Rename the previously misleading 'uses preview exposures by source
preview name' test to clearly target the default-image branch when
previewMediaType is unset.
- Extract arrangePromotedPreview() helper to collapse repeating four-line
setup boilerplate.
- Replace '$$canvas-image-preview' magic strings with the existing
CANVAS_IMAGE_PREVIEW_WIDGET constant.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
Audit finding: 3 of 4 new tests in this PR either lacked the @vue-nodes
tag or relied solely on canvas/state assertions. Bring them in line with
the rest of the @vue-nodes coverage:
- 'Legacy primitive proxy widgets migrate...' — add @vue-nodes tag and
assert host renders 2 migrated widget rows before and after reload.
- 'Nested preview exposures render...' — add explicit .lg-node-widgets
absence assertion (preview-only host has no widgets container).
- 'Legacy unresolvable proxy entry...' — add @vue-nodes tag and assert
the missing_widget label is not rendered on the host.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
Refactor PR-review feedback on SubgraphHelper.ts and promotedWidgets.ts:
- Replace inline boolean checks (that masqueraded as type guards) with
real `is`-predicate functions: `isPromotedWidgetSource`, `isNodeProperty`.
- Drop duplicated `[string, string]` tuple shapes in favor of the existing
`PromotedWidgetEntry` type alias.
- Move validation outside `page.evaluate` so we can use the canonical
`parsePreviewExposures` zod schema and the shared `PromotedWidgetSource`
type from `src/core/...`.
- Eliminate type assertions; narrow via `in` checks and predicate guards.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f3a-a617-70b4-8945-3f0fbd34c1de
Co-authored-by: Amp <amp@ampcode.com>
Two CI Playwright failures in the multi-host primitive fanout test and
the legacy-prefixed proxyWidget normalization test traced to the same
class of mismatch: the migration wrote per-host widget state to a key
the Vue rendering layer didn't read from, and `classify()` accepted
source widgets that `repairCreateSubgraphInput()` then rejected.
Failure 1 — Per-host independence
The migration's `setHostWidgetState` registers values under
`(rootGraphId, hostNodeId, "<name>:<sourceNodeId>:<sourceWidgetName>")`,
but `safeWidgetMapper` produced `storeNodeId/storeName` pointing at the
shared interior key `(rootGraphId, sourceNodeId, sourceWidgetName)`. The
host-scoped value was therefore invisible to Vue; the rendered input
fell back to the empty interior default.
Add `ensureHostWidgetState()` on `PromotedWidgetView` that idempotently
registers a host-scoped store entry seeded with the current effective
value (factored shared registration into `registerHostWidgetState`).
Update `safeWidgetMapper` so promoted widgets call it and expose the
host-scoped `storeNodeId`/`storeName` derived from
`getPromotedWidgetHostStateName`. Two unit tests asserted the previous
interior-keyed identity; updated to assert the host-scoped key while
preserving the same distinct-identity invariant.
Failure 2 — Legacy nested proxy entries
`classify()` resolved source widgets via
`findSourceWidget(...) ?? getPromotableWidgets(...).find(...)`, but
`repairCreateSubgraphInput()` used only `findSourceWidget(...)`. A
legacy entry whose source was a nested SubgraphNode passed
classification then quarantined at repair time, leaving the host with
fewer rendered widgets than expected.
Extract a shared `resolveSourceWidget()` helper applying the same
fallback in both call sites.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f0b-176e-7659-80f5-20323ac54898
Co-authored-by: Amp <amp@ampcode.com>
Replace in-test workflow synthesis with saved-workflow assets so the
subgraph serialization tests load fixtures the same way a user would.
Drop the local mutable-workflow types and the manual setting toggles by
adopting the @vue-nodes tag, which auto-enables Vue Nodes and waits
for the rendered surface.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1f0b-176e-7659-80f5-20323ac54898
Co-authored-by: Amp <amp@ampcode.com>
## Summary
- Extract `isCivitaiHost` private helper from `isCivitaiModelUrl` in
`formatUtil.ts` for DRY hostname checking
- Add `isCivitaiUrl` exported function for hostname-only Civitai URL
detection (distinct from `isCivitaiModelUrl` which also validates the
path format)
- Refactor `getSourceName` in `assetMetadataUtils.ts` to use the shared
`isCivitaiUrl` instead of inline duplicate hostname checks
- Add tests for `isCivitaiUrl` covering `.com`, `.red`, subdomain, and
invalid URL cases
## Changes
- `packages/shared-frontend-utils/src/formatUtil.ts` — add
`isCivitaiHost` private helper + export `isCivitaiUrl`; refactor
`isCivitaiModelUrl` to use helper
- `packages/shared-frontend-utils/src/formatUtil.test.ts` — add
`isCivitaiUrl` test suite
- `src/platform/assets/utils/assetMetadataUtils.ts` — import
`isCivitaiUrl` from `@/utils/formatUtil`; remove inline hostname logic
from `getSourceName`
## Testing
### Automated
- Added `isCivitaiUrl` test suite (6 cases: `.com`, `.red`, subdomains,
non-Civitai, invalid URL)
- All 71 existing `formatUtil` tests pass
- All 53 existing `assetMetadataUtils` tests pass (behavior preserved)
- TypeScript typecheck passes
### E2E Verification Steps
1. Run unit tests: `npx vitest run
packages/shared-frontend-utils/src/formatUtil.test.ts
src/platform/assets/utils/assetMetadataUtils.test.ts`
2. Expected: all tests pass
3. Verify `getSourceName('https://civitai.red/models/123')` returns
`'Civitai'`
4. Verify `isCivitaiUrl('https://civitai.com/models/any-path')` returns
`true`
5. Verify `isCivitaiModelUrl` still rejects non-API paths while
`isCivitaiUrl` accepts them
## Review Focus
`isCivitaiUrl` (new, hostname-only) vs `isCivitaiModelUrl` (existing,
hostname+path format): `getSourceName` needs to recognize ANY Civitai
URL as a source, so using `isCivitaiModelUrl` directly would incorrectly
reject valid browse URLs like `civitai.com/models/123`.
Closes#11357
┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11822-refactor-deduplicate-Civitai-hostname-logic-in-getSourceName-3546d73d36508110974ccc3b7384d82b)
by [Unito](https://www.unito.io)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
resolveSubgraphInputTarget previously gated on getTargetWidget() before
the SubgraphNode-host branch, so an outer SubgraphInput linked to a
nested SubgraphNode whose inner slot has no concrete widget resolved
to undefined. The consumer in useGraphNodeManager then fell back to
the interior PromotedWidgetView's deep (sourceNodeId, sourceWidgetName)
identity, which contradicts ADR 0009's host-scoped opaque contract:
identity is (hostNodeLocator, SubgraphInput.name).
Reorder so the SubgraphNode-host branch runs first and returns
(child.id, targetInput.name) regardless of whether the inner slot has
a backing widget. The widget lookup remains the gate for the
plain-interior-node branch, where a non-widget input legitimately has
no promotable target.
Three existing tests asserted the pre-ADR undefined behavior on
nested-SubgraphNode + non-widget inputs. Update those assertions and
test names to reflect the host-opaque contract; capture the inner
node id from the helper since two helper calls collide on the
hard-coded id.
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e1e84-3270-730a-8c95-49a383ffdf20
Adds the `--type-aware` so that the typechecks performed by precommit
hooks have parity with the results output by a full `pnpm lint`
Most notably, unawaited promises would not be caught by the precommit
hooks prior to this PR.
```
× typescript-eslint(no-floating-promises): Promises must be awaited, add void operator to ignore.
╭─[browser_tests/fixtures/utils/vueNodeFixtures.ts:45:5]
44 │ async select() {
45 │ this.header.click()
· ───────────────────
46 │ }
╰────
```
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12203-Fix-pre-commit-linter-skipping-type-checks-35e6d73d365081a4adade833294df7ed)
by [Unito](https://www.unito.io)
- proxyWidgetMigration: when a disambiguator is supplied but doesn't
match, only fall back to non-promoted widgets with the same name so
we don't silently bind to a sibling PromotedWidgetView.
- previewExposureChain: chainFromLastStep was using the already-advanced
currentRootGraphId for the leaf, producing an inconsistent
(rootGraphId, sourceNodeId) pair on cycle / no-exposure / max-depth
exits. Use the last pushed step's rootGraphId instead.
- promotedWidgetView.applyValueControlToHost: control-after-generate
was reassigning this.value, which cascades into the shared interior
widget via the value setter. Switch to hydrateHostValue so the
per-host overlay is updated without touching shared state.
- promotionUtils: capture promoteValueWidgetViaSubgraphInput results at
both call sites and emit a warning Sentry breadcrumb on failure
instead of silently dropping {ok:false, reason}.
- LGraphNode.clone: in UUID mode, configure() was overwriting the
borrowed source id with the freshly generated UUID before subclass
hydration could run. Generate the UUID up front and reapply it after
configure() so hydration sees the borrowed id and the cloned node
still gets a fresh identity.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1e84-3270-730a-8c95-49a383ffdf20
Co-authored-by: Amp <amp@ampcode.com>
*PR Created by the Glary-Bot Agent*
---
## Summary
The careers page at comfy.org/careers was linking every role to its
Ashby application form (`.../{id}/application`) instead of the job
description page (`.../{id}/`). Users expect to first read the role
description, not land on the submit-resume page.
Ashby's job board API returns both `jobUrl` (description) and `applyUrl`
(application form). `toDomainRole` was preferring `applyUrl`; this PR
switches to `jobUrl` and renames the `Role` field accordingly so the
field name matches its meaning.
## Changes
- `apps/website/src/utils/ashby.ts`: use `job.jobUrl` directly instead
of `job.applyUrl ?? job.jobUrl`.
- `apps/website/src/data/roles.ts`: rename `Role.applyUrl` →
`Role.jobUrl`.
- `apps/website/src/components/careers/RolesSection.vue`: update the `<a
:href>` binding.
- `apps/website/src/data/ashby-roles.snapshot.json`: regenerated
fallback snapshot — URLs stripped of `/application`, `id`s recomputed
from the new URLs.
- Unit + E2E tests updated; new E2E assertion that links do not end in
`/application` prevents regressions.
The Ashby schema (`ashby.schema.ts`) still accepts `applyUrl` since the
API returns it — we just no longer consume it.
## Verification
- `pnpm test:unit` — 70/70 pass
- `pnpm typecheck` — 0 errors
- `pnpm build` — succeeds; inspected `dist/careers/index.html`, all 19
Ashby links now point to description URLs and zero contain
`/application`
- Oracle code review — 0 issues
Fixes user report in #hiring-ideas (Slack).
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12200-fix-website-link-careers-page-to-Ashby-job-description-not-application-form-35e6d73d3650815cbedadf974f7d3364)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Switch the multi-host primitive fanout test to @vue-nodes and assert
against rendered widget inputs. Previous version asserted the same
string-widget value 8 times instead of covering both promoted widgets
per host.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1e14-fdd4-70f4-a3f7-da15caefcd71
Co-authored-by: Amp <amp@ampcode.com>
Tag the duplicate-widget-names test with @vue-nodes and use DOM
locators (`getNodeLocator`, `getByRole('textbox')`, `enterSubgraph`)
instead of `page.evaluate`-based graph introspection. The outer
node assertion now checks the rendered textbox value directly, and
the inner node assertion enters the outer subgraph and reads the
two distinguishable text inputs from the inner SubgraphNode in the
DOM.
Amp-Thread-ID: https://ampcode.com/threads/T-019e1db0-3c55-75fe-a542-8bfcbcf87d60
Co-authored-by: Amp <amp@ampcode.com>
