2 Commits

Author	SHA1	Message	Date
Alexander Brown	0132c77c7d	test: harden 82 Playwright specs for deterministic CI runs (#10967) ... ## Summary Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI runs by replacing race-prone patterns with retry-safe alternatives. No source code changes -- only `browser_tests/` is touched. ## Changes - **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers): | Fix class | Sites | Examples | |-----------|-------|---------:| | `expect(await ...)` -> `expect.poll()` | ~153 | interaction, defaultKeybindings, workflows, featureFlags | | `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 | menu, linkInteraction, assets, bottomPanelShortcuts | | `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 | contextMenu, rightClickMenu, subgraphHelper | | Redundant `nextFrame()` removed | many | defaultKeybindings, minimap, builderSaveFlow | | `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction (graphdialog dismiss guard) | | `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog fixture | | ContextMenu `waitForHidden` simplified (check-then-act race removed) | 1 | ContextMenu fixture | | Non-deterministic node order -> proximity-based selection | 1 | interaction (toggle dom widget) | | Tight poll timeout (250ms) -> >=2000ms | 2 | templates | - **Helper improvements**: Exposed locator getters on `ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and `WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying assertions (`toHaveCount()`, `toHaveText()`) directly. - **Flake pattern catalog**: Added section 7 table to `browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes for reviewers and future authors. - **Docs**: Fixed bad examples in `browser_tests/README.md` to use `expect.poll()`. - **Breaking**: None - **Dependencies**: None ## Review Focus - All fixes follow the rules in `browser_tests/FLAKE_PREVENTION_RULES.md` - No behavioral changes to tests -- only timing/retry strategy is updated - The `ContextMenu.waitForHidden` simplification removes a swallowed-error anti-pattern; both locators now use direct `waitFor({ state: 'hidden' })` --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>	2026-04-09 20:50:56 -07:00
Dante	e8787dee9d	fix: prevent node context menu from overflowing viewport on desktop (#10854) ... ## Summary The node "More Options" (⋮) context menu had `md:max-h-none md:overflow-y-visible` responsive overrides that removed the height constraint and scrollability on desktop (768px+). When the menu had many items (e.g., KSampler), items below the viewport fold were inaccessible with no scrollbar. Removed the desktop overrides so `max-h-[80vh] overflow-y-auto` applies at all screen sizes. - Fixes #10824 ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: add failing test for node context menu viewport overflow` | 🔴 Red | Proves the test catches the bug | | `fix: prevent node context menu from overflowing viewport on desktop` | 🟢 Green | Proves the fix resolves the bug | ## Test Plan - [ ] CI red on test-only commit - [ ] CI green on fix commit - [ ] Manual verification: zoom out to 50%, open node More Options menu, verify last item ("Remove") is scrollable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10854-fix-prevent-node-context-menu-from-overflowing-viewport-on-desktop-3396d73d365081989403c981847aeda6) by [Unito](https://www.unito.io)	2026-04-10 10:31:04 +09:00