Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-05 23:50:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,349 Commits 591 Branches 535 Tags
ab25d1fc6ee8fbf2e4a9cb07f3084f3cf7363668
Commit Graph

181 Commits

Author SHA1 Message Date
filtered
ab25d1fc6e [Cleanup] Remove redundant code (#663) 
Removes:

- Unused option from public API `getWidgetAtCursor` - use without params
- Unused workaround impl. for WebGL
- Invalid code (incorrect `tabIndex` casing)
 2025-03-01 17:54:35 +00:00
filtered
7b4bea8e62 Remove deprecated code - webGL (#660) 
Removes long-deprecated WebGL code.
 2025-03-01 16:33:17 +00:00
filtered
177a5a0d54 [CodeHealth] Remove wheel listener & event wrapper (#656) 
- Replaces the long-deprecated `mousewheel` and `DOMMouseScroll` event
listeners with `wheel` listener
  - Verified no change in Chromium behaviour (desktop, mouse)
- Removes redundant pointer listener wrapper
- Fixes types
 2025-03-01 13:18:15 +00:00
filtered
c473130499 [TS] Use strict mode in LGraphCanvas (#654) 
- Prefer creating HTML elements in JS and `append()` over innerHTML &
`querySelector()`
- Removes redundant code
- Adds/fixes TS types
 2025-03-01 11:52:42 +00:00
filtered
bad923a7f0 [Refactor] Remove deprecated mousewheel events (#652) 
Prefer "wheel" event (added around Chrome v31).
 2025-03-01 11:34:23 +00:00
filtered
b36bf3d4a2 [CodeHealth] Apply modern standards to LGraphCanvas (#650) 
- Prefer template string
- Prefer explicit throw to undefined TypeError
- Remove unnecessary `this` assignment
 2025-02-28 22:08:23 +00:00
filtered
c4faaf4210 [TS] Fix ContextMenu types (#649) 
- No runtime changes
- Drastically improves ContextMenu type accuracy / safety
- Allows TS strict conversion
 2025-02-28 14:52:07 +00:00
filtered
b877312336 [Refactor] Fix TS types, remove redundant code (#648) 
Minor clean up and graph null deref checks.

Minor runtime change: due to optional chaining, it is possible a
downstream consumer is catching this extremely rare behaviour on purpose
and handling it.
 2025-02-28 11:13:23 +00:00
filtered
4365873039 [Refactor] Prefer NullGraphError & standardisation (#647) 
- Best effort code search for convert explicit `null` to `undefined`
- Prefer explicit throw over `TypeError`
- Prefer template strings
 2025-02-28 20:16:34 +11:00
filtered
b4688e18f9 [Refactor] Prefer includes over indexOf -1 (#646) 
Enables ESLint auto-fix rule.
 2025-02-28 08:53:29 +00:00
filtered
7b19abf83a [TS] Use strict mode in Canvas: initializers (#645) 
- Code search verified no consumers expecting explicit null on callbacks
(best effort)
- Removes redundant code
 2025-02-28 08:48:53 +00:00
filtered
be8dc6867e [Refactor] Prefer event listeners to callback props (#637) 
N.B.: `onerror` replacement is not a `window` or `Element` instance.
 2025-02-27 14:50:39 +00:00
filtered
97bf9de83a [Refactor] Standardise code style - modern JS (#636) 
Uses unicorn rules to auto-refactor code.  All verified.
 2025-02-27 13:13:32 +00:00
filtered
0d8e0fce17 [Refactor] Fix assignment of this to const (#631) 
Refactors using arrows funcs or storing the once-off requirement as an
action, removing the need to dereference this inside the function.
 2025-02-27 10:32:53 +00:00
filtered
2104f2a8a9 [Refactor] Prefer textContent over innerText (#630) 
Only setters are used, so getter differences aren't involved. This may
result in a runtime change to consumers passing a Node that isn't
actually a HTMLElement.
 2025-02-27 10:11:07 +00:00
filtered
1e8938ceff Add unicorn lint rules - DOM built-in functions (#628) 
- Prefer append(), remove(), replaceAll()
- Wrap nested ternaries in parenthesis
 2025-02-27 09:18:25 +00:00
Miguel C
7e6b64f216 Fix widget sizing logic in LGraphCanvas and LGraphNode (#609) 
This fixes an issue with widget heights not coinciding with actual
computed heights.
<img
src="https://github.com/user-attachments/assets/50b4b86c-8de8-4844-9a17-6f18d32e7f5e"
height="128" alt="old">old
<img
src="https://github.com/user-attachments/assets/c34e432a-6941-469e-99cd-df15c0a527de"
height="256" alt="new">new
 2025-02-26 10:56:30 -05:00
filtered
0e9b8b03b7 Enforce curly braces in multi-line if statements (#619) 
Removes formatters' ability to print code that goes to a new line, but
uses no braces to delineate.

It becomes more difficult to follow when using JS-style indents (two
spaces).

No effort required - braces added by auto-fixer.
 2025-02-26 15:08:23 +00:00
filtered
a43109d58a [TS] Use strict mode in ContextMenu (#618) 
- Adds minor type coercions to resolve type errors
- Uses the same type-coercion behaviour of the target DOM object
properties
- Resolves a long-standing type issue in context menu interfaces
(converts to generic - `unknown` by default)
- Fixes several incorrect types
- Adds ts-ignore that must be removed later
 2025-02-26 14:29:45 +00:00
filtered
3040924d76 [TS] Use strict mode in CanvasPointer, measure, and polyfills (#617) 
- Adds runtime type guard
- Adds ts-ignore that must be removed later
  * [ ] #578
 2025-02-26 13:05:40 +00:00
filtered
5cdd0581fa Add import / export sort rules (#612) 
- Adds ESLint package
- Applies import/export rules to all files
- Uses newline delineated grouping, with type-only imports first
 2025-02-26 09:21:33 +00:00
filtered
9ded97d189 [Doc] Add JSDoc linter & general comment clean up (#611) 
- Prefer comments above lines over end-of-line comments
  - Makes auto-formatting easier
  - Subjective, but it is generally easier to read in JS
- Standardises JSdoc format
- Auto-fixes for many issues (applies on save w/ESLint extension)
 2025-02-26 08:54:18 +00:00
filtered
477d498d6b [API] Remove unused: optional_inputs & outputs (#597) 
Code search shows zero usage. If kept, typing properly would require
effort.

Removed:
- `LGraphNode.optional_inputs`
- `LGraphNode.optional_outputs`
 2025-02-25 16:33:21 +00:00
filtered
6bd151c91e [API] Remove LiteGraph.searchbox_extras (#592) 
- Unused, loose typing
- Code search shows usage is limited to code copy & paste of litegraph
code
- So long as the `searchbox_extras` property exists and is empty, there
is no change to downstream consumers
 2025-02-25 09:16:49 +00:00
filtered
c8ffacf172 [TS] Use strict mode in LGraph (#579) 
* [TS] Undefined is not a valid object key

* Deprecate unused code

Adds ts-expect-error to TS strict issues on unmaintained public interfaces.

* [TS] Fix nullability: asSerialisable return type

* nit - Remove outdated comment

* [TS] Strict mode: LGraph

- Adds minor coercion changes; would need extremely specific hacks performed to result in runtime change

* [TMP] Work around typescript-strict-plugin

Must be reverted once plugin removed.
See #578
 2025-02-24 11:12:46 +00:00
filtered
1800d31a5a [Refactor] Prefer modern for..of loops 2 (#569) 
* [Refactor] Prefer for..of

* [Refactor] Prefer for..of - manual refactoring

* Partially revert change - potential conflict

Not worth time investment to fix - reverted.
 2025-02-23 16:36:52 -05:00
filtered
46535409c8 [CI] Fix existing lint warnings & disallow in future (#567) 
* Fix lint warnings

* [CI] Fail lint checks instead of warning

* [CI] Fail stylistic lint checks instead of warning
 2025-02-23 20:12:04 +00:00
filtered
4163cb04b8 [Refactor] Prefer modern for..of loops (#566) 
- Replaces traditional incrementing `for` loops and `forEach()` calls with modern `for..of` syntax
- Improves readability
- Semantic checking used; not expecting issues to arise from this portion
 2025-02-23 19:59:41 +00:00
Chenlei Hu
dc9a76200b [BugFix] Call LGraphCanvas.deleteSelected on context menu remove (#560) 2025-02-20 15:22:53 -05:00
filtered
1dee497e40 Fix drag event throws introduced in #554 (#555) 2025-02-20 16:30:38 +11:00
filtered
b67f34e7f3 [Cleanup] Remove lint bypass, remove unused vars (#554) 2025-02-20 11:17:35 +11:00
Chenlei Hu
6b1e40a011 Add IColorable interface (#549) 
* Add IColorable interface

* Set color option

* nit

* nit

* nit
 2025-02-19 13:56:08 -05:00
Chenlei Hu
196645ce7e Clear selectedItems on canvas clear (#543) 2025-02-18 11:49:06 -05:00
bymyself
e800eeb202 type selected_nodes (#541) 2025-02-18 11:48:54 -05:00
Chenlei Hu
9288709497 Trigger onSelectionChange on deleteSelected (#539) 2025-02-17 17:22:32 -05:00
Chenlei Hu
28e86820d6 Trigger LGraphCanvas.onSelectionChange on drag-select (#537) 2025-02-16 20:24:59 -05:00
Chenlei Hu
1e71da9a38 Show widget input inplace (#535) 
* Show widget input inplace

* nit

* nit
 2025-02-16 11:37:47 -05:00
Chenlei Hu
d23a320f9f Upstream frontend widgets layout logic (#531) 
* Upstream frontend widgets layout logic

* Add back LGraphNode.freeWidgetSpace

* nit

* update expectations
 2025-02-14 19:22:37 -05:00
Chenlei Hu
a5c89c0152 [Performance] Avoid double measure on node rendering (#529) 
* [Performance] Avoid double measure on node rendering

* Move _collapsed_width calc

* nit

* nit

* nit

* nit

* nit
 2025-02-14 14:15:40 -05:00
Chenlei Hu
de10bf0c3a [Cleanup] Remove LGraphCanvas.adjustNodesSize (#528) 2025-02-14 11:10:40 -05:00
Chenlei Hu
75267957d5 Use LGraphNode.setSize (#527) 2025-02-14 11:06:49 -05:00
Chenlei Hu
ce44cea409 Split layout and draw for slots (#524) 
* Split layout and draw for slots

* nit

* nit

* Fix serialization

* Move effect (highlight/invalid) to layout calculation

* nit

* Fix type issue

* Resolve review comments
 2025-02-13 20:20:57 -05:00
Chenlei Hu
361a1a76ef Add LGraphNode.getExtraSlotMenuOptions hook (#522) 2025-02-12 15:52:27 -05:00
Chenlei Hu
9abcf0fd32 Remove LGraphNode.horizontal (#521) 
* Remove LGraphNode.horizontal

* nit
 2025-02-12 15:11:59 -05:00
Chenlei Hu
f0eca030c4 [BugFix] Trigger IWidget.callback on widget drag (#514) 2025-02-10 14:37:16 -05:00
Chenlei Hu
997d673bd9 [Refactor] LgraphNode.drawSlots (#503) 
* wip

* nit
 2025-02-09 12:53:41 -05:00
Chenlei Hu
048fa5bb88 [Refactor] NodeSlot.isValidTarget (#501) 2025-02-09 11:59:52 -05:00
Chenlei Hu
120c606f07 [Refactor] LGraphNode.drawCollapsedSlots (#500) 2025-02-09 11:02:20 -05:00
Chenlei Hu
01b8ae5bb8 [Refactor] LGraphNode.drawWidgets (#499) 2025-02-08 23:41:01 -05:00
Chenlei Hu
f26807f931 [Refactor] NodeSlot.drawCollapsed (#498) 2025-02-08 23:00:58 -05:00