ComfyUI_frontend

Comfy-Org/ComfyUI_frontend

Fork 0

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-23 22:25:05 +00:00

Commit Graph

Author	SHA1	Message	Date
Benjamin Lu	3e31de5bbb	test: migrate MaxHistoryItems browser coverage (#12298 ) ## Summary Migrates the MaxHistoryItems browser coverage to the accepted jobs route fixture pattern. ## Changes - What: Composes `jobsRouteFixture` into the queue settings spec and removes the old `AssetsHelper` route setup. - What: Adds a `responseLimit` option to `jobsRouteFixture` so tests can match a requested history limit while intentionally returning more jobs. - Dependencies: None. ## Review Focus The key behavior is preserving both FE-501 acceptance cases: `/api/jobs` still receives the configured `limit`, and the queue panel still caps rendered history even if the mocked backend returns more rows than requested. Fixes FE-501 ## Screenshots (if applicable) Not applicable. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12298-test-migrate-MaxHistoryItems-browser-coverage-3616d73d365081d6bf77fb205fcd51d4) by [Unito](https://www.unito.io)	2026-05-18 18:59:20 +00:00
Benjamin Lu	aa2169e108	test: reset queue history cap in browser tests (#11773 ) ## Summary - Reset `Comfy.Queue.MaxHistoryItems` in the shared browser-test `comfyPage` setup so worker-persisted queue settings cannot leak between tests. - Keep the queue settings spec focused on asserting the setting behavior without local cleanup scaffolding. ## Validation - `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:65419 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:65400 TEST_COMFYUI_DIR=/Users/ben/.codex/comfyui-preview-env/runtime/worktrees/fe-500-maxhistoryitems pnpm exec playwright test browser_tests/tests/queue/queueSettings.spec.ts --project=chromium --workers=1` - `pnpm exec eslint browser_tests/tests/queue/queueSettings.spec.ts browser_tests/fixtures/ComfyPage.ts` - `pnpm exec oxlint browser_tests/tests/queue/queueSettings.spec.ts browser_tests/fixtures/ComfyPage.ts` - `pnpm typecheck:browser` - `git diff --check` - commit hook: staged oxfmt, oxlint, eslint, `pnpm typecheck`, `pnpm typecheck:browser` Linear: FE-500	2026-05-04 21:31:36 +00:00
pythongosssss	3c50487c18	test: add test for MaxHistoryItems setting (#11750 ) ## Summary Adds test to ensure MaxHistoryItems limits both API query & client rendering ## Changes - What: - ensure limit is added to url - ensure virtual grid is capped to limit ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11750-test-add-test-for-MaxHistoryItems-setting-3516d73d365081daa973ccfd8a7f479e) by [Unito](https://www.unito.io)	2026-04-29 19:10:31 +00:00

Author

SHA1

Message

Date

Benjamin Lu

3e31de5bbb

test: migrate MaxHistoryItems browser coverage (#12298 )

## Summary

Migrates the MaxHistoryItems browser coverage to the accepted jobs route
fixture pattern.

## Changes

- **What**: Composes `jobsRouteFixture` into the queue settings spec and
removes the old `AssetsHelper` route setup.
- **What**: Adds a `responseLimit` option to `jobsRouteFixture` so tests
can match a requested history limit while intentionally returning more
jobs.
- **Dependencies**: None.

## Review Focus

The key behavior is preserving both FE-501 acceptance cases: `/api/jobs`
still receives the configured `limit`, and the queue panel still caps
rendered history even if the mocked backend returns more rows than
requested.

Fixes FE-501

## Screenshots (if applicable)

Not applicable.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12298-test-migrate-MaxHistoryItems-browser-coverage-3616d73d365081d6bf77fb205fcd51d4)
by [Unito](https://www.unito.io)

2026-05-18 18:59:20 +00:00

Benjamin Lu

aa2169e108

test: reset queue history cap in browser tests (#11773 )

## Summary
- Reset `Comfy.Queue.MaxHistoryItems` in the shared browser-test
`comfyPage` setup so worker-persisted queue settings cannot leak between
tests.
- Keep the queue settings spec focused on asserting the setting behavior
without local cleanup scaffolding.

## Validation
- `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:65419
PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:65400
TEST_COMFYUI_DIR=/Users/ben/.codex/comfyui-preview-env/runtime/worktrees/fe-500-maxhistoryitems
pnpm exec playwright test
browser_tests/tests/queue/queueSettings.spec.ts --project=chromium
--workers=1`
- `pnpm exec eslint browser_tests/tests/queue/queueSettings.spec.ts
browser_tests/fixtures/ComfyPage.ts`
- `pnpm exec oxlint browser_tests/tests/queue/queueSettings.spec.ts
browser_tests/fixtures/ComfyPage.ts`
- `pnpm typecheck:browser`
- `git diff --check`
- commit hook: staged oxfmt, oxlint, eslint, `pnpm typecheck`, `pnpm
typecheck:browser`

Linear: FE-500

2026-05-04 21:31:36 +00:00

pythongosssss

3c50487c18

test: add test for MaxHistoryItems setting (#11750 )

## Summary

Adds test to ensure MaxHistoryItems limits both API query & client
rendering

## Changes

- **What**: 
- ensure limit is added to url
- ensure virtual grid is capped to limit

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11750-test-add-test-for-MaxHistoryItems-setting-3516d73d365081daa973ccfd8a7f479e)
by [Unito](https://www.unito.io)

2026-04-29 19:10:31 +00:00

3 Commits