Simula_r
bbfada561e
Fix/vue nodes auto scale ( #6664 )
...
## Summary
**Problem:** ensureCorrectLayoutScale scales up LG -> Vue. But doesn't
scale down from Vue -> LG.
**Solution:** Bi directional scaling.
**Bonus:** fix edge cases such as subgraphs, groups, and reroutes. Also,
set auto scale: true now that we 'preserve' LG scale.
**IMPORTANT:** useVueNodeResizeTracking.ts sets vue node height -
Litegraph.NODE_TITLE_HEIGHT on workflow load using a resize observer.
Reloading the page (loading a workflow) in Vue mode, will subtract
height each time. This can look like a problem caused by
ensureCorrectLayoutScale. It is not. Need to fix. Here was an attempt by
[removing the Litegraph.NODE_TITLE_HEIGHT
entirely](https://github.com/Comfy-Org/ComfyUI_frontend/pull/6643 ).
## Review Focus
Full lifecycle of loading workflows and switching between vue and lg.
Race conditions could be present. For example switching the mode using
keybind very fast.
## Screenshots (if applicable)
https://github.com/user-attachments/assets/5576b760-13a8-45b9-b8f7-64e1caf443c1
https://github.com/user-attachments/assets/46d6f870-df76-4084-968a-53cb629fc123
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-11-12 17:44:08 -07:00
Alexander Brown
874ef3ba0c
Lint: Add eslint import plugin ( #5955 )
...
## Summary
Adds the linter, turns on the recommended and a few extra rules, fixes
existing violations.
Doesn't prohibit `../../...` imports yet, that'll be it's own PR.
## Changes
- **What**: Consistent and fixable imports
- **Dependencies**: The plugin and parser
## Review Focus
How do you feel about the recommended rules?
What about the extra ones?
[Any
more](https://github.com/un-ts/eslint-plugin-import-x?tab=readme-ov-file#rules )
you'd want to turn on?
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5955-Lint-Add-eslint-import-plugin-2856d73d3650819985c0fb9ca3fa94b0 )
by [Unito](https://www.unito.io )
2025-10-07 20:31:00 -07:00
Christian Byrne
d9157925f5
make Vue nodes resizable ( #5936 )
...
## Summary
Implemented node resizing functionality for Vue nodes.
https://github.com/user-attachments/assets/a7536045-1fa5-401b-8d18-7c26b4dfbfc3
Resolves https://github.com/Comfy-Org/ComfyUI_frontend/issues/5675 .
## Review Focus
ResizeObserver as single source of truth pattern eliminates feedback
loops between manual resize and reactive layout updates. Intrinsic
content sizing calculation temporarily resets DOM styles to measure
natural content dimensions.
```mermaid
graph TD
A[User Drags Handle] --> B[Direct DOM Style Update]
B --> C[ResizeObserver Detects Change]
C --> D[Layout Store Update]
D --> E[Slot Position Sync]
style A fill:#f9f9f9,stroke:#333,color:#000
style E fill:#f9f9f9,stroke:#333,color:#000
```
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5936-make-Vue-nodes-resizable-2846d73d36508160b3b9db49ad8b273e )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: DrJKL <DrJKL@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-10-07 15:53:10 -07:00
Alexander Brown
c4c0e52e64
Refactor: Let LGraphNode handle more events itself ( #5709 )
...
## Summary
Don't route events up through GraphCanvas if the component itself can
handle the changes
## Changes
- **What**: Reduce the indirect access or action dispatch to
composables/stores.
## Review Focus
The behavior should be either equivalent or a little snappier than
before. Also, the local state in LGraphNode has (almost) all been
removed in favor of reacting to the nodeData prop.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5709-Refactor-Let-LGraphNode-handle-more-events-itself-2756d73d365081e6a88ce6241bceecc0 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-09-20 22:14:30 -07:00
Benjamin Lu
ff5d0923ca
Refactor vue slot tracking ( #5463 )
...
* add dom element resize observer registry for vue node components
* Update src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.ts
Co-authored-by: AustinMroz <austin@comfy.org >
* refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates
* chore: make TransformState interface non-exported to satisfy knip pre-push
* Revert "chore: make TransformState interface non-exported to satisfy knip pre-push"
This reverts commit 110ecf31da428752619c🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* remove typo comment
* convert to functional bounds collection
* remove inline import
* add interfaces for bounds mutations
* remove change log
* fix bounds collection when vue nodes turned off
* fix title offset on y
* move from resize observer to selection toolbox bounds
* refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates
* Fix conversion
* Readd padding
* revert churn reducings from layoutStore.ts
* Rely on RO for resize, and batch
* Improve churn
* Cache canvas offset
* rename from measure
* remove unused
* address review comments
* Update legacy injection
* nit
* Split into store
* nit
* perf improvement
---------
Co-authored-by: bymyself <cbyrne@comfy.org >
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-16 19:28:04 -07:00
Christian Byrne
b72e22f6be
Add Centralized Vue Node Size/Pos Tracking ( #5442 )
...
* add dom element resize observer registry for vue node components
* Update src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.ts
Co-authored-by: AustinMroz <austin@comfy.org >
* refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates
* chore: make TransformState interface non-exported to satisfy knip pre-push
* Revert "chore: make TransformState interface non-exported to satisfy knip pre-push"
This reverts commit 110ecf31da428752619c🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* remove typo comment
* convert to functional bounds collection
* remove inline import
* add interfaces for bounds mutations
* remove change log
* fix bounds collection when vue nodes turned off
* fix title offset on y
* move from resize observer to selection toolbox bounds
---------
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-10 22:38:49 -07:00
