Johnpaul
c1d763a6fa
fix(types): address CodeRabbit review comments
...
groupNodeManage.ts:
- Add bounds checking before accessing node indices in link/external loops
- Fix selectedNodeInnerIndex getter with proper runtime guards
- Change storeModification section param to string | symbol, removing casts
asyncDialog.ts:
- Initialize #resolve with no-op function for defensive safety
api.ts:
- Add warning log for unexpected non-array queue prompts
2026-01-16 03:55:18 +01:00
Johnpaul
7321c6e19e
fix(types): type ComfyDialog and ComfyAsyncDialog properly
...
ComfyDialog:
- Type constructor buttons parameter as HTMLButtonElement[] | null
- Type show method parameter as string | HTMLElement | HTMLElement[]
- Use definite assignment for textElement
ComfyAsyncDialog:
- Make class generic with DialogAction<T> type
- Type resolve function, show/showModal return types
- Fix button creation with proper HTMLButtonElement cast
- Add generic static prompt method
ManageGroupDialog:
- Update show method signature to match base class
- Extract nodeType from parameter for string comparisons
2026-01-16 03:29:26 +01:00
filtered
8713cd6e25
[TS] Require override keyword ( #3746 )
2025-05-03 19:54:45 -04:00
Chenlei Hu
a049e9ae2d
[TS] Enable strict mode ( #3136 )
2025-03-18 22:57:17 -04:00
Chenlei Hu
d8f074fea0
[Lint] Sort imports ( #2104 )
2024-12-30 17:26:37 -05:00
Chenlei Hu
c56533bb23
Workflow Management Reworked ( #1406 )
...
* Merge temp userfile
Basic migration
Remove deprecated isFavourite
Rename
nit
nit
Rework open/load
Refactor save
Refactor delete
Remove workflow dep on manager
WIP
Change map to record
Fix directory
nit
isActive
Move
nit
Add unload
Add close workflow
Remove workflowManager.closeWorkflow
nit
Remove workflowManager.storePrompt
move from commandStore
move more from commandStore
nit
Use workflowservice
nit
nit
implement setWorkflow
nit
Remove workflows.ts
Fix strict errors
nit
nit
Resolves circular dep
nit
nit
Fix workflow switching
Add openworkflowPaths
Fix store
Fix key
Serialize by default
Fix proxy
nit
Update path
Proper sync
Fix tabs
WIP
nit
Resolve merge conflict
Fix userfile store tests
Update jest test
Update tabs
patch tests
Fix changeTracker init
Move insert to service
nit
Fix insert
nit
Handle bookmark rename
Refactor tests
Add delete workflow
Add test on deleting workflow
Add closeWorkflow tests
nit
* Fix path
* Move load next/previous
* Move logic from store to service
* nit
* nit
* nit
* nit
* nit
* Add ChangeTracker.initialState
* ChangeTracker load/unload
* Remove app.changeWorkflow
* Hook to app.ts
* Changetracker restore
* nit
* nit
* nit
* Add debug logs
* Remove unnecessary checkState on graphLoad
* nit
* Fix strict
* Fix temp workflow name
* Track ismodified
* Fix reactivity
* nit
* Fix graph equal
* nit
* update test
* nit
* nit
* Fix modified state
* nit
* Fix modified state
* Sidebar force close
* tabs force close
* Fix save
* Add load remote workflow test
* Force save
* Add save test
* nit
* Correctly handle delete last opened workflow
* nit
* Fix workflow rename
* Fix save
* Fix tests
* Fix strict
* Update playwright tests
* Fix filename conflict handling
* nit
* Merge temporary and persisted ref
* Update playwright expectations
* nit
* nit
* Fix saveAs
* Add playwright test
* nit
2024-11-05 11:03:27 -05:00
Chenlei Hu
5611e90fda
Add ts-strict-ignore plugin ( #1235 )
...
* Add ts-strict-ignore plugin
* nit
* Add to typecheck script
2024-10-12 11:56:49 -04:00
Chenlei Hu
e179f75387
Apply new code format standard ( #217 )
2024-07-25 10:10:18 -04:00
Chenlei Hu
e05a33cb17
Rename to ts ( #92 )
...
Rename
Remove ts-nocheck, fix errors
Update state when graph cleared via UI (#88 )
Convert to ts, fix imports
Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com >
2024-07-05 21:18:32 -04:00
