Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-01 19:20:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,592 Commits 696 Branches 570 Tags
d279d020df4ae5dbdb134e7076ffb4dd330a758a
Commit Graph

12 Commits

Author SHA1 Message Date
bymyself
85b56f1323 debug: add console logs for terminal tab loading and increase test timeout 
Amp-Thread-ID: https://ampcode.com/threads/T-019c21eb-bc34-763e-a553-17ff79018dcf
 2026-02-02 21:23:43 -08:00
bymyself
048750599d fix: open terminal panel before checking for Logs tab 
The Logs tab is only visible when the panel is open. The previous
test was waiting for toBeAttached() but the tab wasn't rendered
until the panel was opened.

Amp-Thread-ID: https://ampcode.com/threads/T-019c21eb-bc34-763e-a553-17ff79018dcf
 2026-02-02 21:15:49 -08:00
bymyself
a95f7f88c2 test: use polling pattern to wait for async terminal tab registration 
Amp-Thread-ID: https://ampcode.com/threads/T-019c217a-e7e3-7209-a479-7f5e779fe7f9
 2026-02-02 20:23:22 -08:00
bymyself
9ede5be388 test: wait for terminal tab registration before testing panel switch 
Use waitFor to deterministically wait for the Logs tab to be attached
after the dynamic import completes, then test the panel switching behavior.

Amp-Thread-ID: https://ampcode.com/threads/T-019c1d90-5991-74b1-8c1c-5bcbcc7598f7
 2026-02-02 16:40:17 -08:00
bymyself
fa6cd67c27 fix: remove waitForTimeout and excessive comments 
Amp-Thread-ID: https://ampcode.com/threads/T-019c1d3b-a8fe-749e-aefa-3443ad7db6bd
 2026-02-01 23:33:13 -08:00
bymyself
b4ab8522fc fix: fallback to shortcuts panel when terminal tabs not yet loaded 
Terminal tabs are loaded asynchronously via dynamic import for code-splitting.
toggleBottomPanel() now falls back to shortcuts panel if terminal tabs
haven't loaded yet, ensuring the button always does something.

Updated tests to account for async terminal tab loading.

Amp-Thread-ID: https://ampcode.com/threads/T-019c1d20-f1fc-704a-ae48-1a417d14cb8b
 2026-02-01 23:00:46 -08:00
bymyself
60250031fc test: fix terminal tab detection using role selector instead of ID 
Amp-Thread-ID: https://ampcode.com/threads/T-019c1c14-d3a2-740c-a304-840f14971bde
 2026-02-01 20:08:04 -08:00
bymyself
c6bfdb6377 test: skip terminal switching test when terminal tabs unavailable 
Amp-Thread-ID: https://ampcode.com/threads/T-019c1c14-d3a2-740c-a304-840f14971bde
 2026-02-01 20:04:03 -08:00
GitHub Action
eb893f5812 [automated] Apply ESLint and Oxfmt fixes 2026-02-02 03:06:42 +00:00
bymyself
a650ce7478 test: wait for async terminal tab registration in bottomPanelShortcuts test 
Amp-Thread-ID: https://ampcode.com/threads/T-019c1c14-d3a2-740c-a304-840f14971bde
 2026-02-01 19:04:38 -08:00
Alexander Brown
82bacb82a7 test: add Playwright test tags for filtering (@smoke, @slow, @screenshot, domains) (#8441) 
## Summary

Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.

## Tags Added

| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |

## Usage Examples

```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke

# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow

# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot

# Run only canvas-related tests
pnpm test:browser -- --grep @canvas

# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```

## Implementation Details

- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`

## Test Plan

- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
 2026-01-29 16:34:56 -08:00
Johnpaul Chiwetelu
70c06d10bb Keyboard Shortcut Bottom Panel (#4635) 2025-08-07 11:51:23 -07:00