ComfyUI_frontend

Comfy-Org/ComfyUI_frontend

Fork 0

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-20 06:44:32 +00:00

Commit Graph

Author	SHA1	Message	Date
Terry Jia	9ecbb3af27	Feat/3d dropdown (#8765 ) ## Summary Add mesh_upload and upload_subfolder to combo input schema so WidgetSelect detects mesh uploads generically instead of hardcoding node type checks. Inject these flags in load3dLazy.ts so they are available before THREE.js loads. Also unify SUPPORTED_EXTENSIONS_ACCEPT across load3d and dropdown, pass uploadSubfolder prop through to WidgetSelectDropdown for correct upload path, and update error message to list all supported extensions. replacement for https://github.com/Comfy-Org/ComfyUI_frontend/pull/7975 (We should include thumbnail but not yet, will do it later) ## Screenshots (if applicable) https://github.com/user-attachments/assets/2cb4b1da-af4f-439b-9786-3ac780c2480d ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8765-Feat-3d-dropdown-3036d73d365081d8a10ee19d3ed7d295) by [Unito](https://www.unito.io) --------- Co-authored-by: Kelly Yang <124ykl@gmail.com>	2026-02-10 15:36:57 -05:00
Terry Jia	a2c8324c0a	fix: resolve 3D nodes missing after page refresh (#8711 ) ## Summary Await all registerNodeDef calls in registerNodesFromDefs to prevent race condition where lazy-loaded 3D node types (Load3D, Preview3D, SaveGLB) are not registered in LiteGraph before workflow loading. Replay lazily loaded extensions' beforeRegisterNodeDef hooks so that input type modifications (e.g. Preview3D → PREVIEW_3D) are applied correctly despite the extensions being registered mid-invocation. Fixes the issue introduced by code splitting (#8542) where THREE.js lazy import caused node registration to complete after workflow load. ## Screenshots (if applicable) before https://github.com/user-attachments/assets/370545dc-4081-4164-83ed-331a092fc690 after https://github.com/user-attachments/assets/bf9dc887-0076-41fe-93ad-ab0bb984c5ce	2026-02-06 22:05:44 -05:00
Alexander Brown	cbdc7d030f	feat: code splitting optimization - reduce initial bundle by 36% (#8542 ) ## Summary Reduces initial module preload from 12.94 MB to 8.24 MB (-4.7 MB, -36%). ## Changes - Split vendor chunks for better cache isolation (firebase, sentry, i18n, zod, etc.) - Exclude heavy optional chunks from initial preload: THREE.js, xterm, tiptap, chart.js, yjs - Lazy load 16 dialog components in dialogService - Add \endor-yjs\ chunk for CRDT library ## Metrics \| Metric \| Before \| After \| \|--------\|--------\|-------\| \| Initial preload \| 12.94 MB \| 8.24 MB \| \| vendor-other \| 4,006 KB \| 2,156 KB \| \| dialogService \| 1,860 KB \| 1,304 KB \| All excluded chunks still load on-demand when their features are used. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8542-feat-code-splitting-optimization-reduce-initial-bundle-by-36-2fb6d73d36508146aaf7fdaed3274033) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>	2026-02-02 19:05:28 -08:00

Author

SHA1

Message

Date

Terry Jia

9ecbb3af27

Feat/3d dropdown (#8765 )

## Summary
Add mesh_upload and upload_subfolder to combo input schema so
WidgetSelect detects mesh uploads generically instead of hardcoding node
type checks. Inject these flags in load3dLazy.ts so they are available
before THREE.js loads.

Also unify SUPPORTED_EXTENSIONS_ACCEPT across load3d and dropdown, pass
uploadSubfolder prop through to WidgetSelectDropdown for correct upload
path, and update error message to list all supported extensions.

replacement for https://github.com/Comfy-Org/ComfyUI_frontend/pull/7975

(We should include thumbnail but not yet, will do it later)

## Screenshots (if applicable)


https://github.com/user-attachments/assets/2cb4b1da-af4f-439b-9786-3ac780c2480d

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8765-Feat-3d-dropdown-3036d73d365081d8a10ee19d3ed7d295)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Kelly Yang <124ykl@gmail.com>

2026-02-10 15:36:57 -05:00

Terry Jia

a2c8324c0a

fix: resolve 3D nodes missing after page refresh (#8711 )

## Summary
Await all registerNodeDef calls in registerNodesFromDefs to prevent race
condition where lazy-loaded 3D node types (Load3D, Preview3D, SaveGLB)
are not registered in LiteGraph before workflow loading.

Replay lazily loaded extensions' beforeRegisterNodeDef hooks so that
input type modifications (e.g. Preview3D → PREVIEW_3D) are applied
correctly despite the extensions being registered mid-invocation.

Fixes the issue introduced by code splitting (#8542) where THREE.js lazy
import caused node registration to complete after workflow load.

## Screenshots (if applicable)
before

https://github.com/user-attachments/assets/370545dc-4081-4164-83ed-331a092fc690

after

https://github.com/user-attachments/assets/bf9dc887-0076-41fe-93ad-ab0bb984c5ce

2026-02-06 22:05:44 -05:00

Alexander Brown

cbdc7d030f

feat: code splitting optimization - reduce initial bundle by 36% (#8542 )

## Summary

Reduces initial module preload from 12.94 MB to 8.24 MB (-4.7 MB, -36%).

## Changes

- Split vendor chunks for better cache isolation (firebase, sentry,
i18n, zod, etc.)
- Exclude heavy optional chunks from initial preload: THREE.js, xterm,
tiptap, chart.js, yjs
- Lazy load 16 dialog components in dialogService
- Add \endor-yjs\ chunk for CRDT library

## Metrics

| Metric | Before | After |
|--------|--------|-------|
| Initial preload | 12.94 MB | 8.24 MB |
| vendor-other | 4,006 KB | 2,156 KB |
| dialogService | 1,860 KB | 1,304 KB |

All excluded chunks still load on-demand when their features are used.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8542-feat-code-splitting-optimization-reduce-initial-bundle-by-36-2fb6d73d36508146aaf7fdaed3274033)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>

2026-02-02 19:05:28 -08:00

3 Commits