Marcel Petrick
d0e81cdd33
fix(docs): correct typos in comments and strings found during code view ( #5880 )
...
Non-functional changes only:
- Fixed minor spelling mistakes in comments
- Corrected typos in user-facing strings
- No variables, logic, or functional code was modified.
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5880-fix-docs-correct-typos-in-comments-and-strings-found-during-code-view-27f6d73d3650815db62af6115991304a )
by [Unito](https://www.unito.io )
---------
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: Alexander Brown <DrJKL0424@gmail.com >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
2025-10-01 18:35:38 -07:00
Benjamin Lu
ff5d0923ca
Refactor vue slot tracking ( #5463 )
...
* add dom element resize observer registry for vue node components
* Update src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.ts
Co-authored-by: AustinMroz <austin@comfy.org >
* refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates
* chore: make TransformState interface non-exported to satisfy knip pre-push
* Revert "chore: make TransformState interface non-exported to satisfy knip pre-push"
This reverts commit 110ecf31da .
* Revert "refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates"
This reverts commit 428752619c .
* [refactor] Improve resize tracking composable documentation and test utilities
- Rename parameters in useVueElementTracking for clarity (appIdentifier, trackingType)
- Add comprehensive docstring with examples to prevent DOM attribute confusion
- Extract mountLGraphNode test utility to eliminate repetitive mock setup
- Add technical implementation notes documenting optimization decisions
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
* remove typo comment
* convert to functional bounds collection
* remove inline import
* add interfaces for bounds mutations
* remove change log
* fix bounds collection when vue nodes turned off
* fix title offset on y
* move from resize observer to selection toolbox bounds
* refactor(vue-nodes): typed TransformState InjectionKey, safer ResizeObserver sizing, centralized slot tracking, and small readability updates
* Fix conversion
* Readd padding
* revert churn reducings from layoutStore.ts
* Rely on RO for resize, and batch
* Improve churn
* Cache canvas offset
* rename from measure
* remove unused
* address review comments
* Update legacy injection
* nit
* Split into store
* nit
* perf improvement
---------
Co-authored-by: bymyself <cbyrne@comfy.org >
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
2025-09-16 19:28:04 -07:00
AustinMroz
1ae67dd9d1
Fix double click primitive widgets with subgraphs ( #5372 )
...
Double clicking the input slot of a node creates and connects a
primitive widget. However, this code would always add the created
primitive to the root graph.
2025-09-05 10:35:55 -07:00
Alexander Brown
3fbcf4aa7e
knip: YOLO pass, all the unused exports enabled, YAGNI for the rest ( #5313 )
...
* knip: Enable unusedBinaries, add two exceptions
* knip: YOLO pass, all the unused exports enabled.
Paired with @christian-byrne to allow for some special cases to remain with custom knip ignore tags.
* knip: remove post-rebase
2025-09-04 22:29:44 -07:00
Benjamin Lu
fef02e5f56
[refactor] Migrate litegraph imports from npm package to local subtree
...
- Updated all imports from '@comfyorg/litegraph' to '@/lib/litegraph/src/'
- Replaced deep dist imports with direct source paths
- Updated CSS import in main.ts
- All imports now use the @ alias consistently
2025-08-03 22:06:29 -04:00
Christian Byrne
dd14144f47
[fix] Update Search & Replace to support nodes in subgraphs ( #4576 )
2025-07-29 00:10:56 -07:00
filtered
0c4339f652
[TS] Update callbacks using CanvasMouseEvent #1104 ( #4358 )
2025-07-05 11:53:44 -07:00
Chenlei Hu
df86da3d67
[Bug] Add null check on customSpec being null ( #3810 )
2025-05-07 17:09:52 -04:00
filtered
3aea2c120a
Update widget types to match Litegraph changes ( #3808 )
2025-05-08 06:56:53 +10:00
filtered
8713cd6e25
[TS] Require override keyword ( #3746 )
2025-05-03 19:54:45 -04:00
filtered
c82401c61c
[TS] Fix strict type on chain callback, widgetInput ( #3727 )
2025-05-01 21:29:43 -04:00
Chenlei Hu
2b024bb186
[Cleanup] Remove LGraphNode.isValidWidgetLink ( #3549 )
2025-04-21 15:48:55 -04:00
filtered
f1a25989d7
Fix corrupt workflow permanently corrupts session ( #3484 )
2025-04-17 10:18:14 -04:00
Chenlei Hu
a500a96c4a
[TS] Fix widget GET_CONFIG on loading primitive nodes ( #3374 )
2025-04-09 17:48:28 -04:00
Chenlei Hu
609496957b
[Cleanup] Remove WidgetOptions.forceInput ( #3362 )
2025-04-09 11:36:35 -04:00
Chenlei Hu
ac53296b2e
Support associated socket for widgets ( #3326 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-04-06 11:50:21 -04:00
Chenlei Hu
30420f2c0a
[TS] Add null checks to widgetInputs.ts ( #3312 )
2025-04-02 15:48:46 -04:00
Chenlei Hu
39c3a57c11
[Cleanup] Remove handling of legacy slot widget config ( #3311 )
2025-04-02 13:58:06 -04:00
Chenlei Hu
cfaf769a65
[TS] Properly type slot widget ( #3305 )
2025-04-01 15:13:46 -04:00
Chenlei Hu
28def833f9
[TS] Fix node constructor signature ( #3276 )
2025-03-29 20:55:11 -04:00
filtered
f8a2c90138
Fix drag new link from reroute to widget ( #3214 )
2025-03-23 22:29:51 -04:00
Comfy Org PR Bot
e6e7449ece
[chore] Update litegraph to 0.11.0-1 ( #3190 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
2025-03-23 03:49:44 +11:00
Chenlei Hu
a049e9ae2d
[TS] Enable strict mode ( #3136 )
2025-03-18 22:57:17 -04:00
Chenlei Hu
7af003fcab
[TS] Enable noUnusedParameters ( #3110 )
2025-03-17 16:47:45 -04:00
Chenlei Hu
7e66e99c3a
[TS] Enable noUnusedLocals ( #3108 )
2025-03-17 16:20:56 -04:00
AustinMroz
f583015a14
Fix regression when configuring graph with missing converted input ( #3066 )
2025-03-16 11:36:42 -04:00
filtered
ba8c1ee823
Remove legacy code (follow-up on #2925 ) ( #2930 )
2025-03-09 13:44:55 -04:00
filtered
f53c04834f
Add support for Litegraph LinkConnector ( #2925 )
2025-03-09 09:37:47 +11:00
Chenlei Hu
f593f3caa4
[Schema] ComfyNodeDefV2 schema ( #2847 )
2025-03-04 09:15:16 -05:00
Chenlei Hu
b2f3d85e24
[Cleanup] Remove manual double click delay ( #2840 )
2025-03-03 17:36:26 -05:00
Chenlei Hu
8affd7eec7
[Cleanup] Remove combo connection type check ( #2838 )
2025-03-03 17:35:18 -05:00
Chenlei Hu
603825b2a0
[Refactor] Add util to merge input spec ( #2834 )
2025-03-03 15:23:47 -05:00
Chenlei Hu
f5c21814f9
Remove broken/unused widget[TARGET] ( #2795 )
2025-03-01 21:26:50 -05:00
Chenlei Hu
0175db58bb
[Type] Add type annotations for widgetInputs litegraph hooks ( #2793 )
2025-03-01 19:27:21 -05:00
Chenlei Hu
09ab14ac81
[Type] Disallow type upcasting for node input spec ( #2790 )
2025-03-01 16:58:45 -05:00
Chenlei Hu
2b212f9701
S&R improved filename sanitizing ( #2784 )
...
Co-authored-by: typpos <28550406+typpos@users.noreply.github.com >
2025-03-01 10:47:42 -05:00
Chenlei Hu
1d95d639e9
[Refactor] Extract nodeDefSchema from apiSchema ( #2756 )
2025-02-27 13:39:23 -05:00
Chenlei Hu
cdf42d5ad7
[Refactor] Move zod schemas to schemas/ folder ( #2753 )
2025-02-27 13:05:01 -05:00
Chenlei Hu
96f02dbf80
[Refactor] Use util.clone in mergeIfValid ( #2752 )
2025-02-27 11:47:56 -05:00
Chenlei Hu
ab9c65f28b
Type widgetInputs ( #2741 )
2025-02-26 18:01:56 -05:00
Chenlei Hu
a784abef0d
Type INodeOutputSlot widget hack on PrimitiveNode ( #2728 )
2025-02-25 19:34:23 -05:00
Chenlei Hu
156013aa24
[Reland] Restrict applyToGraph to PrimitiveNode ( #2724 )
2025-02-25 10:54:21 -05:00
Chenlei Hu
d3dda14267
Update litegraph 0.8.95 ( #2718 )
2025-02-24 19:48:44 -05:00
Chenlei Hu
064e982f01
Revert "[Refactor] Extract RerouteNode as a separate file" ( #2678 )
2025-02-21 22:57:19 -05:00
Chenlei Hu
85d04f6814
[Refactor] Extract RerouteNode as a separate file ( #2668 )
2025-02-21 15:04:47 -05:00
Chenlei Hu
3f4d11c63a
Inplace widget to input conversion ( #2588 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-02-16 13:41:32 -05:00
Chenlei Hu
acfb95f8d4
Use LGraphNode.setSize ( #2555 )
2025-02-14 11:02:56 -05:00
Chenlei Hu
8bb785c5e4
Show convert to widget option slot context menu ( #2538 )
2025-02-12 16:07:19 -05:00
Chenlei Hu
340513e27f
Type INodeSlot.widget ( #2463 )
2025-02-07 14:33:21 -05:00
filtered
d2e9943e79
Add convert to input for the clicked widget ( #2357 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-01-26 07:06:41 -05:00