Christian Byrne
23e0d26ff8
add fuzzy searching to assets dialog ( #6286 )
...
## Summary
Add `useFuse` for assets searching to enable fuzzy searching with typo
tolerance.
https://github.com/user-attachments/assets/0c55bb77-3223-45ab-8c05-713f8ce4e58b
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6286-add-fuzzy-searching-to-assets-dialog-2976d73d3650813da63acadde2cf49c6 )
by [Unito](https://www.unito.io )
2025-10-25 14:02:46 -07:00
Christian Byrne
8120ed9dfa
load assets browser before fetch completes and show loading state ( #6189 )
...
## Summary
Moves the fetch and post-fetch logic associated with the asset browser
into the component and shows a loading state while fetching.
To test, use this branch:
https://github.com/comfyanonymous/ComfyUI/pull/10045
https://github.com/user-attachments/assets/718974d5-efc7-46a0-bcd6-e82596d4c389
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6189-load-assets-browser-before-fetch-completes-and-show-loading-state-2946d73d365081879d1bd05d86e8c036 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-23 13:43:34 -07:00
Arjan Singh
4555656bf2
feat(AssetCard): remove model size ( #6227 )
...
## Summary
Remove model file sizes.
It was confusing some users who thought that was they were being asked
to download them locally.
## Changes
- Remove `formattedSize` from `AssetDisplayItem`.
- Remove associated code.
-
## Screenshots
<img width="1299" height="512" alt="Screenshot 2025-10-23 at 11 22
06 AM"
src="https://github.com/user-attachments/assets/625b588b-a605-49dd-97a2-16bcd604aef2 "
/>
<!-- Add screenshots or video recording to help explain your changes -->
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6227-feat-AssetCard-remove-model-size-2956d73d36508155930fdb4d2db2522a )
by [Unito](https://www.unito.io )
2025-10-23 18:48:30 +00:00
Arjan Singh
abf2b3b980
Full Asset Selection Experience (Assets API) ( #5900 )
...
## Summary
Full Integration of Asset Browsing and Selection when Assets API is
enabled.
## Changes
1. Replace Model Left Side Tab with experience
2. Configurable titles for the Asset Browser Modal
3. Refactors to simplify callback code
4. Refactor to make modal filters reactive (they change their values
based on assets displayed)
5. Add `browse()` mode with ability to create node directly from the
Asset Browser Modal (in `browse()` mode)
## Screenshots
Demo of many different types of Nodes getting configured by the Modal
https://github.com/user-attachments/assets/34f9c964-cdf2-4c5d-86a9-a8e7126a7de9
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5900-Feat-asset-selection-cloud-integration-2816d73d365081ccb4aeecdc14b0e5d3 )
by [Unito](https://www.unito.io )
2025-10-03 20:34:59 -07:00
Arjan Singh
13ce23399c
Asset Browser Design Review + Filters ( #5737 )
...
## Summary
Fixed design feedback and wired up the filter controls.
## Review Focus
Design Feedback:
-
[4872888](48728881af9a0b63edce07f22f807423e6fa97237801ed9e28https://github.com/user-attachments/assets/d82088e4-7d72-4c6f-904e-5180774d64a5 "
/>
<img width="1794" height="793" alt="Screenshot 2025-09-23 at 1 03 22 PM"
src="https://github.com/user-attachments/assets/56eac2ba-5ecc-4a20-843f-ce683dea668c "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5737-Asset-Browser-Design-Review-Filters-2776d73d3650813e890bd16fa6a0433f )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: GitHub Action <action@github.com >
2025-09-25 11:17:26 -07:00
Arjan Singh
fd12591756
[feat] integrate asset browser with widget system ( #5629 )
...
## Summary
Add asset browser dialog integration for combo widgets with full
animation support and proper state management.
(Thank you Claude from saving me me from merge conflict hell on this
one.)
## Changes
- Widget integration: combo widgets now use AssetBrowserModal for
eligible asset types
- Dialog animations: added animateHide() for smooth close transitions
- Async operations: proper sequencing of widget updates and dialog
animations
- Service layer: added getAssetsForNodeType() and getAssetDetails()
methods
- Type safety: comprehensive TypeScript types and error handling
- Test coverage: unit tests for all new functionality
- Bonus: fixed the hardcoded labels in AssetFilterBar
Widget behavior:
- Shows asset browser button for eligible widgets when asset API enabled
- Handles asset selection with proper callback sequencing
- Maintains widget value updates and litegraph notification
## Review Focus
I will call out some stuff inline.
## Screenshots
https://github.com/user-attachments/assets/9d3a72cf-d2b0-445f-8022-4c49daa04637
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5629-feat-integrate-asset-browser-with-widget-system-2726d73d365081a9a98be9a2307aee0b )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
2025-09-20 11:44:18 -07:00
Arjan Singh
dfa1cbba4f
Asset Browser Modal Component ( #5607 )
...
* [ci] ignore playwright mcp directory
* [feat] add AssetBrowserModal
And all related sub components
* [feat] reactive filter functions
* [ci] clean up storybook config
* [feat] add sematic AssetCard
* [fix] i love lucide
* [fix] AssetCard layout issues
* [fix] add AssetBadge type
* [fix] simplify useAssetBrowser
* [fix] modal layout
* [fix] simplify useAssetBrowserDialog
* [fix] add tailwind back to storybook
* [fix] better reponsive layout
* [fix] missed i18n string
* [fix] missing i18n translations
* [fix] remove erroneous prevent on keyboard.space
* [feat] add asset metadata validation utilities
* [fix] remove erroneous test code
* [fix] remove forced min and max width on AssetCard
* [fix] import statement nits
2025-09-17 16:17:09 -07:00
