Alexander Brown
22ff808d59
fix(browser_tests): use getByRole for interactive elements
...
Replace fragile CSS selectors with Playwright getByRole() for better
accessibility-based testing:
- bottomPanelShortcuts.spec.ts: button[aria-label] -> getByRole
- execution.spec.ts: .p-dialog-close-button -> getByRole
- backgroundImageUpload.spec.ts: button:has(.pi-*) -> getByRole
- nodeHelp.spec.ts: button:has(.pi-question) -> getByRole
- BaseDialog.ts: closeButton uses getByRole
- ComfyNodeSearchBox.ts: Add button uses getByRole
- Topbar.ts: close-button uses getByRole
Amp-Thread-ID: https://ampcode.com/threads/T-019c155c-92e1-76f3-b6ce-7fc3ffa11582
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 10:46:11 -08:00
Alexander Brown
681709f8e7
refactor(browser_tests): remove deprecated proxy methods from ComfyPage
...
Migrate all test callers to use helper classes directly:
- nodeOps: getGraphNodesCount, getNodeRefById, selectNodes, etc.
- canvasOps: dragAndDrop, zoom, pan, resetView, etc.
- subgraph: rightClickInputSlot, connectToOutput, etc.
Reduces ComfyPage.ts from 1335 to 1085 lines (-250 lines).
Amp-Thread-ID: https://ampcode.com/threads/T-019c1318-58b7-757f-801c-5b676f0d3421
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 00:52:33 -08:00
Alexander Brown
82bacb82a7
test: add Playwright test tags for filtering (@smoke, @slow, @screenshot, domains) ( #8441 )
...
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: GitHub Action <action@github.com >
2026-01-29 16:34:56 -08:00
Alexander Brown
bf8d9de1c1
Fix: Flaky Playwright Tests: retry some assertions ( #7389 )
...
## Summary
Retries the widget value change check for up to 2 whole seconds.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7389-Fix-remoteWidgets-Playwright-test-add-retry-for-assertion-2c66d73d3650814e98b6fdfc83f6d3d6 )
by [Unito](https://www.unito.io )
2025-12-11 14:02:23 -08:00
Alexander Brown
5c01861f4e
Tests: Playwright test timeouts ( #7231 )
...
## Summary
See where we can use proper DOM waiting instead of waitForTimeout.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7231-WIP-Playwright-test-timeouts-2c36d73d3650812b966ac3d9c338dfd4 )
by [Unito](https://www.unito.io )
2025-12-08 15:50:35 -08:00
Benjamin Lu
bc4549244e
test(e2e): align test default menu to Top; make legacy specs explicit ( #5746 )
...
## Summary
UseNewMenu has been defaulted to Top in the app for over a year;
Playwright’s test default lagged behind. This PR aligns the test default
with reality and keeps legacy specs stable.
## Changes
- tests(e2e): default to 'Top' via fixture; specs that previously relied
on the old implicit default now explicitly set 'Comfy.UseNewMenu' to
'Disabled'.
- docs(browser-tests): remove outdated README note suggesting tests set
'Top' manually.
## Review Focus
- Intentional uses of 'Top' and 'Bottom' remain unchanged.
- Confirm ComfyPage default remains 'Top' (see
browser_tests/fixtures/ComfyPage.ts).
## Screenshots (if applicable)
N/A
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5746-test-e2e-align-test-default-menu-to-Top-make-legacy-specs-explicit-2786d73d365081218d06c1346f3ae18e )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-09-24 18:43:22 -07:00
Chenlei Hu
2425e32d51
Partial execute to selected output nodes ( #3818 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-05-08 11:44:26 -04:00
Chenlei Hu
cb06d96930
[Refactor] Use NodeSlot.hasErrors API ( #3284 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-03-30 20:10:28 -04:00
