4 Commits

Author	SHA1	Message	Date
AustinMroz	13b42d9b59	Ensure dynamic combo children cleanup state (#13073) ... #12617 introduced a regression in Dynamic Combos. If two options have child widgets of the same name (such as `bit_depth` on `Save Image (Advanced)`), then widget state would be incorrectly shared between the two widgets. This is resolved by having removed widgets also delete their state. There was previous interest in having widgets of this type keep state when valid. This interest remains, but will require a more controlled intentional implementation in the future. Since the bit depth options on `Save Image (Advanced)` could potentially be expanded in the future, this PR specifically adds a new devtools node for testing with. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>	2026-06-26 01:08:06 +00:00
AustinMroz	2717d59451	Fix reactivity of vue subgraph price badges (#12029) ... When a subgraph contains partner nodes with price badges, those badges are also displayed on the subgraphNode. The reactivity here was spotty: The price badges would fail to display unless the user had navigated into the subgraph on the current page load. Fixing this is performed in 2 steps: - Firing a `node:property:changed` event when the badges contained in a subgraph are updated - Extending the reactivity updates so that badges update in vue mode despite using the litegraph badge getter. This PR also includes a minor styling tweak to fix text alignment on price badges | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/56a95cbe-12c9-43b0-8664-34e52b6415ac" /> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/bf4a0d81-21e4-4afc-946e-eba5967f1715" />| Resolves FE-346 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12029-Fix-reactivity-of-vue-subgraph-price-badges-3586d73d3650813cb12fe265090940e4) by [Unito](https://www.unito.io)	2026-05-20 11:22:42 -07:00
AustinMroz	fd1a8e9432	Fix legacy widget width in app mode (#11574) ... When in app mode, widgets can be drawn with size different from the size of the parent node. Mouse events on legacy canvas widgets require that the client code query the current state of the node and widget to determine if any elements are being interacted with. This PR sets the `widget.width` property when a legacy canvas widget draw operation occurs so that custom nodes can properly resolve subsequent mouse events. At current, no core nodes exist that utilize legacy widgets. As a result the setup code to test this bug fix is slightly involved. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11574-Fix-legacy-widget-width-in-app-mode-34b6d73d365081caaa34c6204f8361f6) by [Unito](https://www.unito.io)	2026-04-29 09:31:57 -07:00
Christian Byrne	14c07fd734	[refactor] reorganize devtools test nodes into modules (#6020) ... ## Summary Refactored monolithic devtools node definitions into organized module structure for better maintainability and separation of concerns. ## Changes - **What**: Split 700+ line `dev_nodes.py` into modular structure under `tools/devtools/nodes/` with categorized files: `errors.py`, `inputs.py`, `models.py`, `remote.py` - **Dependencies**: None ## Review Focus Module import structure and ensure all node registrations are properly preserved in the consolidated mappings. **Before:** ``` tools/devtools/ ├── __init__.py └── dev_nodes.py (738 lines) ``` **After:** ``` tools/devtools/ ├── __init__.py ├── dev_nodes.py (65 lines - imports only) └── nodes/ ├── __init__.py (consolidated mappings) ├── errors.py (error/debug nodes) ├── inputs.py (input/widget nodes) ├── models.py (model/patch nodes) └── remote.py (remote/combo nodes) ``` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6020-refactor-reorganize-devtools-test-nodes-into-modules-2896d73d365081e89efef7e88ca8fee3) by [Unito](https://www.unito.io)	2025-10-11 15:29:29 -07:00