GitHub Action
e5acd8cdaf
[automated] Apply ESLint and Oxfmt fixes
2026-02-01 10:52:01 +00:00
Alexander Brown
ed63f4b225
docs: add type safety guidelines from as-any remediation
...
Lessons learned from purging 40 `as any` instances from browser_tests.
TypeScript guidance additions:
- Type assertion hierarchy (from virtuous to forbidden)
- Zod schema rules (no z.any(), no test settings in production)
- Public API contract preservation
Playwright guidance additions:
- Acceptable vs forbidden type assertion patterns
- Test-local type helpers pattern (e.g., TestSettingId)
- How to access internal store state without polluting APIs
Amp-Thread-ID: https://ampcode.com/threads/T-019c1833-2352-728b-a523-a8f440fd3ba1
Co-authored-by: Amp <amp@ampcode.com >
2026-02-01 02:49:16 -08:00
Alexander Brown
b56045c462
fix: browser_tests Phase 1 - mechanical fixes
...
- Rename dragAndDrop to dragDrop (7 occurrences)
- Add override modifiers in SidebarTab.ts (4 fixes)
- Remove .ts import extensions in actionbar.spec.ts
- Prefix unused variables with underscore (9 files)
- Fix ESLint import() type annotation in globals.d.ts
Reduces typecheck:browser errors from 229 to 215
Amp-Thread-ID: https://ampcode.com/threads/T-019c1787-c781-761d-b95a-4844e909e64c
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 21:57:58 -08:00
Alexander Brown
20fdf46c5c
Update agent docs to use local version for playwright tests.
2026-01-31 15:45:00 -08:00
Alexander Brown
aa5125cef6
Chore: Oxfmt formatting pass ( #8341 )
...
## Summary
Expanding the covered files to format. One-time formatting pass. To be
added to the `.git-blame-ignore-revs`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8341-Chore-Oxfmt-formatting-pass-2f56d73d365081f2988fcb7570f9a2a1 )
by [Unito](https://www.unito.io )
2026-01-27 17:59:19 -08:00
Alexander Brown
e4308a7258
refactor: rename CLAUDE.md to AGENTS.md ( #8052 )
...
## Summary
Pure rename of CLAUDE.md files to AGENTS.md (no content changes).
## Changes
| Old Path | New Path |
|----------|----------|
| `.github/CLAUDE.md` | `.github/AGENTS.md` |
| `.storybook/CLAUDE.md` | `.storybook/AGENTS.md` |
| `browser_tests/CLAUDE.md` | `browser_tests/AGENTS.md` |
| `src/CLAUDE.md` | `src/AGENTS.md` |
| `src/components/CLAUDE.md` | `src/components/AGENTS.md` |
| `src/lib/litegraph/CLAUDE.md` | `src/lib/litegraph/AGENTS.md` |
Root `CLAUDE.md` deleted (content will be merged into `AGENTS.md` in
follow-up PR).
## Follow-up
A second PR will add glob-based guidance files and consolidate
redundancies.
---------
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2026-01-16 13:32:18 -08:00
