Terry Jia
643533c572
fix: should allow autoCols=true when server doesn't provide size ( #7132 )
...
## Summary
set autoCols = true by default for Logs Terminal
## Changes
Previously, the logs terminal had autoCols: false to preserve
server-side progress bar rendering, However, this caused large black
empty areas when the server terminal was narrower than the UI panel,
Many server environments don't provide terminal size at all, making this
tradeoff not worthwhile.
The original implementation set autoCols: false because the server
renders progress bars based on its own terminal width. If the frontend
used a different column count, progress bars would display incorrectly
(e.g., wrapped or truncated).
However, this created a poor user experience:
1. The terminal only filled a portion of the panel width (often 80
columns)
2. The remaining space appeared as a large black empty area
3. Many backend environments don't provide size data at all, making the
fixed-width approach pointless
fix https://github.com/Comfy-Org/ComfyUI_frontend/issues/7117
## Screenshots (if applicable)
before
https://github.com/user-attachments/assets/e38af410-9cf1-4175-8acc-39d11a5b73ce
after
https://github.com/user-attachments/assets/3d180318-609f-44c5-aac5-230f9e4ef596
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7132-fix-should-allow-autoCols-true-when-server-doesn-t-provide-size-2be6d73d365081e7bf3bf5988bdba39a )
by [Unito](https://www.unito.io )
2025-12-03 22:18:27 -05:00
pythongosssss
984ebef416
Floating Menus - UI rework ( #5980 )
...
## Summary
Enhancing and further modernizing the UI, giving users more usable area
whilst keeping farmiliar positioning and feel of elements.
## Changes
- **What**: Significant restructure of the UI elements, changing
elements from large blocks to floating elements, updating:
- Side toolbar menu (floating style, supports small/normal mode,
combines to scroll on height overflow)
- Bottom tabs panel (floating style, tabs redesigned)
- Action bar (support for docking/undocking menu)
- Added login/user menu button to top right
- Restyled breadcrumbs (still collapse when overflows)
- Add litegraph support for fps info position (so it isn't covered by
the sidebar)
- **Breaking**:
- Removed various elements and added new ones, I have tested custom
sidebars, custom actions, etc but if scripts are inserting elements into
"other" elements they may have been (re)moved.
- Remove support for bottom menu
- Remove support for 2nd-row tabs
## Screenshots
<img width="1116" height="907" alt="ui"
src="https://github.com/user-attachments/assets/b040a215-67d3-4c88-8c4d-f402a16a34f6 "
/>
https://github.com/user-attachments/assets/571dbda5-01ec-47e8-b235-ee1b88c93dd0
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5980-Floating-Menus-UI-rework-2866d73d3650810aac60cc1afe979b60 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-10-16 18:12:09 -07:00
Alexander Brown
b943c0fa75
Lint: Add tailwind linter ( #5984 )
...
## Summary
Adds the [tailwind lint
plugin](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#eslint-plugin-tailwindcss )
and fixes the currently fixable rules ([v4 is still in
beta](https://github.com/francoismassart/eslint-plugin-tailwindcss/?tab=readme-ov-file#about-tailwind-css-4-support )).
## Changes
- **What**: Enforces things like consistent class order, and eventually
can prohibit extra classes that could be utilities instead
- **Dependencies**: The plugin and its types
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5984-Lint-Add-tailwind-linter-2866d73d365081d89db0d998232533bb )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
2025-10-08 19:39:14 -07:00
Marcel Petrick
d0e81cdd33
fix(docs): correct typos in comments and strings found during code view ( #5880 )
...
Non-functional changes only:
- Fixed minor spelling mistakes in comments
- Corrected typos in user-facing strings
- No variables, logic, or functional code was modified.
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5880-fix-docs-correct-typos-in-comments-and-strings-found-during-code-view-27f6d73d3650815db62af6115991304a )
by [Unito](https://www.unito.io )
---------
Signed-off-by: Marcel Petrick <mail@marcelpetrick.it >
Co-authored-by: Alexander Brown <DrJKL0424@gmail.com >
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com >
2025-10-01 18:35:38 -07:00
Alexander Brown
08220d50d9
Lint: Turn on rules that should allow for verbatimModuleSyntax ( #5616 )
...
* lint: turn on type import rules setting up for verbatimModuleSyntax
* lint: --fix for type imports
2025-09-16 22:03:41 -07:00
Chenlei Hu
a03841cb1a
[lint] Enable plugin vue recommended rules ( #3403 )
2025-04-11 12:53:20 -04:00
Chenlei Hu
dc5d7ea1be
[lint] Enforce @typescript-eslint/no-floating-promises ( #3402 )
2025-04-11 12:19:22 -04:00
Chenlei Hu
2db29fc2af
[TS] Fix ts-strict errors in Vue components (Part 1) ( #3119 )
2025-03-17 21:15:00 -04:00
Chenlei Hu
cdf42d5ad7
[Refactor] Move zod schemas to schemas/ folder ( #2753 )
2025-02-27 13:05:01 -05:00
Chenlei Hu
6525ae7cf4
[Refactor] Rename hooks/ to composables/ ( #2437 )
2025-02-05 15:05:56 -05:00
Chenlei Hu
ff445f5c95
Apply min col on logs terminal for colab ( #2260 )
2025-01-15 17:16:33 -05:00
Chenlei Hu
84b652a281
[CodeHealth] Convert useAutoSize to kwargs ( #2259 )
2025-01-15 17:06:45 -05:00
Chenlei Hu
d8f074fea0
[Lint] Sort imports ( #2104 )
2024-12-30 17:26:37 -05:00
pythongosssss
b5f0c4bf73
[Electron] Terminal commands ( #1531 )
...
* Add live terminal output
* Fix scrolling
* Refactor loading
* Fallback to polling if endpoint fails
* Comment
* Move clientId to executionStore
Refactor types
* Remove polling
* wip terminal command input
* Refactor to use node-pty
* Hide tabs if not electron
* Lint fix
* ts fix
* Refactor tab components
2024-11-17 14:43:08 -05:00
