2 Commits

Author	SHA1	Message	Date
Alexander Brown	0132c77c7d	test: harden 82 Playwright specs for deterministic CI runs (#10967) ... ## Summary Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI runs by replacing race-prone patterns with retry-safe alternatives. No source code changes -- only `browser_tests/` is touched. ## Changes - **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers): | Fix class | Sites | Examples | |-----------|-------|---------:| | `expect(await ...)` -> `expect.poll()` | ~153 | interaction, defaultKeybindings, workflows, featureFlags | | `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 | menu, linkInteraction, assets, bottomPanelShortcuts | | `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 | contextMenu, rightClickMenu, subgraphHelper | | Redundant `nextFrame()` removed | many | defaultKeybindings, minimap, builderSaveFlow | | `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction (graphdialog dismiss guard) | | `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog fixture | | ContextMenu `waitForHidden` simplified (check-then-act race removed) | 1 | ContextMenu fixture | | Non-deterministic node order -> proximity-based selection | 1 | interaction (toggle dom widget) | | Tight poll timeout (250ms) -> >=2000ms | 2 | templates | - **Helper improvements**: Exposed locator getters on `ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and `WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying assertions (`toHaveCount()`, `toHaveText()`) directly. - **Flake pattern catalog**: Added section 7 table to `browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes for reviewers and future authors. - **Docs**: Fixed bad examples in `browser_tests/README.md` to use `expect.poll()`. - **Breaking**: None - **Dependencies**: None ## Review Focus - All fixes follow the rules in `browser_tests/FLAKE_PREVENTION_RULES.md` - No behavioral changes to tests -- only timing/retry strategy is updated - The `ContextMenu.waitForHidden` simplification removes a swallowed-error anti-pattern; both locators now use direct `waitFor({ state: 'hidden' })` --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>	2026-04-09 20:50:56 -07:00
Alexander Brown	f2d5bfab73	test(browser): refactor browser tests for reliability and maintainability (#8510) ... ## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	2026-02-03 12:29:40 -08:00