4 Commits

Author	SHA1	Message	Date
Christian Byrne	469a5edf99	feat: cloud-nodes catalog at /cloud/supported-nodes (#11903) ... *PR Created by the Glary-Bot Agent* --- ## Summary Adds a comfy.org page that lists every custom-node pack supported on Comfy Cloud, with per-pack detail subpages. Data is fetched at build time from `cloud.comfy.org/api/object_info` (gated by `WEBSITE_CLOUD_API_KEY`), sanitized of user content, joined with public registry metadata from `api.comfy.org/nodes`, and falls back to a committed snapshot — mirroring the existing Ashby careers integration pattern. - Index: `/cloud/supported-nodes` (en) and `/zh-CN/cloud/supported-nodes` (zh-CN) - Detail: `/cloud/supported-nodes/[pack]` and `/zh-CN/cloud/supported-nodes/[pack]`, generated via `getStaticPaths()` from the same fetcher as the index so the two routes can never diverge. ## What's new **Shared package (extracted)** - `@comfyorg/object-info-parser` — Zod schemas (`zComfyNodeDef`, `validateComfyNodeDef`), node-source classifier (`getNodeSource`, `isCustomNode`, `CORE_NODE_MODULES`), and helpers (`groupNodesByPack`, `sanitizeUserContent`). `src/schemas/nodeDefSchema.ts` and `src/types/nodeSource.ts` become 1-line re-export shims; existing imports keep compiling. **Build-time pipeline** - `apps/website/src/utils/cloudNodes.ts` — Ashby-style fetcher: retry/backoff `[1s, 2s, 4s]`, 10 s timeout via AbortController, Zod envelope + per-node validation, snapshot fallback, memoized via module-level `inflight` promise. - `apps/website/src/utils/cloudNodes.registry.ts` — Public registry enrichment (no auth, batches of 50, single retry, soft-fail). - `apps/website/src/utils/cloudNodes.ci.ts` — GitHub Actions annotations + step summary mirroring the Ashby reporter. - `apps/website/src/utils/cloudNodes.build.ts` — Single `loadPacksForBuild()` consumed by both index and detail pages so they share one source of truth. - `apps/website/scripts/refresh-cloud-nodes-snapshot.ts` — atomic-rename refresh CLI that walks pack/node string fields with a user-content extension regex *before* renaming the snapshot into place. - Mandatory user-content sanitization strips uploaded filenames from combo lists (`LoadImage`, `LoadImageMask`, `LoadImageOutput`, `LoadVideo`, `LoadAudio` zeroed; any combo value matching `/\.(png|jpe?g|webp|gif|mp4|mov|webm|wav|mp3|flac|ogg|safetensors|ckpt|pt)$/i` filtered). **Page + components** - `apps/website/src/pages/cloud/supported-nodes.astro` (en) + zh-CN twin. - `apps/website/src/pages/cloud/supported-nodes/[pack].astro` detail (en) + zh-CN twin, async `getStaticPaths` driven by `loadPacksForBuild()`. - `apps/website/src/components/cloud-nodes/{HeroSection,PackGridSection,PackCard,PackBanner,NodeList,PackDetail}.vue` — Vue 3.5 destructured props, `cn()` from `@comfyorg/tailwind-utils`, design-system tokens only, no PrimeVue. - Pack card name links to its detail page; banner uses the shared `fallback-gradient-avatar.svg` asset (copied into `apps/website/public/assets/images/`) when `banner_url` and `icon` are missing. - 25 new `cloudNodes.*` i18n keys in `en` + `zh-CN`. **Tests** - 33 unit tests in `@comfyorg/object-info-parser` (schemas, classifier, sanitizer, grouping). - 19 new website unit tests covering fetcher (10), CI reporter (6), registry enrichment (3) — Ashby patterns mirrored. - E2E: index smoke + search + banner + detail click-through + direct visit + zh-CN parity. ## Required maintainer follow-up GitHub Apps cannot push `.github/workflows/*` changes (push was rejected with `refusing to allow a GitHub App to create or update workflow … without workflows permission`), so the workflow edits prepared in this branch were reverted in commit `9be2abce8`. The intended diffs are documented as copy-paste-ready snippets in `apps/website/README.md` under the new "Cloud nodes integration → CI wiring" section. A maintainer must: 1. Provision `WEBSITE_CLOUD_API_KEY` in the repo secrets and the Vercel project env. 2. Apply the `ci-website-build.yaml` and `ci-vercel-website-preview.yaml` diffs documented in the README directly to `main` (or as a follow-up commit on this branch with a maintainer account). The committed snapshot lets builds succeed without the secret while the maintainer step is pending — pages render from `apps/website/src/data/cloud-nodes.snapshot.json`. ## Self-review (Oracle) Two warnings caught and fixed in commits `deba5ab02` and `99dfc3381`: - Index/detail pages now share a single source of truth (`loadPacksForBuild`), so a fresh fetch can't expose packs whose detail routes weren't generated. - Refresh script validates parsed snapshot fields *before* the atomic rename, instead of regex-scanning the serialized JSON after the file is already in place. ## Quality gates (local) ``` pnpm --filter @comfyorg/object-info-parser test → 33 passed pnpm --filter @comfyorg/website test:unit → 42 passed pnpm --filter @comfyorg/website typecheck → 0 errors pnpm --filter @comfyorg/website build → 47 pages built (incl. 6 cloud-nodes routes) pnpm lint → 0 errors (1 pre-existing warning in unrelated test file) pnpm knip → 0 errors (1 pre-existing tag hint in unrelated file) ``` E2E (`pnpm --filter @comfyorg/website test:e2e`) is intended to be run by the Vercel/CI pipelines. ## Manual verification Built `dist/`, served locally on port 4321, drove with Playwright: - `/cloud/supported-nodes` renders both pack cards, search input, sort dropdown - `/cloud/supported-nodes/comfyui-impact-pack` renders the metadata grid (publisher, downloads, stars, version, license, last updated) and 3 categorized node sections with 5 nodes total - `/zh-CN/cloud/supported-nodes` localizes hero (`Comfy Cloud 上的自定义节点`), label (`云端节点目录`), search placeholder (`搜索节点包或节点名称`), sort - `/zh-CN/cloud/supported-nodes/comfyui-controlnet-aux` localizes every metadata label (`查看仓库`, `发布者`, `下载量`, `GitHub 星标`, `最新版本`, `许可证`, `最后更新`) and renders dates with `Intl.DateTimeFormat('zh-CN')` (`2026年4月27日`) - Search input narrows pack count from 2 to 1 when typing `impact` (verified via DOM count) Banners render the shared `fallback-gradient-avatar.svg` when the snapshot's image URL doesn't resolve — expected in the local sandbox. ## Preview URL (after CI completes) `https://comfy-website-preview-pr-{N}.vercel.app/cloud/supported-nodes` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11903-feat-cloud-nodes-catalog-at-cloud-supported-nodes-3566d73d36508194afdec5f389897585) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>	2026-05-12 15:51:24 +00:00
Christian Byrne	35443e94f5	feat(website): SEO model pages — 207 models, FAQ JSON-LD, partner node support (#11892) ... ## Summary - Adds programmatic SEO model pages at `/p/supported-models/[slug]` for **207 models** auto-generated from `workflow_templates` (180 local + 27 partner nodes) - 3-file architecture: `generated-models.json` (auto-generated, checked in) + `model-metadata.ts` (editorial overrides) + `models.ts` (65-line merger) - Full JSON-LD per page: `SoftwareApplication` + `BreadcrumbList` + `FAQPage` (targeting AI Overviews / People Also Ask) - Partner node support: `directory: 'partner_nodes'` hides Download button, shows VIEW TUTORIAL - `generate-models.ts`: walks `workflow_templates` for local models + `API_PROVIDER_MAP` for 30+ partner integrations (Kling, Meshy, Luma, Runway, Stability AI, ByteDance, Google, etc.) - Weekly GH Actions workflow opens issue when new models appear in `workflow_templates` but not in `generated-models.json` - `add-model-page` Claude skill for Slack-driven model page PRs ## Files changed | File | Purpose | |------|---------| | `apps/website/src/config/generated-models.json` | Auto-generated, 207 models (27 partner + 180 local) | | `apps/website/src/config/model-metadata.ts` | Editorial overrides: docsUrl, blogUrl, featured (9 entries) | | `apps/website/src/config/models.ts` | 65-line merger — imports JSON + overrides, exports `models` + `getModelBySlug` | | `apps/website/scripts/generate-models.ts` | Build-time parser; run with `pnpm generate:models` | | `apps/website/src/i18n/translations.ts` | ~30 UI keys added (no per-model keys — displayName is plain string) | | `apps/website/src/pages/p/supported-models/[slug].astro` | Dynamic route with 3x JSON-LD schemas | | `apps/website/src/pages/p/supported-models/index.astro` | Model grid index page | | `apps/website/src/components/models/ModelHeroSection.vue` | Hero component | | `.github/workflows/model-page-discovery.yaml` | Weekly auto-discovery workflow | | `.claude/skills/add-model-page/SKILL.md` | Claude skill for adding/updating model pages | ## Test plan - [ ] `pnpm build` passes in `apps/website` - [ ] `/p/supported-models` index renders 207 model cards - [ ] `/p/supported-models/kling-ai` shows Partner Node eyebrow, no Download button, VIEW TUTORIAL CTA - [ ] `/p/supported-models/flux-1-dev` shows Diffusion Model eyebrow, Download + Tutorial buttons - [ ] `/p/supported-models/umt5-xxl-fp8-e4m3fn-scaled` redirects 301 to `umt5-xxl-fp16` (canonicalSlug) - [ ] Structured data validator shows FAQPage + SoftwareApplication + BreadcrumbList valid Fixes FE-421 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-12 14:50:23 +00:00
Christian Byrne	65876c635d	feat(website): add responsive media tooling for marketing assets (#11869) ... *PR Created by the Glary-Bot Agent* --- ## Summary Adds the building blocks for a responsive media system on `apps/website`, motivated by the gallery video blurriness raised in Slack. Three independent pieces: 1. **`<SiteVideo>` Vue component + URL helper** — emits a `<video>` with multiple `<source>` tags, designed to pair with assets named `${name}-${width}.${format}` on `media.comfy.org`. 2. **`scripts/process-videos.sh`** — local-developer `ffmpeg` helper that produces VP9/WebM + H.264/MP4 variants and a poster JPG. Not wired into CI; the team uploads to `media.comfy.org` out-of-band. 3. **Marketing image conventions** — shared `MARKETING_FORMATS` / `MARKETING_WIDTHS` constants and a README documenting how to render local marketing images via Astro's built-in `<Picture>` from `astro:assets`. This PR is **infrastructure only** — no existing pages are modified. Adoption (e.g. converting `HeroSection`, gallery videos) is a follow-up. The new files are added to knip's ignore list with the existing "pending stacked PR" pattern. ## Why this shape - **No custom `<Picture>` wrapper.** Astro 5 already ships a `ResponsiveImage` component (name conflict), and Astro's `LocalImageProps | RemoteImageProps` discriminated union does not survive a thin wrapper without unsafe `as` casts. Shared constants give the consistency benefit at lower cost. - **No CI media-upload step.** The `Release: Website` workflow currently only refreshes the Ashby snapshot; wiring GCS uploads into it would require new secrets and team coordination beyond this PR's scope. The script runs locally and outputs are uploaded to `media.comfy.org` the same way as today. - **Single resolution per `<video>`.** `<source media="...">` inside `<video>` is unreliable across browsers (Safari ignores it). The script generates multiple widths so callers can pick one per page; JS-based selection can be layered on later if metrics demand it. ## What's verified - `pnpm --filter @comfyorg/website test:unit` — 30 pass (7 new for `buildVideoSources` / `videoKey`) - `pnpm --filter @comfyorg/website typecheck` — clean - `pnpm --filter @comfyorg/website build` — 41 pages built clean - `pnpm knip` — exit 0 - `oxfmt --check` and `oxlint` clean on all changed files - `bash -n` on `process-videos.sh` clean; usage and missing-deps paths exercised manually - Manual: home page and `/gallery` rendered via `astro dev` — both unchanged with zero console errors (screenshots attached) ## Review feedback addressed After Oracle review, three follow-up commits land: - **`SiteVideo` reactivity** — `sources` is now `computed`; the `<video>` is keyed on the joined source URLs so it remounts when the source set changes (browsers don't reload on `<source>` mutation). - **`SiteVideo` accessibility** — `aria-hidden="true"` only when truly decorative (no `alt` and no `controls`). - **Shell script robustness** — probes duration with `ffprobe` and falls back to `t=0` for clips shorter than 1s; enables `nocaseglob` so `CLIP.MP4` is picked up. - **Docs** — clarifies when to use `<SiteVideo>` (lightweight multi-source) vs `<VideoPlayer>` (captions, controls, scrubber). ## Out of scope (follow-ups) - Converting existing pages (`HeroSection`, customer detail heros, gallery) to use the new components. Most current images are CDN-hosted and migrating them is a separate decision. - Re-encoding the gallery videos at a higher source width to actually fix the blurriness — that requires the team to run `process-videos.sh` against the source clips and re-upload. - Combining `<SiteVideo>`'s multi-source support with `<VideoPlayer>`'s rich chrome. ## Screenshots   ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11869-feat-website-add-responsive-media-tooling-for-marketing-assets-3556d73d3650818899c7f9ed3204c9a5) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>	2026-05-04 13:25:20 +00:00
Christian Byrne	5a8ded7959	Website: pull careers page listing from ashby API (#11590) ... Careers --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>	2026-04-24 11:51:43 -07:00