Alexander Brown
10845cb865
Revert "fix: add post-processing script to fix i18n nodeDefs array corruption" ( #8736 )
...
Reverts Comfy-Org/ComfyUI_frontend#8718
2026-02-07 20:08:02 -08:00
Terry Jia
828323e263
fix: add post-processing script to fix i18n nodeDefs array corruption ( #8718 )
...
## Summary
@lobehub/i18n-cli (GPT-4.1) converts numeric-keyed objects like {"0":
{...}, "1": {...}} into JSON arrays with null gaps, which
crashes vue-i18n path resolution.
Add a post-processing step that converts arrays back to objects after
translation.
## Screenshots (if applicable)
before
https://github.com/user-attachments/assets/44e81790-feae-405b-b2c4-098b06a98785
after
https://github.com/user-attachments/assets/5d1bd836-c923-437a-aca0-7ebd4d8acb89
<img width="2703" height="1083" alt="image"
src="https://github.com/user-attachments/assets/370a2eb0-c46d-4901-a23a-ab3002a9660d "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8718-fix-add-post-processing-script-to-fix-i18n-nodeDefs-array-corruption-3006d73d365081dab020fea997ec4c0a )
by [Unito](https://www.unito.io )
2026-02-07 18:19:37 -08:00
sno
d7ec24abc3
fix: use PR_GH_TOKEN in lint/i18n workflows to trigger e2e tests ( #8484 )
...
## Summary
Add `PR_GH_TOKEN` to ci-lint-format and i18n-update-core workflows to
ensure commits trigger e2e test runs.
## Changes
- Add `token: ${{ secrets.PR_GH_TOKEN }}` to checkout step in
`.github/workflows/ci-lint-format.yaml`
- Add `token: ${{ secrets.PR_GH_TOKEN }}` to checkout step in
`.github/workflows/i18n-update-core.yaml`
## Context
This matches the pattern used consistently across all other workflows in
the repository (release-version-bump, version-bump-desktop-ui,
api-update-registry-api-types, i18n-update-nodes, etc.).
Without this token, commits made by these workflows don't trigger
downstream e2e tests, which can lead to issues being missed.
## Original Work
Original idea & implementation by @drjkl in commits:
- be3a8d61c50ccb254bhttps://github.com/user-attachments/assets/31762d68-a37f-4926-b463-84d184d4309d "
/>
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
2026-01-30 00:09:28 -08:00
Alexander Brown
bd4920febc
Chore: Actions updates and cleanup ( #8377 )
...
## Summary
...
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8377-WIP-Chore-Actions-updates-and-cleanup-2f66d73d3650818483a8dffa32a6f245 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Amp <amp@ampcode.com >
2026-01-28 21:22:39 -08:00
Alexander Brown
8b514463b3
CI: Add formatting after generating locales. ( #8360 )
...
## Summary
Hopefully prevent thrashing from formatting disagreements.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8360-CI-Add-formatting-after-generating-locales-2f66d73d36508143a2f6d5ba90056110 )
by [Unito](https://www.unito.io )
2026-01-27 22:31:54 -08:00
Alexander Brown
aa5125cef6
Chore: Oxfmt formatting pass ( #8341 )
...
## Summary
Expanding the covered files to format. One-time formatting pass. To be
added to the `.git-blame-ignore-revs`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8341-Chore-Oxfmt-formatting-pass-2f56d73d365081f2988fcb7570f9a2a1 )
by [Unito](https://www.unito.io )
2026-01-27 17:59:19 -08:00
Benjamin Lu
a9653ba9c7
Remove unsupported workflow description fields ( #6881 )
...
## Summary
Remove top-level `description` keys from workflows because they are not
valid in GitHub Actions workflow syntax (see
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax?utm_source=chatgpt.com ).
## Changes
- **What**: delete the unsupported `description:` field from all
workflow YAMLs under `.github/workflows/`.
## Review Focus
- Confirm workflows still show intended names and triggers without the
invalid `description` metadata.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6881-Remove-unsupported-workflow-description-fields-2b56d73d365081ed9f20eb7f57956bc6 )
by [Unito](https://www.unito.io )
2025-11-23 22:53:51 -07:00
Christian Byrne
5e4965d131
ci: add yamllint ( #6682 )
...
adds yaml linting to CI and applies rules to existing yaml files.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6682-ci-add-yamllint-2aa6d73d365081b4b67ae9d9cc86760f )
by [Unito](https://www.unito.io )
2025-11-13 11:10:48 -07:00
snomiao
8cc5b52c64
refactor: reorganize GitHub workflows with consistent naming convention ( #5891 )
...
## Summary
This PR implements a systematic naming convention for all GitHub
workflows to improve organization and discoverability. All 22 workflows
have been renamed and grouped by logical categories with consistent
prefixes.
## Changes
### Naming Convention
- **`ci-*`**: Continuous Integration workflows (testing, linting,
validation)
- **`pr-*`**: PR-specific automation triggered by labels
- **`release-*`**: Release management workflows
- **`types-*`**: TypeScript type generation workflows
- **`i18n-*`**: Internationalization workflows
### Key Renames
- `tests-ci.yaml` → `ci-tests-e2e.yaml`
- `vitest-tests.yaml` → `ci-tests-unit.yaml`
- `storybook-and-chromatic-ci.yaml` → `ci-tests-storybook.yaml`
- `auto-backport.yaml` → `pr-backport.yaml`
- `claude-pr-review.yml` → `pr-claude-review.yaml`
- `version-bump.yaml` → `release-version-bump.yaml`
- `publish-frontend-types.yaml` → `release-npm-types.yaml`
- `create-dev-pypi-package.yaml` → `release-pypi-dev.yaml`
### Test Workflow Improvements
- Grouped all test workflows under `ci-tests-*` pattern
- Fork-safe deployment workflows: `ci-tests-e2e-forks.yaml`,
`ci-tests-storybook-forks.yaml`
- Added comments explaining fork deployment security workarounds
### Documentation
- Added comprehensive `.github/workflows/README.md`
- Documents naming conventions, best practices, and workflow
organization
- Includes trigger patterns and external dependencies
## Benefits
1. **Better Organization**: Workflows are now grouped logically by
prefix
2. **Improved Discoverability**: Easy to find related workflows
3. **Consistent Naming**: All workflows follow the same pattern
4. **Clear Purpose**: Workflow names immediately indicate their function
5. **Maintainable**: README provides guidelines for future workflows
## Test Plan
- [x] All workflow cross-references updated
- [x] Display names match new file names
- [x] Fork deployment workflows properly reference main workflows
- [x] Release workflows reference correct npm types workflow
- [x] All workflows retain original functionality
🤖 Generated with [Claude Code](https://claude.ai/code )
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5891-refactor-reorganize-GitHub-workflows-with-consistent-naming-convention-2806d73d365081febe47c7511bf0507e )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2025-10-17 08:32:33 +09:00
