Alexander Brown
8ccc8b9d8f
fix: browser test fixes and typecheck script
...
- Fix widgetTextBox locator in ComfyPage
- Add exact match for 'Add' button in search filter panel
- Fix ClipboardHelper to properly handle undefined vs null locators
- Use canvasOps.dragAndDrop in NodeOperationsHelper
- Use nodeOps.waitForGraphNodes in link interaction tests
- Add typecheck:browser script for browser tests
Amp-Thread-ID: https://ampcode.com/threads/T-019c1696-c595-7724-8dca-64f73f19f478
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 16:25:40 -08:00
Alexander Brown
22ff808d59
fix(browser_tests): use getByRole for interactive elements
...
Replace fragile CSS selectors with Playwright getByRole() for better
accessibility-based testing:
- bottomPanelShortcuts.spec.ts: button[aria-label] -> getByRole
- execution.spec.ts: .p-dialog-close-button -> getByRole
- backgroundImageUpload.spec.ts: button:has(.pi-*) -> getByRole
- nodeHelp.spec.ts: button:has(.pi-question) -> getByRole
- BaseDialog.ts: closeButton uses getByRole
- ComfyNodeSearchBox.ts: Add button uses getByRole
- Topbar.ts: close-button uses getByRole
Amp-Thread-ID: https://ampcode.com/threads/T-019c155c-92e1-76f3-b6ce-7fc3ffa11582
Co-authored-by: Amp <amp@ampcode.com >
2026-01-31 10:46:11 -08:00
Alexander Brown
7b68b19f11
Component: The Rest of the PrimeVue buttons ( #7649 )
...
## Summary
Automated initial change, cleaned up manually.
Please check the screenshot changes.
Includes a11y updates to icon buttons.
Doesn't hit the buttons in Desktop.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7649-WIP-Component-The-Rest-of-the-PrimeVue-buttons-2ce6d73d365081d68e06f200f1321267 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-12-29 15:03:34 -08:00
Alexander Brown
5c01861f4e
Tests: Playwright test timeouts ( #7231 )
...
## Summary
See where we can use proper DOM waiting instead of waitForTimeout.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7231-WIP-Playwright-test-timeouts-2c36d73d3650812b966ac3d9c338dfd4 )
by [Unito](https://www.unito.io )
2025-12-08 15:50:35 -08:00
Alexander Brown
b264685052
lint: add tsconfig for browser_tests, fix existing violations ( #5633 )
...
## Summary
See https://typescript-eslint.io/blog/project-service/ for context.
Creates a browser_tests specific tsconfig so that they can be linted.
Does not add a package.json script to do the linting yet, but `pnpm exec
eslint browser_tests` should work for now.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5633-lint-add-tsconfig-for-browser_tests-fix-existing-violations-2726d73d3650819d8ef2c4b0abc31e14 )
by [Unito](https://www.unito.io )
2025-09-18 11:35:44 -07:00
bymyself
73ecacfa2d
Fix searchbox dismissed when closing filter panel ( #2196 )
2025-01-08 10:57:55 -05:00
Chenlei Hu
b4352bcd8d
Fix node search box filter test ( #1561 )
2024-11-15 21:18:19 -05:00
Chenlei Hu
59c999324e
Split ComfyPage fixture ( #1305 )
...
* Split down page components
* Move litegraph utils
* nit
2024-10-25 08:29:02 -04:00
