mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 07:00:23 +00:00
13db1e484b
## Summary https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow ## Changes - **What**: Will cancel ongoing checks when new commits are pushed to the PR branch ## Review Focus What other optimizations could we make? ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6000-CI-Add-concurrency-checks-to-PR-workflows-2876d73d3650813cbb65eb8c397ac748) by [Unito](https://www.unito.io)
99 lines
3.4 KiB
YAML
99 lines
3.4 KiB
YAML
name: Claude PR Review
|
|
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
issues: write
|
|
id-token: write
|
|
statuses: write
|
|
|
|
on:
|
|
pull_request:
|
|
types: [labeled]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
wait-for-ci:
|
|
runs-on: ubuntu-latest
|
|
if: github.event.label.name == 'claude-review'
|
|
outputs:
|
|
should-proceed: ${{ steps.check-status.outputs.proceed }}
|
|
steps:
|
|
- name: Wait for other CI checks
|
|
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
check-regexp: '^(lint-and-format|test|playwright-tests)'
|
|
wait-interval: 30
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Check if we should proceed
|
|
id: check-status
|
|
run: |
|
|
CHECK_RUNS=$(gh api repos/${{ github.repository }}/commits/${{ github.event.pull_request.head.sha }}/check-runs --jq '.check_runs[] | select(.name | test("lint-and-format")) | {name, conclusion}')
|
|
|
|
if echo "$CHECK_RUNS" | grep -Eq '"conclusion": "(failure|cancelled|timed_out|action_required)"'; then
|
|
echo "Some CI checks failed - skipping Claude review"
|
|
echo "proceed=false" >> $GITHUB_OUTPUT
|
|
else
|
|
echo "All CI checks passed - proceeding with Claude review"
|
|
echo "proceed=true" >> $GITHUB_OUTPUT
|
|
fi
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
claude-review:
|
|
needs: wait-for-ci
|
|
if: needs.wait-for-ci.outputs.should-proceed == 'true'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v5
|
|
with:
|
|
fetch-depth: 0
|
|
ref: refs/pull/${{ github.event.pull_request.number }}/head
|
|
|
|
- name: Install pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 10
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies for analysis tools
|
|
run: |
|
|
pnpm install -g typescript @vue/compiler-sfc
|
|
|
|
- name: Run Claude PR Review
|
|
uses: anthropics/claude-code-action@v1.0.6
|
|
with:
|
|
label_trigger: "claude-review"
|
|
prompt: |
|
|
Read the file .claude/commands/comprehensive-pr-review.md and follow ALL the instructions exactly.
|
|
|
|
CRITICAL: You must post individual inline comments using the gh api commands shown in the file.
|
|
DO NOT create a summary comment.
|
|
Each issue must be posted as a separate inline comment on the specific line of code.
|
|
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
|
|
claude_args: "--max-turns 256 --allowedTools 'Bash(git:*),Bash(gh api:*),Bash(gh pr:*),Bash(gh repo:*),Bash(jq:*),Bash(echo:*),Read,Write,Edit,Glob,Grep,WebFetch'"
|
|
env:
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
|
|
BASE_SHA: ${{ github.event.pull_request.base.sha }}
|
|
REPOSITORY: ${{ github.repository }}
|
|
|
|
- name: Remove claude-review label
|
|
if: always()
|
|
run: gh pr edit ${{ github.event.pull_request.number }} --remove-label "claude-review"
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|