mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 07:00:23 +00:00
e7745eb2be
## Summary Replace color/dark-color pairs in components with design tokens to allow for easy overriding. <!-- Also standardizes the icon pattern to simplify the tailwind config. --> ## Changes - **What**: Token based colors, for now, mostly. - **Breaking**: Got approval from Design to collapse some very similar pairs of colors that seem to have diverged in implementations over time. Some of the colors might be a little different, but we can tweak them later. ## Review Focus Still have quite a few places from which to remove `dark-theme`, but this at least gets the theming much closer. Need to decide if I want to keep going in here or cut this and do the rest in a subsequent PR. ## Screenshots (if applicable) <!-- Add screenshots or video recording to help explain your changes --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5908-WIP-Make-components-themeable-2816d73d365081ffbc05d189fe71084b) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
90 lines
2.9 KiB
TypeScript
90 lines
2.9 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../../../fixtures/ComfyPage'
|
|
import { VueNodeFixture } from '../../../fixtures/utils/vueNodeFixtures'
|
|
|
|
test.describe('Vue Node Collapse', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.Graph.CanvasMenu', false)
|
|
await comfyPage.setSetting('Comfy.EnableTooltips', true)
|
|
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
test('should allow collapsing node with collapse icon', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Get the KSampler node from the default workflow
|
|
const nodes = await comfyPage.getNodeRefsByType('KSampler')
|
|
const node = nodes[0]
|
|
const vueNode = new VueNodeFixture(node, comfyPage.page)
|
|
|
|
// Initially should not be collapsed
|
|
expect(await node.isCollapsed()).toBe(false)
|
|
const body = await vueNode.getBody()
|
|
await expect(body).toBeVisible()
|
|
|
|
// Collapse the node
|
|
await vueNode.toggleCollapse()
|
|
expect(await node.isCollapsed()).toBe(true)
|
|
|
|
// Verify node content is hidden
|
|
const collapsedSize = await node.getSize()
|
|
await expect(body).not.toBeVisible()
|
|
|
|
// Expand again
|
|
await vueNode.toggleCollapse()
|
|
expect(await node.isCollapsed()).toBe(false)
|
|
await expect(body).toBeVisible()
|
|
|
|
// Size should be restored
|
|
const expandedSize = await node.getSize()
|
|
expect(expandedSize.height).toBeGreaterThanOrEqual(collapsedSize.height)
|
|
})
|
|
|
|
test('should show collapse/expand icon state', async ({ comfyPage }) => {
|
|
const nodes = await comfyPage.getNodeRefsByType('KSampler')
|
|
const node = nodes[0]
|
|
const vueNode = new VueNodeFixture(node, comfyPage.page)
|
|
|
|
// Check initial expanded state icon
|
|
let iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).not.toContain('-rotate-90')
|
|
|
|
// Collapse and check icon
|
|
await vueNode.toggleCollapse()
|
|
iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).toContain('-rotate-90')
|
|
|
|
// Expand and check icon
|
|
await vueNode.toggleCollapse()
|
|
iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).not.toContain('-rotate-90')
|
|
})
|
|
|
|
test('should preserve title when collapsing/expanding', async ({
|
|
comfyPage
|
|
}) => {
|
|
const nodes = await comfyPage.getNodeRefsByType('KSampler')
|
|
const node = nodes[0]
|
|
const vueNode = new VueNodeFixture(node, comfyPage.page)
|
|
|
|
// Set custom title
|
|
await vueNode.setTitle('Test Sampler')
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Collapse
|
|
await vueNode.toggleCollapse()
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Expand
|
|
await vueNode.toggleCollapse()
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Verify title is still displayed
|
|
const header = await vueNode.getHeader()
|
|
await expect(header).toContainText('Test Sampler')
|
|
})
|
|
})
|