mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 07:00:23 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
81 lines
2.2 KiB
TypeScript
81 lines
2.2 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { _for_testing } from '@/renderer/extensions/vueNodes/widgets/composables/useFloatWidget'
|
|
|
|
vi.mock('@/scripts/widgets', () => ({
|
|
addValueControlWidgets: vi.fn()
|
|
}))
|
|
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: () => ({
|
|
settings: {}
|
|
})
|
|
}))
|
|
|
|
const { onFloatValueChange } = _for_testing
|
|
|
|
describe('useFloatWidget', () => {
|
|
describe('onFloatValueChange', () => {
|
|
let widget: any
|
|
|
|
beforeEach(() => {
|
|
// Reset the widget before each test
|
|
widget = {
|
|
options: {},
|
|
value: 0
|
|
}
|
|
})
|
|
|
|
it('should not round values when round option is not set', () => {
|
|
widget.options.round = undefined
|
|
onFloatValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(5.7)
|
|
})
|
|
|
|
it('should round values based on round option', () => {
|
|
widget.options.round = 0.5
|
|
onFloatValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(5.5)
|
|
|
|
widget.options.round = 0.1
|
|
onFloatValueChange.call(widget, 5.74)
|
|
expect(widget.value).toBe(5.7)
|
|
|
|
widget.options.round = 1
|
|
onFloatValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(6)
|
|
})
|
|
|
|
it('should respect min and max constraints after rounding', () => {
|
|
widget.options.round = 0.5
|
|
widget.options.min = 1
|
|
widget.options.max = 5
|
|
|
|
// Should round to 1 and respect min
|
|
onFloatValueChange.call(widget, 0.7)
|
|
expect(widget.value).toBe(1)
|
|
|
|
// Should round to 5.5 but be clamped to max of 5
|
|
onFloatValueChange.call(widget, 5.3)
|
|
expect(widget.value).toBe(5)
|
|
|
|
// Should round to 3.5 and be within bounds
|
|
onFloatValueChange.call(widget, 3.6)
|
|
expect(widget.value).toBe(3.5)
|
|
})
|
|
|
|
it('should handle Number.EPSILON for precision issues', () => {
|
|
widget.options.round = 0.1
|
|
|
|
// Without Number.EPSILON, 1.35 / 0.1 = 13.499999999999998
|
|
// which would round to 13 * 0.1 = 1.3 instead of 1.4
|
|
onFloatValueChange.call(widget, 1.35)
|
|
expect(widget.value).toBeCloseTo(1.4, 10)
|
|
|
|
// Test another edge case
|
|
onFloatValueChange.call(widget, 2.95)
|
|
expect(widget.value).toBeCloseTo(3, 10)
|
|
})
|
|
})
|
|
})
|