mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 07:00:23 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
148 lines
4.1 KiB
TypeScript
148 lines
4.1 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { nextTick, reactive } from 'vue'
|
|
|
|
import { useBrowserTabTitle } from '@/composables/useBrowserTabTitle'
|
|
|
|
// Mock i18n module
|
|
vi.mock('@/i18n', () => ({
|
|
t: (key: string, fallback: string) =>
|
|
key === 'g.nodesRunning' ? 'nodes running' : fallback
|
|
}))
|
|
|
|
// Mock the execution store
|
|
const executionStore = reactive({
|
|
isIdle: true,
|
|
executionProgress: 0,
|
|
executingNode: null as any,
|
|
executingNodeProgress: 0,
|
|
nodeProgressStates: {} as any,
|
|
activePrompt: null as any
|
|
})
|
|
vi.mock('@/stores/executionStore', () => ({
|
|
useExecutionStore: () => executionStore
|
|
}))
|
|
|
|
// Mock the setting store
|
|
const settingStore = reactive({
|
|
get: vi.fn(() => 'Enabled')
|
|
})
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: () => settingStore
|
|
}))
|
|
|
|
// Mock the workflow store
|
|
const workflowStore = reactive({
|
|
activeWorkflow: null as any
|
|
})
|
|
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
|
useWorkflowStore: () => workflowStore
|
|
}))
|
|
|
|
describe('useBrowserTabTitle', () => {
|
|
beforeEach(() => {
|
|
// reset execution store
|
|
executionStore.isIdle = true
|
|
executionStore.executionProgress = 0
|
|
executionStore.executingNode = null as any
|
|
executionStore.executingNodeProgress = 0
|
|
executionStore.nodeProgressStates = {}
|
|
executionStore.activePrompt = null
|
|
|
|
// reset setting and workflow stores
|
|
;(settingStore.get as any).mockReturnValue('Enabled')
|
|
workflowStore.activeWorkflow = null
|
|
|
|
// reset document title
|
|
document.title = ''
|
|
})
|
|
|
|
it('sets default title when idle and no workflow', () => {
|
|
useBrowserTabTitle()
|
|
expect(document.title).toBe('ComfyUI')
|
|
})
|
|
|
|
it('sets workflow name as title when workflow exists and menu enabled', async () => {
|
|
;(settingStore.get as any).mockReturnValue('Enabled')
|
|
workflowStore.activeWorkflow = {
|
|
filename: 'myFlow',
|
|
isModified: false,
|
|
isPersisted: true
|
|
}
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('myFlow - ComfyUI')
|
|
})
|
|
|
|
it('adds asterisk for unsaved workflow', async () => {
|
|
;(settingStore.get as any).mockReturnValue('Enabled')
|
|
workflowStore.activeWorkflow = {
|
|
filename: 'myFlow',
|
|
isModified: true,
|
|
isPersisted: true
|
|
}
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('*myFlow - ComfyUI')
|
|
})
|
|
|
|
// Fails when run together with other tests. Suspect to be caused by leaked
|
|
// state from previous tests.
|
|
it.skip('disables workflow title when menu disabled', async () => {
|
|
;(settingStore.get as any).mockReturnValue('Disabled')
|
|
workflowStore.activeWorkflow = {
|
|
filename: 'myFlow',
|
|
isModified: false,
|
|
isPersisted: true
|
|
}
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('ComfyUI')
|
|
})
|
|
|
|
it('shows execution progress when not idle without workflow', async () => {
|
|
executionStore.isIdle = false
|
|
executionStore.executionProgress = 0.3
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('[30%]ComfyUI')
|
|
})
|
|
|
|
it('shows node execution title when executing a node using nodeProgressStates', async () => {
|
|
executionStore.isIdle = false
|
|
executionStore.executionProgress = 0.4
|
|
executionStore.nodeProgressStates = {
|
|
'1': { state: 'running', value: 5, max: 10, node: '1', prompt_id: 'test' }
|
|
}
|
|
executionStore.activePrompt = {
|
|
workflow: {
|
|
changeTracker: {
|
|
activeState: {
|
|
nodes: [{ id: 1, type: 'Foo' }]
|
|
}
|
|
}
|
|
}
|
|
}
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('[40%][50%] Foo')
|
|
})
|
|
|
|
it('shows multiple nodes running when multiple nodes are executing', async () => {
|
|
executionStore.isIdle = false
|
|
executionStore.executionProgress = 0.4
|
|
executionStore.nodeProgressStates = {
|
|
'1': {
|
|
state: 'running',
|
|
value: 5,
|
|
max: 10,
|
|
node: '1',
|
|
prompt_id: 'test'
|
|
},
|
|
'2': { state: 'running', value: 8, max: 10, node: '2', prompt_id: 'test' }
|
|
}
|
|
useBrowserTabTitle()
|
|
await nextTick()
|
|
expect(document.title).toBe('[40%][2 nodes running]')
|
|
})
|
|
})
|